christoffer-bolin / weathermodule

src/Weather/WeatherController.php

<?php

namespace Anax\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Anax\Models\WeatherForecast;
use Anax\Models\GetGeo;

class WeatherController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    public function indexAction()
    {
        $page = $this->di->get("page");
        $title = "Väderprognos";

        $page->add("weather/index");
        return $page->render([
            "title" => $title,
        ]);
    }


    // public function getGeoCords($location)
    // {
    //     $geo = new GetGeo();
    //
    //     $res = $geo->getGeo($location);
    //
    //     return $res;
    // }

    public function checkWeatherAction()
    {
        $page = $this->di->get("page");
        $title = "Resultat";
        $location = $_GET["location"];


        $type = $this->di->get("request")->getGet("type");

        $weather = $this->di->get("weather");

        if ($type == 'prognos') {
            if (strpos($location, ",") == true) {

It seems like you are loosely comparing strpos($location, ',') of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

                $exploded = explode(",", $location);
                $answer = $weather->checkWeather($exploded[0], $exploded[1]);
            } else {
                $geo = new GetGeo();
                $res = $geo->getGeo($location);
                if ($res["longitude"] !== null) {
                    $answer = $weather->checkWeather($res["latitude"], $res["longitude"]);
                } else {
                    $error = "Felaktig input, prova igen!";
                }
            }
        } elseif ($type == 'history') {
            if (strpos($location, ",") == true) {

It seems like you are loosely comparing strpos($location, ',') of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

                $exploded = explode(",", $location);
                $answer = $weather->checkHistory($exploded[0], $exploded[1]);
            } else {
                $geo = new GetGeo();
                $res = $geo->getGeo($location);
                if ($res["longitude"] !== null) {
                    $answer = $weather->checkHistory($res["latitude"], $res["longitude"]);
                } else {
                    $error = "Felaktig input, prova igen!";
                }
            }
        }



        $data = [
            "forecast" => $answer ?? null,
            "error" => $error ?? null,
            "lat" => $exploded[0] ?? $res["latitude"],

The variable $res does not seem to be defined for all execution paths leading up to this point.

            "lon" => $exploded[1] ?? $res["longitude"]
        ];


        $page->add("weather/resultpage", $data);

        return $page->render([
            "title" => $title,
        ]);
    }
}