christoffer-bolin / weathermodule

src/Models/WeatherForecast.php

<?php

namespace Anax\Models;

class WeatherForecast
{

    public function __construct()
    {
        $this->oneWeek = [];

The property oneWeek does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->weather = [];

The property weather does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }


    public function fetchApiKey()
    {
        $access_key = require ANAX_INSTALL_PATH . "/config/weatherapi.php";
        $access_key = $access_key["weatherKeyHolder"]["weatherKey"];
        return $access_key;
    }


    public function checkWeather($lat, $lon)
    {
        if ($this->validateNumbersCords($lat, $lon) && $this->validateCords($lat, $lon)) {
            $exclude = "current,minutely,hourly,alerts";

            $access_key = $this->fetchApiKey();

            $ch = curl_init('https://api.openweathermap.org/data/2.5/onecall?lat='.$lat.'&lon='.$lon.'&exclude='.$exclude.'&units=metric&lang=sv&appid='.$access_key.'');
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

            // Store the data:
            $json = curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

            // Decode JSON response:
            $api_result = json_decode($json, true);

            $week = $api_result["daily"];

            foreach ($week as $value) {
                $current = [
                    "date" => gmdate("Y-m-d", $value["dt"]),
                    "temp" => $value["temp"]["min"] . " - " . $value["temp"]["max"],
                    "description" => $value["weather"][0]["description"]
                ];
                $this->oneWeek[] = $current;

The property oneWeek does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }
        }
        return $this->oneWeek;
    }

    public function getFiveDays()
    {
        $days = [];
        for ($i = 0; $i > -5; $i--) {
            $days[] = strtotime("$i days");
        }
        return $days;
    }

    public function validateCords($lat, $lon)
    {
        if ($lat < 90 && $lat > -90 && $lon < 180 && $lon > -180) {
            return true;
        } else {
            $this->weather = "Felaktig input, försök igen.";

The property weather does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
    }

    public function validateNumbersCords($lat, $lon)
    {
        if (!ctype_alpha($lat) && !ctype_alpha($lon)) {
            return true;
        } else {
            $this->weather = "Felaktig input, försök igen.";

The property weather does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
    }

    public function checkHistory($lat, $lon)
    {
        if ($this->validateNumbersCords($lat, $lon) && $this->validateCords($lat, $lon)) {
            $pastFiveDays = $this->getFivedays();
            $fetch = 'https://api.openweathermap.org/data/2.5/onecall/timemachine?lat='.$lat.'&lon='.$lon.'&lang=sv&units=metric&dt=';

            $mcurl = curl_multi_init();

            $fiveDays = [];
            foreach ($pastFiveDays as $day) {
                $ch3 = curl_init($fetch.$day.'&APPID='.$this->access_key.'');

The property access_key does not exist on Anax\Models\WeatherForecast. Did you maybe forget to declare it?

                curl_setopt($ch3, CURLOPT_RETURNTRANSFER, 1);

It seems like $ch3 can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

                curl_multi_add_handle($mcurl, $ch3);

It seems like $ch3 can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

                $fiveDays[] = $ch3;
            }

            $run = null;

            do {
                curl_multi_exec($mcurl, $run);
            } while ($run);

            foreach ($fiveDays as $curl) {
                curl_multi_remove_handle($mcurl, $curl);
            }

            curl_multi_close($mcurl);

            foreach ($fiveDays as $day) {
                $output = curl_multi_getcontent($day);
                $exploded = json_decode($output, true);

                $current = [
                    "date" => gmdate("Y-m-d", $exploded["current"]["dt"]),
                    "temp" => $exploded["current"]["temp"],
                    "description" => $exploded["current"]["weather"][0]["description"]
                ];
                $this->weather[] = $current;

The property weather does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }
        }
        return $this->weather;
    }
}