flask_jsondash/static/js/utils.js - Code Metrics - Inspection of "Add new field for charts: classes, and apply it to..." - christabor/flask_jsondash - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 66a6f6...d4f8e2 )

by Chris

created 2017-05-24 21:54 UTC

flask_jsondash/static/js/utils.js B

↳ Parent: Project

Complexity

Total Complexity	38
Complexity/F	2.11

Size

Lines of Code	148
Function Count	18

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	2
c	3
b	0
f	0
nc	96
dl	0
loc	148
rs	8.3999
wmc	38
mnd	1
bc	27
fnc	18
bpm	1.5
cpm	2.1111
noi	11

13 Functions

Rating	Name	Size	Complexity
A	jsondash.util.isSparkline	3	1
D	jsondash.util.intervalStrToMS	38	9
A	jsondash.util.serializeToJSON	8	1
A	jsondash.util.getValidParamString	13	1
A	jsondash.util.getDigitSize	11	1
A	jsondash.util.getCSSClasses	15	4
A	jsondash.util.isOverride	3	1
B	jsondash.util.isD3Subtype	10	6
A	jsondash.util.polygon	3	1
A	jsondash.util.scaleStr	3	1
A	jsondash.util.s4	5	1
A	jsondash.util.translateStr	3	1
A	jsondash.util.guid	5	1

/**
 * Utility functions.
 */

jsondash = jsondash || {util: {}};


jsondash.util.getCSSClasses = function(conf, defaults) {
    var classes = {};
    if(conf.classes === undefined && defaults !== undefined) {
        $.each(defaults, function(i, klass){
            classes[klass] = true;
        });
        return classes;
    }
    if(conf.classes !== undefined) {
        $.each(conf.classes, function(i, klass){
            classes[klass] = true;
        });
    }
    return classes;
};

jsondash.util.getValidParamString = function(arr) {
    // Jquery $.serialize and $.serializeArray will
    // return empty query parameters, which is undesirable and can
    // be error prone for RESTFUL endpoints.
    // e.g. `foo=bar&bar=` becomes `foo=bar`
    var param_str = '';
    arr = arr.filter(function(param, i){return param.value !== '';});

    $.each(arr, function(i, param){
        param_str += (param.name + '=' + param.value);
        if(i < arr.length - 1 && arr.length > 1) param_str += '&';
if (a > 0)
    b = 42;
    });
    return param_str;
};

/**
 * [intervalStrToMS Convert a string formatted to indicate]
 * @param  {[String]} ival_fmt [The interval format string e.g. "1d", "2h"]
 * @return {[Number]} [The number of milliseconds]
 */
jsondash.util.intervalStrToMS = function(ival_fmt) {
    // Just return number if it's a regular integer.
    if(!isNaN(ival_fmt)) {
        return ival_fmt;
    }
    var pieces = ival_fmt.split('-');
    var amt = parseInt(pieces[0], 10);
    if(pieces.length !== 2 || isNaN(amt) || amt === 0) {
        // Force NO value if the format is invalid.
        // This would be used to ensure the interval
        // is not set in the first place.
        return null;
    }
    var ival = pieces[1].toLowerCase();
    var ms2s = 1000;
    var ms2min = 60 * ms2s;
    var ms2hr = 60 * ms2min;
    var ms2day = 24 * ms2hr;

    // Seconds
    if(ival === 's') {
        return amt * ms2s;
    }
    // Minutes
    if(ival === 'm') {
        return amt * ms2min;
    }
    // Hours
    if(ival === 'h') {
        return amt * ms2hr;
    }
    // Days
    if(ival === 'd') {
        return amt * ms2day;
    }
    // Anything else is invalid.
    return null;
};

jsondash.util.serializeToJSON = function(arr) {
    // Convert form data to a proper json value
    var json = {};
    $.each(arr, function(_, pair){
        json[pair.name] = pair.value;
    });
    return json;
};

jsondash.util.isOverride = function(config) {
    return config.override && config.override === true;
};

// Credit: http://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript
jsondash.util.s4 = function() {
    return Math.floor((1 + Math.random()) * 0x10000)
    .toString(16)
    .substring(1);
};

jsondash.util.guid = function() {
    var s4 = jsondash.util.s4;
    return s4() + s4() + '-' + s4() + '-' + s4() + '-' +
    s4() + '-' + s4() + s4() + s4();
};

jsondash.util.polygon = function(d) {
    return "M" + d.join("L") + "Z";
};

jsondash.util.scaleStr = function(x, y) {
    return 'scale(' + x + ',' + y + ')';
};

jsondash.util.translateStr = function(x, y) {
    return 'translate(' + x + ',' + y + ')';
};

jsondash.util.isD3Subtype = function(config) {
    // Handle specific D3 types that aren't necessarily referenced under
    // the D3 namespace in a select field.
    if(config.type === 'dendrogram') return true;
if (a > 0)
    b = 42;
    if(config.type === 'voronoi') return true;
if (a > 0)
    b = 42;
    if(config.type === 'circlepack') return true;
if (a > 0)
    b = 42;
    if(config.type === 'treemap') return true;
if (a > 0)
    b = 42;
    if(config.type === 'radial-dendrogram') return true;
if (a > 0)
    b = 42;
    return false;
};

jsondash.util.isSparkline = function(type) {
    return type.substr(0, 10) === 'sparklines';
};

/**
 * [getDigitSize return a d3 scale for adjusting font size based
 *     on digits and width of container.]
 */
jsondash.util.getDigitSize = function() {
    var BOX_PADDING = 20;

    // scale value is reversed, since we want
    // the font-size to get smaller as the number gets longer.
    var scale = d3.scale.linear()

        .clamp(true)
        .domain([2, 14]) // min/max digits length: $0 - $999,999,999.00
        .range([90, 30]); // max/min font-size
    window.scale = scale;
    return scale;
};

if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
    module.exports = jsondash;
}


1			/**
2			* Utility functions.
3			*/
4
5			jsondash = jsondash \|\| {util: {}};
			0 ignored issues – show Best Practice introduced 2017-05-24 21:55 UTC by Report Bug Copy Issue Report If you intend to check if the variable `jsondash` is declared in the current environment, consider using `typeof jsondash === "undefined"` instead. This is safe if the variable is not actually declared. Loading history... Bug introduced 2017-05-24 21:55 UTC by Report Bug Copy Issue Report The variable `jsondash` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.jsondash`. Loading history...
6
7			jsondash.util.getCSSClasses = function(conf, defaults) {
8			var classes = {};
9			if(conf.classes === undefined && defaults !== undefined) {
10			$.each(defaults, function(i, klass){
11			classes[klass] = true;
12			});
13			return classes;
14			}
15			if(conf.classes !== undefined) {
16			$.each(conf.classes, function(i, klass){
17			classes[klass] = true;
18			});
19			}
20			return classes;
21			};
22
23			jsondash.util.getValidParamString = function(arr) {
24			// Jquery $.serialize and $.serializeArray will
25			// return empty query parameters, which is undesirable and can
26			// be error prone for RESTFUL endpoints.
27			// e.g. `foo=bar&bar=` becomes `foo=bar`
28			var param_str = '';
29			arr = arr.filter(function(param, i){return param.value !== '';});
			0 ignored issues – show Unused Code introduced 2016-10-21 02:59 UTC by Report Bug Copy Issue Report The parameter `i` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
30			$.each(arr, function(i, param){
31			param_str += (param.name + '=' + param.value);
32			if(i < arr.length - 1 && arr.length > 1) param_str += '&';
			0 ignored issues – show Coding Style Best Practice introduced 2016-10-21 02:59 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
33			});
34			return param_str;
35			};
36
37			/**
38			* [intervalStrToMS Convert a string formatted to indicate]
39			* @param {[String]} ival_fmt [The interval format string e.g. "1d", "2h"]
40			* @return {[Number]} [The number of milliseconds]
41			*/
42			jsondash.util.intervalStrToMS = function(ival_fmt) {
43			// Just return number if it's a regular integer.
44			if(!isNaN(ival_fmt)) {
45			return ival_fmt;
46			}
47			var pieces = ival_fmt.split('-');
48			var amt = parseInt(pieces[0], 10);
49			if(pieces.length !== 2 \|\| isNaN(amt) \|\| amt === 0) {
50			// Force NO value if the format is invalid.
51			// This would be used to ensure the interval
52			// is not set in the first place.
53			return null;
54			}
55			var ival = pieces[1].toLowerCase();
56			var ms2s = 1000;
57			var ms2min = 60 * ms2s;
58			var ms2hr = 60 * ms2min;
59			var ms2day = 24 * ms2hr;
60
61			// Seconds
62			if(ival === 's') {
63			return amt * ms2s;
64			}
65			// Minutes
66			if(ival === 'm') {
67			return amt * ms2min;
68			}
69			// Hours
70			if(ival === 'h') {
71			return amt * ms2hr;
72			}
73			// Days
74			if(ival === 'd') {
75			return amt * ms2day;
76			}
77			// Anything else is invalid.
78			return null;
79			};
80
81			jsondash.util.serializeToJSON = function(arr) {
82			// Convert form data to a proper json value
83			var json = {};
84			$.each(arr, function(_, pair){
85			json[pair.name] = pair.value;
86			});
87			return json;
88			};
89
90			jsondash.util.isOverride = function(config) {
91			return config.override && config.override === true;
92			};
93
94			// Credit: http://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript
95			jsondash.util.s4 = function() {
96			return Math.floor((1 + Math.random()) * 0x10000)
97			.toString(16)
98			.substring(1);
99			};
100
101			jsondash.util.guid = function() {
102			var s4 = jsondash.util.s4;
103			return s4() + s4() + '-' + s4() + '-' + s4() + '-' +
104			s4() + '-' + s4() + s4() + s4();
105			};
106
107			jsondash.util.polygon = function(d) {
108			return "M" + d.join("L") + "Z";
109			};
110
111			jsondash.util.scaleStr = function(x, y) {
112			return 'scale(' + x + ',' + y + ')';
113			};
114
115			jsondash.util.translateStr = function(x, y) {
116			return 'translate(' + x + ',' + y + ')';
117			};
118
119			jsondash.util.isD3Subtype = function(config) {
120			// Handle specific D3 types that aren't necessarily referenced under
121			// the D3 namespace in a select field.
122			if(config.type === 'dendrogram') return true;
			0 ignored issues – show Coding Style Best Practice introduced 2016-10-01 05:29 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
123			if(config.type === 'voronoi') return true;
			0 ignored issues – show Coding Style Best Practice introduced 2016-10-01 05:29 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
124			if(config.type === 'circlepack') return true;
			0 ignored issues – show Coding Style Best Practice introduced 2016-10-01 05:29 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
125			if(config.type === 'treemap') return true;
			0 ignored issues – show Coding Style Best Practice introduced 2016-10-01 05:29 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
126			if(config.type === 'radial-dendrogram') return true;
			0 ignored issues – show Coding Style Best Practice introduced 2016-10-01 05:29 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
127			return false;
128			};
129
130			jsondash.util.isSparkline = function(type) {
131			return type.substr(0, 10) === 'sparklines';
132			};
133
134			/**
135			* [getDigitSize return a d3 scale for adjusting font size based
136			* on digits and width of container.]
137			*/
138			jsondash.util.getDigitSize = function() {
139			var BOX_PADDING = 20;
			0 ignored issues – show Unused Code introduced 2016-10-01 05:29 UTC by Report Bug Copy Issue Report The variable `BOX_PADDING` seems to be never used. Consider removing it. Loading history...
140			// scale value is reversed, since we want
141			// the font-size to get smaller as the number gets longer.
142			var scale = d3.scale.linear()
			0 ignored issues – show Bug introduced 2016-10-01 05:29 UTC by Report Bug Copy Issue Report The variable `d3` seems to be never declared. If this is a global, consider adding a `/** global: d3 */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
143			.clamp(true)
144			.domain([2, 14]) // min/max digits length: $0 - $999,999,999.00
145			.range([90, 30]); // max/min font-size
146			window.scale = scale;
147			return scale;
148			};
149
150			if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
151			module.exports = jsondash;
152			}
153

christabor / flask_jsondash

Push — master ( 66a6f6...d4f8e2 )

flask_jsondash/static/js/utils.js B

Complexity

Size

Duplication

Importance

13 Functions

Duplication Side-by-Side

Filter issues like