chrisparana / TeamDynamix-Slackbot001-U

app/SlashCommandHandlers/Jobs/ShowTDTicketJob.php

<?php

namespace Slackbot001\SlashCommandHandlers\Jobs;

use Illuminate\Support\Facades\Log;
use Slackbot001\SessionManager;
use Spatie\SlashCommand\Attachment;
use Spatie\SlashCommand\AttachmentField;
use Spatie\SlashCommand\Jobs\SlashCommandResponseJob;

class ShowTDTicketJob extends SlashCommandResponseJob
{
    // notice here that Laravel will automatically inject dependencies here
    public function handle()
    {
        $build = \Tremby\LaravelGitVersion\GitVersionHelper::getVersion();

        $userSession = new SessionManager();
        $TDinstance = $userSession->setupSession($this->request->userId, $this->request->token);

        if ($TDinstance->checkToken()) {

This code seems to be duplicated across your project.

            Log::info('CP_ShowTDTicketJob: There is a token.');
            $auth = true;
            $ticket = $TDinstance->ticket($this->request->text);
        } else {
            Log::info('CP_ShowTDTicketJob: No token.');
            $auth = false;
            $ticket = null;
        }

        if ($ticket && $auth) {
            $date = date('F jS, Y', strtotime($ticket['CreatedDate']));
            $ticketURL = (string) $TDinstance->rootAppsUrl().'Tickets/TicketDet?TicketID='.$ticket['ID'];
            $assets = $TDinstance->searchAssets($ticket['ID']);
            $assetnames = 'No Assets';
            $userSession()->increment('td_tickets');

            if (count($assets)) {
                $assetnames = '';
                foreach ($assets as $asset) {
                    $assetnames = $assetnames.$asset['Name'].', ';
                }
                $assetnames = substr($assetnames, 0, -2);
            }

            $attachmentFields[] = AttachmentField::create('Description', $ticket['Description']);

$attachmentFields was never initialized. Although not strictly required by PHP, it is generally a good practice to add $attachmentFields = array(); before regardless.

            $attachmentFields[] = AttachmentField::create('Requestor', $ticket['RequestorName']."\n".$ticket['RequestorEmail']."\n".$ticket['RequestorPhone'])->displaySideBySide();
            $attachmentFields[] = AttachmentField::create('Location', $ticket['LocationName']."\n".$ticket['LocationRoomName'])->displaySideBySide();
            $attachmentFields[] = AttachmentField::create('Service', $ticket['ServiceName'])->displaySideBySide();
            $attachmentFields[] = AttachmentField::create('Status', $ticket['StatusName'])->displaySideBySide();
            $attachmentFields[] = AttachmentField::create('Assets', $assetnames)->displaySideBySide();
            $attachmentFields[] = AttachmentField::create('Assigned To', $ticket['ResponsibleFullName']."\n".$ticket['ResponsibleEmail'])->displaySideBySide();
            $attachmentFields[] = AttachmentField::create('Date Opened', $date)->displaySideBySide();

            $this
               ->respondToSlack("🕵️ Here's what I found about ticket `{$this->request->text}`")
               ->withAttachment(Attachment::create()
                   ->setFallback("{$ticket['Title']}")
                   ->setColor('#439FE0')
                   ->setTitle("{$ticket['Title']}")
                   ->setTitleLink("{$ticketURL}")
                   ->setFields($attachmentFields)
                   ->setFooter('CP_TD/S API bot microservice v'.$TDinstance->getVersion().' | Build: '.$build)
               )
               ->displayResponseToEveryoneOnChannel()
               ->send();
        } elseif (!$ticket && $auth) {
            $this->respondToSlack('🕵️ I could not find that ticket.')->send();
        } else {
            $this->respondToSlack("🕵️ I wasn't authorized to access TeamDynamix.")->send();
        }
    }
}