CP_TDinstance::searchTicketsName() - Code Metrics - Inspection of "Fixed missing payload" - chrisparana/TeamDynamix-Slackbot001-U - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c951b...45e4b7 )

by Chris

created 2017-11-28 23:14 UTC

CP_TDinstance::searchTicketsName() B

↳ Parent: CP_TDinstance

Complexity

Conditions	5
Paths	6

Size

Total Lines	26
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	19
nc	6
nop	1
dl	0
loc	26
rs	8.439
c	0
b	0
f	0

<?php

namespace Slackbot001;

use Illuminate\Support\Facades\Log;

class CP_TDauth
{
    protected $auth = '';
    protected $expires = '';
    protected $BEID = '';
    protected $WebServicesKey = '';
    protected $urlroot = '';
    protected $appsroot = '';
    protected $appid = '';
    protected $authstring = '';
    protected $authsig = '';
    protected $header = '';

    public function __construct()
    {
        $a = func_get_args();
        $i = func_num_args();
        if (method_exists($this, $f = '__construct'.$i)) {
            call_user_func_array([$this, $f], $a);
        }
    }

    private function __construct0()
    {
        Log::info('CP_TDauth: Constructing empty self.');
    }

    private function __construct5($b, $w, $u, $i, $e)
    {
        Log::info('CP_TDauth: Constructing self with new authorization.');
        $this->setEnv($e, $u);
        $this->authorize($b, $w, $this->urlroot);
        $this->BEID = $b;
        $this->WebServicesKey = $w;
        $this->appid = $i;
    }

    private function __construct6($b, $w, $u, $i, $e, $a)
    {
        Log::info('CP_TDauth: Constructing self with existing authorization.');
        $this->setEnv($e, $u);
        $this->BEID = $b;
        $this->WebServicesKey = $w;
        $this->appid = $i;

        $parts = explode('.', $a);
        if(count($parts) == 3) {
            list($JWTheader, $JWTpayload, $JWTsig) = $parts;
            $this->auth = $a;
            $this->expires = json_decode(base64_decode($JWTpayload))->exp;
            $this->authstring = 'Authorization: Bearer '.$this->auth;
            $this->header = $JWTheader;
            $this->authsig = $JWTsig;
            return;
        }
            Log::info('CP_TDauth: Invalid token.');
    }

    private function setEnv($e, $u)
    {
        if ($e == 'prod') {
            Log::info('CP_TDauth: Setup for production.');
            $this->urlroot = $u.'TDWebApi/api/';
            $this->appsroot = $u.'TDNext/Apps/';
        } elseif ($e == 'sandbox') {
            Log::info('CP_TDauth: Setup for sandbox.');
            $this->urlroot = $u.'SBTDWebApi/api/';
            $this->appsroot = $u.'SBTDNext/Apps/';
        }
    }

    private function authorize($b, $w, $u)
    {
        Log::info('CP_TDauth: authorize method called.');
        Log::info('CP_TDauth: authorize requesting at ['.$u.'auth/loginadmin].');
        $ch = curl_init($u.'auth/loginadmin');
        $payload = json_encode(['BEID' => $b, 'WebServicesKey' => $w]);
        curl_setopt($ch, CURLOPT_POSTFIELDS, $payload);
        curl_setopt($ch, CURLOPT_HTTPHEADER, ['Content-Type:application/json']);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        $bearer = curl_exec($ch);
        curl_close($ch);
        if (!$bearer) {
            Log::info('CP_TDauth: Authorization failed.');
        } else {
            Log::info('CP_TDauth: Authorization successful.');
            list($JWTheader, $JWTpayload, $JWTsig) = explode('.', $bearer);
            $this->auth = $bearer;
            $this->expires = json_decode(base64_decode($JWTpayload))->exp;
            $this->authstring = 'Authorization: Bearer '.$this->auth;
        }
    }

    public function checkToken()
    {
        Log::info('CP_TDauth: checkToken method called.');
        if ($this->authstring) {
            if (($this->expires - time()) <= 10) {
                $this->authorize($this->BEID, $this->WebServicesKey, $this->urlroot);
                Log::info('CP_TDauth: Token was expired. Replaced with new token.');
            } else {
                $remain = $this->expires - time();
                Log::info('CP_TDauth: Token ok, time remaining: '.$remain);
            }

            return true;
        } else {
            Log::info('CP_TDauth: No token.');

            return false;
        }
    }

    public function __toString()
    {
        Log::info('CP_TDauth: __toString method called.');
        $this->checkToken();
        Log::info('CP_TDauth: returning JWT.');

        return $this->auth;
    }

    public function getVersion()
    {
        Log::info('CP_TDauth: getVersion method called.');

        return '0.98b';
    }
}

class CP_TDinstance extends CP_TDauth
{
    private function connect($type, $point, $data)
    {
        Log::info('CP_TDinstance: connect method called.');
        $this->checkToken();
        $ch = curl_init($this->urlroot.$point);
        curl_setopt($ch, CURLOPT_HTTPHEADER, ['Content-Type:application/json', $this->authstring]);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        if ($type == 'post') {
            Log::info('CP_TDinstance: connect method POST.');
            curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'POST');
            curl_setopt($ch, CURLOPT_POSTFIELDS, $data);
        } else {
            Log::info('CP_TDinstance: connect method GET.');
        }
        $result = curl_exec($ch);

        return json_decode($result, true);
    }

    private function flagCheck($r)
    {
        Log::info('CP_TDinstance: flagCheck method called.');
        $check = substr($r, -3);
        if (substr($check, 1, 1) == '-') {
            $flag = substr($check, 1, 2);
            Log::info('CP_TDinstance: flagCheck given flag '.$flag);

            return $flag;
        } else {
            return;
        }
    }

    public function ticket($ticketno)
    {
        Log::info('CP_TDinstance: ticket method called.');
        $ticket = $this->connect('get', $this->appid.'/tickets/'.$ticketno, '');

        return $ticket;
    }

    public function searchTicketsName($search)
    {
        Log::info('CP_TDinstance: searchTicketsName method called.');
        $flag = $this->flagCheck($search);

        if (!$flag) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $people = $this->searchPeople($search);
            foreach ($people as $person) {
                $uids[] = $person['UID'];
            }
            if (isset($uids)) {
                $tickets = $this->searchResponsibility($uids);


                return $tickets;
            } else {
                return;
            }
        } else {
            if ($flag = '-r') {

                $data = ['RequestorNameSearch' => substr($search, 0, -3)];
                $data_string = json_encode($data);
                $tickets = $this->connect('post', $this->appid.'/tickets/search', $data_string);

                return $tickets;
            } else {
                return;
            }
        }
    }

    public function searchPeople($search)

    {
        Log::info('CP_TDinstance: searchPeople method called.');
        $data = ['SearchText' => $search];
        $data_string = json_encode($data);
        $people = $this->connect('post', 'people/search', $data_string);

        return $people;
    }

    public function searchAssets($search)

    {
        Log::info('CP_TDinstance: searchAssets method called.');
        $ticketids = [(int) $search];
        $data = ['TicketIDs' => $ticketids];
        $data_string = json_encode($data);
        $assets = $this->connect('post', 'assets/search', $data_string);

        return $assets;
    }

    public function searchResponsibility($search)
    {
        Log::info('CP_TDinstance: searchResponsibility method called.');
        if (!is_array($search)) {
            $search = [(string) $search];
        }
        $ResponsibilityUids = $search;
        $data = ['ResponsibilityUids' => $ResponsibilityUids];
        $data_string = json_encode($data);
        $tickets = $this->connect('post', '/tickets/search', $data_string);

        return $tickets;
    }

    public function rootAppsUrl()
    {
        Log::info('CP_TDinstance: rootAppsUrl method called.');

        return $this->appsroot.$this->appid.'/';
    }
}


1		<?php
2
3		namespace Slackbot001;
4
5		use Illuminate\Support\Facades\Log;
6
7		class CP_TDauth
8		{
9		protected $auth = '';
10		protected $expires = '';
11		protected $BEID = '';
12		protected $WebServicesKey = '';
13		protected $urlroot = '';
14		protected $appsroot = '';
15		protected $appid = '';
16		protected $authstring = '';
17		protected $authsig = '';
18		protected $header = '';
19
20		public function __construct()
21		{
22		$a = func_get_args();
23		$i = func_num_args();
24		if (method_exists($this, $f = '__construct'.$i)) {
25		call_user_func_array([$this, $f], $a);
26		}
27		}
28
29		private function __construct0()
30		{
31		Log::info('CP_TDauth: Constructing empty self.');
32		}
33
34		private function __construct5($b, $w, $u, $i, $e)
35		{
36		Log::info('CP_TDauth: Constructing self with new authorization.');
37		$this->setEnv($e, $u);
38		$this->authorize($b, $w, $this->urlroot);
39		$this->BEID = $b;
40		$this->WebServicesKey = $w;
41		$this->appid = $i;
42		}
43
44		private function __construct6($b, $w, $u, $i, $e, $a)
45		{
46		Log::info('CP_TDauth: Constructing self with existing authorization.');
47		$this->setEnv($e, $u);
48		$this->BEID = $b;
49		$this->WebServicesKey = $w;
50		$this->appid = $i;
51
52		$parts = explode('.', $a);
53		if(count($parts) == 3) {
54		list($JWTheader, $JWTpayload, $JWTsig) = $parts;
55		$this->auth = $a;
56		$this->expires = json_decode(base64_decode($JWTpayload))->exp;
57		$this->authstring = 'Authorization: Bearer '.$this->auth;
58		$this->header = $JWTheader;
59		$this->authsig = $JWTsig;
60		return;
61		}
62		Log::info('CP_TDauth: Invalid token.');
63		}
64
65		private function setEnv($e, $u)
66		{
67		if ($e == 'prod') {
68		Log::info('CP_TDauth: Setup for production.');
69		$this->urlroot = $u.'TDWebApi/api/';
70		$this->appsroot = $u.'TDNext/Apps/';
71		} elseif ($e == 'sandbox') {
72		Log::info('CP_TDauth: Setup for sandbox.');
73		$this->urlroot = $u.'SBTDWebApi/api/';
74		$this->appsroot = $u.'SBTDNext/Apps/';
75		}
76		}
77
78		private function authorize($b, $w, $u)
79		{
80		Log::info('CP_TDauth: authorize method called.');
81		Log::info('CP_TDauth: authorize requesting at ['.$u.'auth/loginadmin].');
82		$ch = curl_init($u.'auth/loginadmin');
83		$payload = json_encode(['BEID' => $b, 'WebServicesKey' => $w]);
84		curl_setopt($ch, CURLOPT_POSTFIELDS, $payload);
85		curl_setopt($ch, CURLOPT_HTTPHEADER, ['Content-Type:application/json']);
86		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
87		$bearer = curl_exec($ch);
88		curl_close($ch);
89		if (!$bearer) {
90		Log::info('CP_TDauth: Authorization failed.');
91		} else {
92		Log::info('CP_TDauth: Authorization successful.');
93		list($JWTheader, $JWTpayload, $JWTsig) = explode('.', $bearer);
94		$this->auth = $bearer;
95		$this->expires = json_decode(base64_decode($JWTpayload))->exp;
96		$this->authstring = 'Authorization: Bearer '.$this->auth;
97		}
98		}
99
100		public function checkToken()
101		{
102		Log::info('CP_TDauth: checkToken method called.');
103		if ($this->authstring) {
104		if (($this->expires - time()) <= 10) {
105		$this->authorize($this->BEID, $this->WebServicesKey, $this->urlroot);
106		Log::info('CP_TDauth: Token was expired. Replaced with new token.');
107		} else {
108		$remain = $this->expires - time();
109		Log::info('CP_TDauth: Token ok, time remaining: '.$remain);
110		}
111
112		return true;
113		} else {
114		Log::info('CP_TDauth: No token.');
115
116		return false;
117		}
118		}
119
120		public function __toString()
121		{
122		Log::info('CP_TDauth: __toString method called.');
123		$this->checkToken();
124		Log::info('CP_TDauth: returning JWT.');
125
126		return $this->auth;
127		}
128
129		public function getVersion()
130		{
131		Log::info('CP_TDauth: getVersion method called.');
132
133		return '0.98b';
134		}
135		}
136
137		class CP_TDinstance extends CP_TDauth
138		{
139		private function connect($type, $point, $data)
140		{
141		Log::info('CP_TDinstance: connect method called.');
142		$this->checkToken();
143		$ch = curl_init($this->urlroot.$point);
144		curl_setopt($ch, CURLOPT_HTTPHEADER, ['Content-Type:application/json', $this->authstring]);
145		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
146		if ($type == 'post') {
147		Log::info('CP_TDinstance: connect method POST.');
148		curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'POST');
149		curl_setopt($ch, CURLOPT_POSTFIELDS, $data);
150		} else {
151		Log::info('CP_TDinstance: connect method GET.');
152		}
153		$result = curl_exec($ch);
154
155		return json_decode($result, true);
156		}
157
158		private function flagCheck($r)
159		{
160		Log::info('CP_TDinstance: flagCheck method called.');
161		$check = substr($r, -3);
162		if (substr($check, 1, 1) == '-') {
163		$flag = substr($check, 1, 2);
164		Log::info('CP_TDinstance: flagCheck given flag '.$flag);
165
166		return $flag;
167		} else {
168		return;
169		}
170		}
171
172		public function ticket($ticketno)
173		{
174		Log::info('CP_TDinstance: ticket method called.');
175		$ticket = $this->connect('get', $this->appid.'/tickets/'.$ticketno, '');
176
177		return $ticket;
178		}
179
180		public function searchTicketsName($search)
181		{
182		Log::info('CP_TDinstance: searchTicketsName method called.');
183		$flag = $this->flagCheck($search);
184
185		if (!$flag) {
		0 ignored issues – show Bug Best Practice introduced 2017-11-27 19:48 UTC by Report Bug Copy Issue Report The expression `$flag` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
186		$people = $this->searchPeople($search);
187		foreach ($people as $person) {
188		$uids[] = $person['UID'];
189		}
190		if (isset($uids)) {
191		$tickets = $this->searchResponsibility($uids);
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-11-27 19:48 UTC by Report Bug Copy Issue Report The variable `$uids` seems to be defined by a `foreach` iteration on line `187`. Are you sure the iterator is never empty, otherwise this variable is not defined? Loading history...
192
193		return $tickets;
194		} else {
195		return;
196		}
197		} else {
198		if ($flag = '-r') {
		0 ignored issues – show Unused Code introduced 2017-11-27 19:48 UTC by Report Bug Copy Issue Report The assignment to `$flag` is dead and can be removed. Loading history...
199		$data = ['RequestorNameSearch' => substr($search, 0, -3)];
200		$data_string = json_encode($data);
201		$tickets = $this->connect('post', $this->appid.'/tickets/search', $data_string);
202
203		return $tickets;
204		} else {
205		return;
206		}
207		}
208		}
209
210	View Code Duplication	public function searchPeople($search)
		0 ignored issues – show Duplication introduced 2017-11-27 19:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
211		{
212		Log::info('CP_TDinstance: searchPeople method called.');
213		$data = ['SearchText' => $search];
214		$data_string = json_encode($data);
215		$people = $this->connect('post', 'people/search', $data_string);
216
217		return $people;
218		}
219
220	View Code Duplication	public function searchAssets($search)
		0 ignored issues – show Duplication introduced 2017-11-27 19:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
221		{
222		Log::info('CP_TDinstance: searchAssets method called.');
223		$ticketids = [(int) $search];
224		$data = ['TicketIDs' => $ticketids];
225		$data_string = json_encode($data);
226		$assets = $this->connect('post', 'assets/search', $data_string);
227
228		return $assets;
229		}
230
231		public function searchResponsibility($search)
232		{
233		Log::info('CP_TDinstance: searchResponsibility method called.');
234		if (!is_array($search)) {
235		$search = [(string) $search];
236		}
237		$ResponsibilityUids = $search;
238		$data = ['ResponsibilityUids' => $ResponsibilityUids];
239		$data_string = json_encode($data);
240		$tickets = $this->connect('post', '/tickets/search', $data_string);
241
242		return $tickets;
243		}
244
245		public function rootAppsUrl()
246		{
247		Log::info('CP_TDinstance: rootAppsUrl method called.');
248
249		return $this->appsroot.$this->appid.'/';
250		}
251		}
252

chrisparana / TeamDynamix-Slackbot001-U

Push — master ( 5c951b...45e4b7 )

CP_TDinstance::searchTicketsName() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like