Conditions | 1 |
Total Lines | 120 |
Code Lines | 109 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | # -*- coding: utf-8 -*- |
||
115 | def test_synoname(self): |
||
116 | """Test abydos.distance.synoname.""" |
||
117 | # Base cases |
||
118 | self.assertEqual(synoname('', ''), 1) |
||
119 | self.assertEqual(synoname('', '', tests=['exact']), 1) |
||
120 | self.assertEqual(synoname('', '', tests=[]), 13) |
||
121 | self.assertEqual(synoname('', '', tests=['nonsense-test']), 13) |
||
122 | self.assertEqual(synoname('', '', ret_name=True), 'exact') |
||
123 | |||
124 | # Test input formats |
||
125 | self.assertEqual(synoname(('Brueghel II (the Younger)', 'Pieter', |
||
126 | 'Workshop of'), |
||
127 | ('Brueghel II (the Younger)', 'Pieter', |
||
128 | 'Workshop of')), 1) |
||
129 | self.assertEqual(synoname('Brueghel II (the Younger)#Pieter#' + |
||
130 | 'Workshop of', |
||
131 | 'Brueghel II (the Younger)#Pieter#' + |
||
132 | 'Workshop of'), 1) |
||
133 | self.assertEqual(synoname('22#Brueghel II (the Younger)#Pieter#' + |
||
134 | 'Workshop of', |
||
135 | '44#Brueghel II (the Younger)#Pieter#' + |
||
136 | 'Workshop of'), 1) |
||
137 | |||
138 | # approx_c tests |
||
139 | self.assertEqual(synoname(('Master of Brueghel II (the Younger)', |
||
140 | 'Pieter', 'Workshop of'), |
||
141 | ('Brueghel I (the Elder)', 'Pieter', |
||
142 | 'Workshop of')), 13) |
||
143 | self.assertEqual(synoname(('Master of Brueghel II', |
||
144 | 'Pieter', 'Workshop of'), |
||
145 | ('Master known as the Brueghel II', 'Pieter', |
||
146 | 'Workshop of')), 10) |
||
147 | |||
148 | # Types 1-12 |
||
149 | self.assertEqual(synoname(('Brueghel', 'Pieter', ''), |
||
150 | ('Brueghel', 'Pieter', ''), |
||
151 | ret_name=True), 'exact') |
||
152 | |||
153 | self.assertEqual(synoname(('Brueghel II', 'Pieter', ''), |
||
154 | ('Brueghel I', 'Pieter', ''), |
||
155 | ret_name=True), 'no_match') |
||
156 | self.assertEqual(synoname(('Breghel', 'Pieter', ''), |
||
157 | ('Brueghel', 'Pieter', ''), |
||
158 | ret_name=True), 'omission') |
||
159 | self.assertEqual(synoname(('Brueghel', 'Pieter', ''), |
||
160 | ('Breghel', 'Pieter', ''), |
||
161 | ret_name=True), 'omission') |
||
162 | self.assertEqual(synoname(('Brueghel', 'Piter', ''), |
||
163 | ('Brueghel', 'Pieter', ''), |
||
164 | ret_name=True), 'omission') |
||
165 | self.assertEqual(synoname(('Brueghel', 'Pieter', ''), |
||
166 | ('Brueghel', 'Piter', ''), |
||
167 | ret_name=True), 'omission') |
||
168 | self.assertEqual(synoname(('Brughel', 'Pieter', ''), |
||
169 | ('Breghel', 'Pieter', ''), |
||
170 | ret_name=True), 'substitution') |
||
171 | self.assertEqual(synoname(('Breughel', 'Peter', ''), |
||
172 | ('Breughel', 'Piter', ''), |
||
173 | ret_name=True), 'substitution') |
||
174 | self.assertEqual(synoname(('Brueghel', 'Pieter', ''), |
||
175 | ('Breughel', 'Pieter', ''), |
||
176 | ret_name=True), 'transposition') |
||
177 | self.assertEqual(synoname(('Brueghel', 'Peiter', ''), |
||
178 | ('Brueghel', 'Pieter', ''), |
||
179 | ret_name=True), 'transposition') |
||
180 | |||
181 | self.assertEqual(synoname(('Brueghel:', 'Pieter', ''), |
||
182 | ('Brueghel', 'Pi-eter', ''), |
||
183 | ret_name=True), 'punctuation') |
||
184 | self.assertEqual(synoname(('Brueghel,', 'Pieter', ''), |
||
185 | ('Brueghel', 'Pieter...', ''), |
||
186 | ret_name=True), 'punctuation') |
||
187 | self.assertEqual(synoname(('Seu rat', 'George Pierre', ''), |
||
188 | ('Seu-rat', 'George-Pierre', ''), |
||
189 | ret_name=True), 'punctuation') |
||
190 | self.assertEqual(synoname(('Picasso', '', ''), |
||
191 | ('Picasso', 'Pablo', ''), |
||
192 | ret_name=True), 'no_first') |
||
193 | self.assertEqual(synoname(('Pereira', 'I. R.', ''), |
||
194 | ('Pereira', 'Irene Rice', ''), |
||
195 | ret_name=True), 'initials') |
||
196 | self.assertEqual(synoname(('Pereira', 'I.', ''), |
||
197 | ('Pereira', 'Irene Rice', ''), |
||
198 | ret_name=True), 'initials') |
||
199 | self.assertNotEqual(synoname(('Pereira', 'I. R.', ''), |
||
200 | ('Pereira', 'I. Smith', ''), |
||
201 | ret_name=True), 'initials') |
||
202 | self.assertNotEqual(synoname(('Pereira', 'I. R. S.', ''), |
||
203 | ('Pereira', 'I. S. R.', ''), |
||
204 | ret_name=True), 'initials') |
||
205 | self.assertEqual(synoname(('de Goya', 'Francisco', ''), |
||
206 | ('de Goya y Lucientes', 'Francisco', ''), |
||
207 | ret_name=True), 'extension') |
||
208 | self.assertEqual(synoname(('Seurat', 'George', ''), |
||
209 | ('Seurat', 'George-Pierre', ''), |
||
210 | ret_name=True), 'extension') |
||
211 | self.assertEqual(synoname(('Gericault', 'Theodore', ''), |
||
212 | ('Gericault', 'Jean Louis Andre Theodore', |
||
213 | ''), |
||
214 | ret_name=True), 'inclusion') |
||
215 | self.assertEqual(synoname(('Dore', 'Gustave', ''), |
||
216 | ('Dore', 'Paul Gustave Louis Christophe', |
||
217 | ''), |
||
218 | ret_name=True), 'inclusion') |
||
219 | |||
220 | self.assertEqual(synoname(('Rosetti', 'Dante Gabriel', ''), |
||
221 | ('Rosetti', 'Gabriel Charles Dante', ''), |
||
222 | ret_name=True), 'word_approx') |
||
223 | self.assertEqual(synoname(('di Domenico di Bonaventura', 'Cosimo', ''), |
||
224 | ('di Tomme di Nuto', 'Luca', ''), |
||
225 | ret_name=True), 'no_match') |
||
226 | self.assertEqual(synoname(('Pereira', 'I. R.', ''), |
||
227 | ('Pereira', 'I. Smith', ''), |
||
228 | ret_name=True), 'word_approx') |
||
229 | self.assertEqual(synoname(('Antonello da Messina', '', ''), |
||
230 | ('Messina', 'Antonello da', ''), |
||
231 | ret_name=True), 'confusions') |
||
232 | self.assertEqual(synoname(('Brueghel', 'Pietter', ''), |
||
233 | ('Bruegghel', 'Pieter', ''), |
||
234 | ret_name=True), 'char_approx') |
||
235 | |||
239 |