Conditions | 1 |
Total Lines | 105 |
Code Lines | 99 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | # -*- coding: utf-8 -*- |
||
237 | def test_synoname_toolcode(self): |
||
238 | """Test abydos.synoname_toolcode.""" |
||
239 | # Base case |
||
240 | self.assertEqual(synoname_toolcode(''), ('', '', '0000000000$$')) |
||
241 | |||
242 | # from Synoname demo |
||
243 | self.assertEqual(synoname_toolcode('angelico', 'fra'), |
||
244 | ('angelico', 'fra', '0000000308$044a$af')) |
||
245 | self.assertEqual(synoname_toolcode('Aelst', 'Willem van', ''), |
||
246 | ('aelst', 'willem van', '0000001005$143a$awv')) |
||
247 | self.assertEqual(synoname_toolcode('Afro'), |
||
248 | ('afro', '', '0000000004$$a')) |
||
249 | self.assertEqual(synoname_toolcode('Afro', 'Basaldella'), |
||
250 | ('afro', 'basaldella', '0000001004$$ab')) |
||
251 | self.assertEqual(synoname_toolcode('Albright', 'Ivan'), |
||
252 | ('albright', 'ivan', '0000000408$$ai')) |
||
253 | self.assertEqual(synoname_toolcode('Antonello da Messina'), |
||
254 | ('antonello da messina', '', '0000000020$022b$adm')) |
||
255 | self.assertEqual(synoname_toolcode('Albright', 'Ivan Le Lorraine'), |
||
256 | ('albright', 'ivan le lorraine', |
||
257 | '0000001608$067b$ail')) |
||
258 | self.assertEqual(synoname_toolcode('Bazille', 'Frederic', |
||
259 | 'Attributed to'), |
||
260 | ('bazille', 'frederic', '1000000807$$bf')) |
||
261 | self.assertEqual(synoname_toolcode('Bazille', 'Frederick', |
||
262 | 'Attributed to'), |
||
263 | ('bazille', 'frederick', '1000000907$$bf')) |
||
264 | self.assertEqual(synoname_toolcode('Beerstraaten', 'Jan Abrahamsz.'), |
||
265 | ('beerstraaten', 'jan abrahamsz.', '0200001412$$bja')) |
||
266 | self.assertEqual(synoname_toolcode('Bonifacio di Pitati'), |
||
267 | ('bonifacio di pitati', '', '0000000019$035b$bdp')) |
||
268 | self.assertEqual(synoname_toolcode('Breughel the Younger', 'Jan'), |
||
269 | ('breughel the younger', 'jan', |
||
270 | '0020000320$134b$btyj')) |
||
271 | self.assertEqual(synoname_toolcode('Brown', 'W. W.'), |
||
272 | ('brown', 'w. w.', '0200000505$$bw')) |
||
273 | self.assertEqual(synoname_toolcode('Brueghel II (the Younger)', 'Jan'), |
||
274 | ('brueghel ii (the younger)', 'jan', |
||
275 | '0120490325$049b134b$bityj')) |
||
276 | self.assertEqual(synoname_toolcode('Brueghel II (the Younger)', |
||
277 | 'Pieter', 'Workshop of'), |
||
278 | ('brueghel ii (the younger)', 'pieter', |
||
279 | '3120490625$049b134b$bityp')) |
||
280 | self.assertEqual(synoname_toolcode('Bugiardini', |
||
281 | 'Guiliano di Piero di Simone'), |
||
282 | ('bugiardini', 'guiliano di piero di simone', |
||
283 | '0000002710$035b035b$bgdps')) |
||
284 | self.assertEqual(synoname_toolcode('Caravaggio', '', 'Follower of'), |
||
285 | ('caravaggio', '', '3000000010$$c')) |
||
286 | self.assertEqual(synoname_toolcode('Caravaggio', |
||
287 | 'Michelangelo Merisi da', |
||
288 | 'Follower of'), |
||
289 | ('caravaggio', 'michelangelo merisi da', |
||
290 | '3000002210$022a$cmd')) |
||
291 | self.assertEqual(synoname_toolcode('Oost the Younger', 'Jacob van'), |
||
292 | ('oost the younger', 'jacob van', |
||
293 | '0020000916$134b143a$otyjv')) |
||
294 | |||
295 | # additional tests for coverage |
||
296 | self.assertEqual(synoname_toolcode('Cato the Elder', '', 'Copy of'), |
||
297 | ('cato the elder', '', '2010000014$133b$cte')) |
||
298 | self.assertEqual(synoname_toolcode('Cato, the Elder', normalize=2), |
||
299 | ('cato the elder', '', '0110000014$133b$cte')) |
||
300 | self.assertEqual(synoname_toolcode('Cato the Elder', normalize=2), |
||
301 | ('cato the elder', '', '0010000014$133b$cte')) |
||
302 | self.assertEqual(synoname_toolcode('Lorem ipsum dolor sit amet, '+ |
||
303 | 'consectetur adipiscing elit, sed '+ |
||
304 | 'do eiusmod tempor incididunt ut '+ |
||
305 | 'labore et dolore magna aliqua. '+ |
||
306 | 'Nulla aliquet porttitor lacus '+ |
||
307 | 'luctus accumsan tortor posuere. '+ |
||
308 | 'Egestas purus viverra accumsan '+ |
||
309 | 'in. Ultrices mi tempus imperdiet '+ |
||
310 | 'nulla malesuada pellentesque '+ |
||
311 | 'elit eget gravida. Proin libero '+ |
||
312 | 'nunc consequat interdum varius '+ |
||
313 | 'sit amet mattis vulputate. '+ |
||
314 | 'Mauris ultrices eros in cursus '+ |
||
315 | 'turpis massa tincidunt dui. '+ |
||
316 | 'Faucibus in ornare quam viverra '+ |
||
317 | 'orci sagittis eu volutpat odio. '+ |
||
318 | 'Enim blandit volutpat maecenas '+ |
||
319 | 'volutpat blandit aliquam etiam. '+ |
||
320 | 'Vel quam elementum pulvinar '+ |
||
321 | 'etiam. Duis ut diam quam nulla '+ |
||
322 | 'porttitor massa id.', |
||
323 | normalize=1)[2], |
||
324 | '02000060626$068d$lidsacetumnpvgflo') |
||
325 | self.assertEqual(synoname_toolcode('Sainte-Vincent'), |
||
326 | ('sainte-vincent', '', '0100000014$110c$sv')) |
||
327 | self.assertEqual(synoname_toolcode('Lorem', 'Sainte-Vincent'), |
||
328 | ('lorem', 'sainte-vincent', |
||
329 | '0100001405$068d110b$lsvlo')) |
||
330 | self.assertEqual(synoname_toolcode('Louis II', 'Jean'), |
||
331 | ('louis ii', 'jean', '0000490408$049b068d$lijlo')) |
||
332 | self.assertEqual(synoname_toolcode('Louis', 'Jean II', normalize=2), |
||
333 | ('louis ii', 'jean', '0000490705$049a068d$ljilo')) |
||
334 | self.assertEqual(synoname_toolcode('Louis', 'Jean II ', normalize=2), |
||
335 | ('louis ii', 'jean', '0000490805$049b068d$ljilo')) |
||
336 | self.assertEqual(synoname_toolcode('Louis V.', 'Jean', normalize=2), |
||
337 | ('louis v.', 'jean', '0200000408$068d$lvjlo')) |
||
338 | self.assertEqual(synoname_toolcode('Louis V.', 'Ste.-Jean Ste.', |
||
339 | normalize=2), |
||
340 | ('louis v.', 'ste.-jean ste.', |
||
341 | '0200001408$068d127b127X$lvsjlo ste')) |
||
342 | |||
346 |