chrislit /
abydos
| Conditions | 16 |
| Total Lines | 85 |
| Code Lines | 51 |
| Lines | 37 |
| Ratio | 43.53 % |
| Tests | 33 |
| CRAP Score | 16 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like abydos.stemmer._snowball_swedish.SnowballSwedish.stem() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | # -*- coding: utf-8 -*- |
||
| 68 | 1 | def stem(self, word): |
|
| 69 | """Return Snowball Swedish stem. |
||
| 70 | |||
| 71 | Parameters |
||
| 72 | ---------- |
||
| 73 | word : str |
||
| 74 | The word to stem |
||
| 75 | |||
| 76 | Returns |
||
| 77 | ------- |
||
| 78 | str |
||
| 79 | Word stem |
||
| 80 | |||
| 81 | Examples |
||
| 82 | -------- |
||
| 83 | >>> stmr = SnowballSwedish() |
||
| 84 | >>> stmr.stem('undervisa') |
||
| 85 | 'undervis' |
||
| 86 | >>> stmr.stem('suspension') |
||
| 87 | 'suspension' |
||
| 88 | >>> stmr.stem('visshet') |
||
| 89 | 'viss' |
||
| 90 | |||
| 91 | """ |
||
| 92 | # lowercase, normalize, and compose |
||
| 93 | 1 | word = normalize('NFC', text_type(word.lower())) |
|
| 94 | |||
| 95 | 1 | r1_start = min(max(3, self._sb_r1(word)), len(word)) |
|
| 96 | |||
| 97 | # Step 1 |
||
| 98 | 1 | _r1 = word[r1_start:] |
|
| 99 | 1 | View Code Duplication | if _r1[-7:] == 'heterna': |
| 100 | 1 | word = word[:-7] |
|
| 101 | 1 | elif _r1[-6:] == 'hetens': |
|
| 102 | 1 | word = word[:-6] |
|
| 103 | 1 | elif _r1[-5:] in { |
|
| 104 | 'anden', |
||
| 105 | 'heten', |
||
| 106 | 'heter', |
||
| 107 | 'arnas', |
||
| 108 | 'ernas', |
||
| 109 | 'ornas', |
||
| 110 | 'andes', |
||
| 111 | 'arens', |
||
| 112 | 'andet', |
||
| 113 | }: |
||
| 114 | 1 | word = word[:-5] |
|
| 115 | 1 | elif _r1[-4:] in { |
|
| 116 | 'arna', |
||
| 117 | 'erna', |
||
| 118 | 'orna', |
||
| 119 | 'ande', |
||
| 120 | 'arne', |
||
| 121 | 'aste', |
||
| 122 | 'aren', |
||
| 123 | 'ades', |
||
| 124 | 'erns', |
||
| 125 | }: |
||
| 126 | 1 | word = word[:-4] |
|
| 127 | 1 | elif _r1[-3:] in {'ade', 'are', 'ern', 'ens', 'het', 'ast'}: |
|
| 128 | 1 | word = word[:-3] |
|
| 129 | 1 | elif _r1[-2:] in {'ad', 'en', 'ar', 'er', 'or', 'as', 'es', 'at'}: |
|
| 130 | 1 | word = word[:-2] |
|
| 131 | 1 | elif _r1[-1:] in {'a', 'e'}: |
|
| 132 | 1 | word = word[:-1] |
|
| 133 | 1 | elif _r1[-1:] == 's': |
|
| 134 | 1 | if len(word) > 1 and word[-2] in self._s_endings: |
|
| 135 | 1 | word = word[:-1] |
|
| 136 | |||
| 137 | # Step 2 |
||
| 138 | 1 | if word[r1_start:][-2:] in {'dd', 'gd', 'nn', 'dt', 'gt', 'kt', 'tt'}: |
|
| 139 | 1 | word = word[:-1] |
|
| 140 | |||
| 141 | # Step 3 |
||
| 142 | 1 | _r1 = word[r1_start:] |
|
| 143 | 1 | if _r1[-5:] == 'fullt': |
|
| 144 | 1 | word = word[:-1] |
|
| 145 | 1 | elif _r1[-4:] == 'löst': |
|
| 146 | 1 | word = word[:-1] |
|
| 147 | 1 | elif _r1[-3:] in {'lig', 'els'}: |
|
| 148 | 1 | word = word[:-3] |
|
| 149 | 1 | elif _r1[-2:] == 'ig': |
|
| 150 | 1 | word = word[:-2] |
|
| 151 | |||
| 152 | 1 | return word |
|
| 153 | |||
| 187 |
Loading history...