abydos.distance._baystat.sim_baystat()

Complexity

Conditions

18

Size

Total Lines	114
Code Lines	53

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	47
CRAP Score	18

Importance

Changes

0

# -*- coding: utf-8 -*-
def sim_baystat(src, tar, min_ss_len=None, left_ext=None, right_ext=None):

This function exceeds the maximum number of variables (16/15).

    """Return the Baystat similarity.

    Good results for shorter words are reported when setting min_ss_len to 1
    and either left_ext OR right_ext to 1.

    The Baystat similarity is defined in :cite:`Furnohr:2002`.

    This is ostensibly a port of the R module PPRL's implementation:
    https://github.com/cran/PPRL/blob/master/src/MTB_Baystat.cpp
    :cite:`Rukasz:2018`. As such, this could be made more pythonic.

    :param str src: source string for comparison
    :param str tar: target string for comparison
    :param int min_ss_len: minimum substring length to be considered
    :param int left_ext: left-side extension length
    :param int right_ext: right-side extension length
    :returns: the Baystat similarity
    :rtype: float

    >>> round(sim_baystat('cat', 'hat'), 12)
    0.666666666667
    >>> sim_baystat('Niall', 'Neil')
    0.4
    >>> round(sim_baystat('Colin', 'Cuilen'), 12)
    0.166666666667
    >>> sim_baystat('ATCG', 'TAGC')
    0.0
    """
    if src == tar:
        return 1
    if not src or not tar:
        return 0

    max_len = max(len(src), len(tar))

    if not (min_ss_len and left_ext and right_ext):
        # These can be set via arguments to the function. Otherwise they are
        # set automatically based on values from the article.
        if max_len >= 7:
            min_ss_len = 2
            left_ext = 2
            right_ext = 2
        else:
            # The paper suggests that for short names, (exclusively) one or the
            # other of left_ext and right_ext can be 1, with good results.
            # I use 0 & 0 as the default in this case.
            min_ss_len = 1
            left_ext = 0
            right_ext = 0

    pos = 0
    match_len = 0

    while True:
        if pos + min_ss_len > len(src):
            return match_len / max_len

        hit_len = 0
        ix = 1

The name ix does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        substring = src[pos : pos + min_ss_len]
        search_begin = pos - left_ext

        if search_begin < 0:
            search_begin = 0
            left_ext_len = pos
        else:
            left_ext_len = left_ext

        if pos + min_ss_len + right_ext >= len(tar):
            right_ext_len = len(tar) - pos - min_ss_len
        else:
            right_ext_len = right_ext

        if (
            search_begin + left_ext_len + min_ss_len + right_ext_len

Wrong hanging indentation before block (add 4 spaces).

            > search_begin

Wrong hanging indentation before block (add 4 spaces).

        ):
            search_val = tar[
                search_begin : (
                    search_begin + left_ext_len + min_ss_len + right_ext_len
                )
            ]
        else:
            search_val = ''

        flagged_tar = ''
        while substring in search_val and pos + ix <= len(src):
            hit_len = len(substring)
            flagged_tar = tar.replace(substring, '#' * hit_len)

            if pos + min_ss_len + ix <= len(src):
                substring = src[pos : pos + min_ss_len + ix]

            if pos + min_ss_len + right_ext_len + 1 <= len(tar):
                right_ext_len += 1

            # The following is unnecessary, I think
            # if (search_begin + left_ext_len + min_ss_len + right_ext_len <=
            #         len(tar)):
            search_val = tar[
                search_begin : (
                    search_begin + left_ext_len + min_ss_len + right_ext_len
                )
            ]

            ix += 1

The name ix does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        if hit_len > 0:
            tar = flagged_tar

        match_len += hit_len
        pos += ix