| Conditions | 1 |
| Total Lines | 133 |
| Code Lines | 117 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | # -*- coding: utf-8 -*- |
||
| 96 | def test_modified_nysiis(self): |
||
| 97 | """Test abydos.phonetic.nysiis (modified version).""" |
||
| 98 | self.assertEqual(nysiis('', max_length=-1, modified=True), |
||
| 99 | '') |
||
| 100 | |||
| 101 | # https://naldc.nal.usda.gov/download/27833/PDF |
||
| 102 | # Some of these were... wrong... and have been corrected |
||
| 103 | self.assertEqual(nysiis('Daves', max_length=8, modified=True), 'DAV') |
||
| 104 | self.assertEqual(nysiis('Davies', max_length=8, modified=True), 'DAVY') |
||
| 105 | self.assertEqual(nysiis('Devies', max_length=8, modified=True), 'DAFY') |
||
| 106 | self.assertEqual(nysiis('Divish', max_length=8, modified=True), |
||
| 107 | 'DAVAS') |
||
| 108 | self.assertEqual(nysiis('Dove', max_length=8, modified=True), 'DAV') |
||
| 109 | self.assertEqual(nysiis('Devese', max_length=8, modified=True), |
||
| 110 | 'DAFAS') |
||
| 111 | self.assertEqual(nysiis('Devies', max_length=8, modified=True), 'DAFY') |
||
| 112 | self.assertEqual(nysiis('Devos', max_length=8, modified=True), 'DAF') |
||
| 113 | |||
| 114 | self.assertEqual(nysiis('Schmit', max_length=8, modified=True), 'SNAT') |
||
| 115 | self.assertEqual(nysiis('Schmitt', max_length=8, modified=True), |
||
| 116 | 'SNAT') |
||
| 117 | self.assertEqual(nysiis('Schmitz', max_length=8, modified=True), |
||
| 118 | 'SNAT') |
||
| 119 | self.assertEqual(nysiis('Schmoutz', max_length=8, modified=True), |
||
| 120 | 'SNAT') |
||
| 121 | self.assertEqual(nysiis('Schnitt', max_length=8, modified=True), |
||
| 122 | 'SNAT') |
||
| 123 | self.assertEqual(nysiis('Smit', max_length=8, modified=True), 'SNAT') |
||
| 124 | self.assertEqual(nysiis('Smite', max_length=8, modified=True), 'SNAT') |
||
| 125 | self.assertEqual(nysiis('Smits', max_length=8, modified=True), 'SNAT') |
||
| 126 | self.assertEqual(nysiis('Smoot', max_length=8, modified=True), 'SNAT') |
||
| 127 | self.assertEqual(nysiis('Smuts', max_length=8, modified=True), 'SNAT') |
||
| 128 | self.assertEqual(nysiis('Sneath', max_length=8, modified=True), 'SNAT') |
||
| 129 | self.assertEqual(nysiis('Smyth', max_length=8, modified=True), 'SNAT') |
||
| 130 | self.assertEqual(nysiis('Smithy', max_length=8, modified=True), |
||
| 131 | 'SNATY') |
||
| 132 | self.assertEqual(nysiis('Smithey', max_length=8, modified=True), |
||
| 133 | 'SNATY') |
||
| 134 | |||
| 135 | # http://www.dropby.com/NYSIISTextStrings.html |
||
| 136 | # Some of these have been altered since the above uses a different set |
||
| 137 | # of modifications. |
||
| 138 | self.assertEqual(nysiis('Edwards', max_length=8, modified=True), |
||
| 139 | 'EDWAD') |
||
| 140 | self.assertEqual(nysiis('Perez', max_length=8, modified=True), 'PAR') |
||
| 141 | self.assertEqual(nysiis('Macintosh', max_length=8, modified=True), |
||
| 142 | 'MCANTAS') |
||
| 143 | self.assertEqual(nysiis('Phillipson', max_length=8, modified=True), |
||
| 144 | 'FALAPSAN') |
||
| 145 | self.assertEqual(nysiis('Haddix', max_length=8, modified=True), |
||
| 146 | 'HADAC') |
||
| 147 | self.assertEqual(nysiis('Essex', max_length=8, modified=True), 'ESAC') |
||
| 148 | self.assertEqual(nysiis('Moye', max_length=8, modified=True), 'MY') |
||
| 149 | self.assertEqual(nysiis('McKee', max_length=8, modified=True), 'MCY') |
||
| 150 | self.assertEqual(nysiis('Mackie', max_length=8, modified=True), 'MCY') |
||
| 151 | self.assertEqual(nysiis('Heitschmidt', max_length=8, modified=True), |
||
| 152 | 'HATSNAD') |
||
| 153 | self.assertEqual(nysiis('Bart', max_length=8, modified=True), 'BAD') |
||
| 154 | self.assertEqual(nysiis('Hurd', max_length=8, modified=True), 'HAD') |
||
| 155 | self.assertEqual(nysiis('Hunt', max_length=8, modified=True), 'HAN') |
||
| 156 | self.assertEqual(nysiis('Westerlund', max_length=8, modified=True), |
||
| 157 | 'WASTARLA') |
||
| 158 | self.assertEqual(nysiis('Evers', max_length=8, modified=True), 'EVAR') |
||
| 159 | self.assertEqual(nysiis('Devito', max_length=8, modified=True), |
||
| 160 | 'DAFAT') |
||
| 161 | self.assertEqual(nysiis('Rawson', max_length=8, modified=True), |
||
| 162 | 'RASAN') |
||
| 163 | self.assertEqual(nysiis('Shoulders', max_length=8, modified=True), |
||
| 164 | 'SALDAR') |
||
| 165 | self.assertEqual(nysiis('Leighton', max_length=8, modified=True), |
||
| 166 | 'LATAN') |
||
| 167 | self.assertEqual(nysiis('Wooldridge', max_length=8, modified=True), |
||
| 168 | 'WALDRAG') |
||
| 169 | self.assertEqual(nysiis('Oliphant', max_length=8, modified=True), |
||
| 170 | 'OLAFAN') |
||
| 171 | self.assertEqual(nysiis('Hatchett', max_length=8, modified=True), |
||
| 172 | 'HATCAT') |
||
| 173 | self.assertEqual(nysiis('McKnight', max_length=8, modified=True), |
||
| 174 | 'MCNAT') |
||
| 175 | self.assertEqual(nysiis('Rickert', max_length=8, modified=True), |
||
| 176 | 'RACAD') |
||
| 177 | self.assertEqual(nysiis('Bowman', max_length=8, modified=True), |
||
| 178 | 'BANAN') |
||
| 179 | self.assertEqual(nysiis('Vasquez', max_length=8, modified=True), |
||
| 180 | 'VASG') |
||
| 181 | self.assertEqual(nysiis('Bashaw', max_length=8, modified=True), 'BAS') |
||
| 182 | self.assertEqual(nysiis('Schoenhoeft', max_length=8, modified=True), |
||
| 183 | 'SANAFT') |
||
| 184 | self.assertEqual(nysiis('Heywood', max_length=8, modified=True), 'HAD') |
||
| 185 | self.assertEqual(nysiis('Hayman', max_length=8, modified=True), |
||
| 186 | 'HANAN') |
||
| 187 | self.assertEqual(nysiis('Seawright', max_length=8, modified=True), |
||
| 188 | 'SARAT') |
||
| 189 | self.assertEqual(nysiis('Kratzer', max_length=8, modified=True), |
||
| 190 | 'CRATSAR') |
||
| 191 | self.assertEqual(nysiis('Canaday', max_length=8, modified=True), |
||
| 192 | 'CANADY') |
||
| 193 | self.assertEqual(nysiis('Crepeau', max_length=8, modified=True), |
||
| 194 | 'CRAP') |
||
| 195 | |||
| 196 | # Additional tests from @Yomguithereal's talisman |
||
| 197 | # https://github.com/Yomguithereal/talisman/blob/master/test/phonetics/nysiis.js |
||
| 198 | self.assertEqual(nysiis('Andrew', max_length=8, modified=True), 'ANDR') |
||
| 199 | self.assertEqual(nysiis('Robertson', max_length=8, modified=True), |
||
| 200 | 'RABARTSA') |
||
| 201 | self.assertEqual(nysiis('Nolan', max_length=8, modified=True), 'NALAN') |
||
| 202 | self.assertEqual(nysiis('Louis XVI', max_length=8, modified=True), |
||
| 203 | 'LASXV') |
||
| 204 | self.assertEqual(nysiis('Case', max_length=8, modified=True), 'CAS') |
||
| 205 | self.assertEqual(nysiis('Mclaughlin', max_length=8, modified=True), |
||
| 206 | 'MCLAGLAN') |
||
| 207 | self.assertEqual(nysiis('Awale', max_length=8, modified=True), 'AL') |
||
| 208 | self.assertEqual(nysiis('Aegir', max_length=8, modified=True), 'AGAR') |
||
| 209 | self.assertEqual(nysiis('Lundgren', max_length=8, modified=True), |
||
| 210 | 'LANGRAN') |
||
| 211 | self.assertEqual(nysiis('Philbert', max_length=8, modified=True), |
||
| 212 | 'FALBAD') |
||
| 213 | self.assertEqual(nysiis('Harry', max_length=8, modified=True), 'HARY') |
||
| 214 | self.assertEqual(nysiis('Mackenzie', max_length=8, modified=True), |
||
| 215 | 'MCANSY') |
||
| 216 | |||
| 217 | # max_length bounds tests |
||
| 218 | self.assertEqual(nysiis('Niall', max_length=-1, modified=True), 'NAL') |
||
| 219 | self.assertEqual(nysiis('Niall', max_length=0, modified=True), 'NAL') |
||
| 220 | |||
| 221 | # coverage |
||
| 222 | self.assertEqual(nysiis('Sam Jr.', modified=True), 'ERROR') |
||
| 223 | self.assertEqual(nysiis('John Sr.', modified=True), 'ERROR') |
||
| 224 | self.assertEqual(nysiis('Wright', modified=True), 'RAT') |
||
| 225 | self.assertEqual(nysiis('Rhodes', modified=True), 'RAD') |
||
| 226 | self.assertEqual(nysiis('Dgagoda', modified=True), 'GAGAD') |
||
| 227 | self.assertEqual(nysiis('Bosch', modified=True), 'BAS') |
||
| 228 | self.assertEqual(nysiis('Schrader', modified=True), 'SRADAR') |
||
| 229 | |||
| 233 |