chrislit /
abydos
| Conditions | 29 |
| Total Lines | 172 |
| Code Lines | 101 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 87 |
| CRAP Score | 29 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like abydos.phonetic._SpanishMetaphone.SpanishMetaphone.encode() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | # -*- coding: utf-8 -*- |
||
| 54 | 1 | def encode(self, word, max_length=6, modified=False): |
|
| 55 | """Return the Spanish Metaphone of a word. |
||
| 56 | |||
| 57 | Args: |
||
| 58 | word (str): The word to transform |
||
| 59 | max_length (int): The length of the code returned (defaults to 6) |
||
| 60 | modified (bool): Set to True to use del Pilar Angeles & |
||
| 61 | Bailón-Miguel's modified version of the algorithm |
||
| 62 | |||
| 63 | Returns: |
||
| 64 | str: The Spanish Metaphone code |
||
| 65 | |||
| 66 | Examples: |
||
| 67 | >>> pe = SpanishMetaphone() |
||
| 68 | >>> pe.encode('Perez') |
||
| 69 | 'PRZ' |
||
| 70 | >>> pe.encode('Martinez') |
||
| 71 | 'MRTNZ' |
||
| 72 | >>> pe.encode('Gutierrez') |
||
| 73 | 'GTRRZ' |
||
| 74 | >>> pe.encode('Santiago') |
||
| 75 | 'SNTG' |
||
| 76 | >>> pe.encode('Nicolás') |
||
| 77 | 'NKLS' |
||
| 78 | |||
| 79 | """ |
||
| 80 | |||
| 81 | 1 | def _is_vowel(pos): |
|
| 82 | """Return True if the character at word[pos] is a vowel. |
||
| 83 | |||
| 84 | Args: |
||
| 85 | pos (int): Position to check for a vowel |
||
| 86 | |||
| 87 | Returns: |
||
| 88 | bool: True if word[pos] is a vowel |
||
| 89 | |||
| 90 | """ |
||
| 91 | 1 | return pos < len(word) and word[pos] in {'A', 'E', 'I', 'O', 'U'} |
|
| 92 | |||
| 93 | 1 | word = unicode_normalize('NFC', text_type(word.upper())) |
|
| 94 | |||
| 95 | 1 | meta_key = '' |
|
| 96 | 1 | pos = 0 |
|
| 97 | |||
| 98 | # do some replacements for the modified version |
||
| 99 | 1 | if modified: |
|
| 100 | 1 | word = word.replace('MB', 'NB') |
|
| 101 | 1 | word = word.replace('MP', 'NP') |
|
| 102 | 1 | word = word.replace('BS', 'S') |
|
| 103 | 1 | if word[:2] == 'PS': |
|
| 104 | 1 | word = word[1:] |
|
| 105 | |||
| 106 | # simple replacements |
||
| 107 | 1 | word = word.replace('Á', 'A') |
|
| 108 | 1 | word = word.replace('CH', 'X') |
|
| 109 | 1 | word = word.replace('Ç', 'S') |
|
| 110 | 1 | word = word.replace('É', 'E') |
|
| 111 | 1 | word = word.replace('Í', 'I') |
|
| 112 | 1 | word = word.replace('Ó', 'O') |
|
| 113 | 1 | word = word.replace('Ú', 'U') |
|
| 114 | 1 | word = word.replace('Ñ', 'NY') |
|
| 115 | 1 | word = word.replace('GÜ', 'W') |
|
| 116 | 1 | word = word.replace('Ü', 'U') |
|
| 117 | 1 | word = word.replace('B', 'V') |
|
| 118 | 1 | word = word.replace('LL', 'Y') |
|
| 119 | |||
| 120 | 1 | while len(meta_key) < max_length: |
|
| 121 | 1 | if pos >= len(word): |
|
| 122 | 1 | break |
|
| 123 | |||
| 124 | # get the next character |
||
| 125 | 1 | current_char = word[pos] |
|
| 126 | |||
| 127 | # if a vowel in pos 0, add to key |
||
| 128 | 1 | if _is_vowel(pos) and pos == 0: |
|
| 129 | 1 | meta_key += current_char |
|
| 130 | 1 | pos += 1 |
|
| 131 | # otherwise, do consonant rules |
||
| 132 | else: |
||
| 133 | # simple consonants (unmutated) |
||
| 134 | 1 | if current_char in { |
|
| 135 | 'D', |
||
| 136 | 'F', |
||
| 137 | 'J', |
||
| 138 | 'K', |
||
| 139 | 'M', |
||
| 140 | 'N', |
||
| 141 | 'P', |
||
| 142 | 'T', |
||
| 143 | 'V', |
||
| 144 | 'L', |
||
| 145 | 'Y', |
||
| 146 | }: |
||
| 147 | 1 | meta_key += current_char |
|
| 148 | # skip doubled consonants |
||
| 149 | 1 | if word[pos + 1 : pos + 2] == current_char: |
|
| 150 | 1 | pos += 2 |
|
| 151 | else: |
||
| 152 | 1 | pos += 1 |
|
| 153 | else: |
||
| 154 | 1 | if current_char == 'C': |
|
| 155 | # special case 'acción', 'reacción',etc. |
||
| 156 | 1 | if word[pos + 1 : pos + 2] == 'C': |
|
| 157 | 1 | meta_key += 'X' |
|
| 158 | 1 | pos += 2 |
|
| 159 | # special case 'cesar', 'cien', 'cid', 'conciencia' |
||
| 160 | 1 | elif word[pos + 1 : pos + 2] in {'E', 'I'}: |
|
| 161 | 1 | meta_key += 'Z' |
|
| 162 | 1 | pos += 2 |
|
| 163 | # base case |
||
| 164 | else: |
||
| 165 | 1 | meta_key += 'K' |
|
| 166 | 1 | pos += 1 |
|
| 167 | 1 | elif current_char == 'G': |
|
| 168 | # special case 'gente', 'ecologia',etc |
||
| 169 | 1 | if word[pos + 1 : pos + 2] in {'E', 'I'}: |
|
| 170 | 1 | meta_key += 'J' |
|
| 171 | 1 | pos += 2 |
|
| 172 | # base case |
||
| 173 | else: |
||
| 174 | 1 | meta_key += 'G' |
|
| 175 | 1 | pos += 1 |
|
| 176 | 1 | elif current_char == 'H': |
|
| 177 | # since the letter 'H' is silent in Spanish, |
||
| 178 | # set the meta key to the vowel after the letter 'H' |
||
| 179 | 1 | if _is_vowel(pos + 1): |
|
| 180 | 1 | meta_key += word[pos + 1] |
|
| 181 | 1 | pos += 2 |
|
| 182 | else: |
||
| 183 | 1 | meta_key += 'H' |
|
| 184 | 1 | pos += 1 |
|
| 185 | 1 | elif current_char == 'Q': |
|
| 186 | 1 | if word[pos + 1 : pos + 2] == 'U': |
|
| 187 | 1 | pos += 2 |
|
| 188 | else: |
||
| 189 | 1 | pos += 1 |
|
| 190 | 1 | meta_key += 'K' |
|
| 191 | 1 | elif current_char == 'W': |
|
| 192 | 1 | meta_key += 'U' |
|
| 193 | 1 | pos += 1 |
|
| 194 | 1 | elif current_char == 'R': |
|
| 195 | 1 | meta_key += 'R' |
|
| 196 | 1 | pos += 1 |
|
| 197 | 1 | elif current_char == 'S': |
|
| 198 | 1 | if not _is_vowel(pos + 1) and pos == 0: |
|
| 199 | 1 | meta_key += 'ES' |
|
| 200 | 1 | pos += 1 |
|
| 201 | else: |
||
| 202 | 1 | meta_key += 'S' |
|
| 203 | 1 | pos += 1 |
|
| 204 | 1 | elif current_char == 'Z': |
|
| 205 | 1 | meta_key += 'Z' |
|
| 206 | 1 | pos += 1 |
|
| 207 | 1 | elif current_char == 'X': |
|
| 208 | 1 | if ( |
|
| 209 | len(word) > 1 |
||
| 210 | and pos == 0 |
||
| 211 | and not _is_vowel(pos + 1) |
||
| 212 | ): |
||
| 213 | 1 | meta_key += 'EX' |
|
| 214 | 1 | pos += 1 |
|
| 215 | else: |
||
| 216 | 1 | meta_key += 'X' |
|
| 217 | 1 | pos += 1 |
|
| 218 | else: |
||
| 219 | 1 | pos += 1 |
|
| 220 | |||
| 221 | # Final change from S to Z in modified version |
||
| 222 | 1 | if modified: |
|
| 223 | 1 | meta_key = meta_key.replace('S', 'Z') |
|
| 224 | |||
| 225 | 1 | return meta_key |
|
| 226 | |||
| 262 |
Loading history...
This check looks for invalid names for a range of different identifiers.
You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.
If your project includes a Pylint configuration file, the settings contained in that file take precedence.
To find out more about Pylint, please refer to their site.