Conditions | 32 |
Total Lines | 191 |
Code Lines | 98 |
Lines | 0 |
Ratio | 0 % |
Tests | 80 |
CRAP Score | 32 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like abydos.phonetic._SfinxBis.SfinxBis.encode() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | # -*- coding: utf-8 -*- |
||
154 | 1 | def encode(self, word, max_length=-1): |
|
155 | """Return the SfinxBis code for a word. |
||
156 | |||
157 | Args: |
||
158 | word (str): The word to transform |
||
159 | max_length (int): The length of the code returned (defaults to |
||
160 | unlimited) |
||
161 | |||
162 | Returns: |
||
163 | tuple: The SfinxBis value |
||
164 | |||
165 | Examples: |
||
166 | >>> pe = SfinxBis() |
||
167 | >>> pe.encode('Christopher') |
||
168 | ('K68376',) |
||
169 | >>> pe.encode('Niall') |
||
170 | ('N4',) |
||
171 | >>> pe.encode('Smith') |
||
172 | ('S53',) |
||
173 | >>> pe.encode('Schmidt') |
||
174 | ('S53',) |
||
175 | |||
176 | >>> pe.encode('Johansson') |
||
177 | ('J585',) |
||
178 | >>> pe.encode('Sjöberg') |
||
179 | ('#162',) |
||
180 | |||
181 | """ |
||
182 | |||
183 | 1 | def _foersvensker(lokal_ordet): |
|
184 | """Return the Swedish-ized form of the word. |
||
185 | |||
186 | Args: |
||
187 | lokal_ordet (str): Word to transform |
||
188 | |||
189 | Returns: |
||
190 | str: Transformed word |
||
191 | |||
192 | """ |
||
193 | 1 | lokal_ordet = lokal_ordet.replace('STIERN', 'STJÄRN') |
|
194 | 1 | lokal_ordet = lokal_ordet.replace('HIE', 'HJ') |
|
195 | 1 | lokal_ordet = lokal_ordet.replace('SIÖ', 'SJÖ') |
|
196 | 1 | lokal_ordet = lokal_ordet.replace('SCH', 'SH') |
|
197 | 1 | lokal_ordet = lokal_ordet.replace('QU', 'KV') |
|
198 | 1 | lokal_ordet = lokal_ordet.replace('IO', 'JO') |
|
199 | 1 | lokal_ordet = lokal_ordet.replace('PH', 'F') |
|
200 | |||
201 | 1 | for i in self._harde_vokaler: |
|
202 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Ü', i + 'J') |
|
203 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Y', i + 'J') |
|
204 | 1 | lokal_ordet = lokal_ordet.replace(i + 'I', i + 'J') |
|
205 | 1 | for i in self._mjuka_vokaler: |
|
206 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Ü', i + 'J') |
|
207 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Y', i + 'J') |
|
208 | 1 | lokal_ordet = lokal_ordet.replace(i + 'I', i + 'J') |
|
209 | |||
210 | 1 | if 'H' in lokal_ordet: |
|
211 | 1 | for i in self._uc_c_set: |
|
212 | 1 | lokal_ordet = lokal_ordet.replace('H' + i, i) |
|
213 | |||
214 | 1 | lokal_ordet = lokal_ordet.translate(self._substitutions) |
|
215 | |||
216 | 1 | lokal_ordet = lokal_ordet.replace('Ð', 'ETH') |
|
217 | 1 | lokal_ordet = lokal_ordet.replace('Þ', 'TH') |
|
218 | 1 | lokal_ordet = lokal_ordet.replace('ß', 'SS') |
|
219 | |||
220 | 1 | return lokal_ordet |
|
221 | |||
222 | 1 | def _koda_foersta_ljudet(lokal_ordet): |
|
223 | """Return the word with the first sound coded. |
||
224 | |||
225 | Args: |
||
226 | lokal_ordet (str): Word to transform |
||
227 | |||
228 | Returns: |
||
229 | str: Transformed word |
||
230 | |||
231 | """ |
||
232 | 1 | if ( |
|
233 | lokal_ordet[0:1] in self._mjuka_vokaler |
||
234 | or lokal_ordet[0:1] in self._harde_vokaler |
||
235 | ): |
||
236 | 1 | lokal_ordet = '$' + lokal_ordet[1:] |
|
237 | 1 | elif lokal_ordet[0:2] in ('DJ', 'GJ', 'HJ', 'LJ'): |
|
238 | 1 | lokal_ordet = 'J' + lokal_ordet[2:] |
|
239 | 1 | elif ( |
|
240 | lokal_ordet[0:1] == 'G' |
||
241 | and lokal_ordet[1:2] in self._mjuka_vokaler |
||
242 | ): |
||
243 | 1 | lokal_ordet = 'J' + lokal_ordet[1:] |
|
244 | 1 | elif lokal_ordet[0:1] == 'Q': |
|
245 | 1 | lokal_ordet = 'K' + lokal_ordet[1:] |
|
246 | 1 | elif lokal_ordet[0:2] == 'CH' and lokal_ordet[2:3] in frozenset( |
|
247 | self._mjuka_vokaler | self._harde_vokaler |
||
248 | ): |
||
249 | 1 | lokal_ordet = '#' + lokal_ordet[2:] |
|
250 | 1 | elif ( |
|
251 | lokal_ordet[0:1] == 'C' |
||
252 | and lokal_ordet[1:2] in self._harde_vokaler |
||
253 | ): |
||
254 | 1 | lokal_ordet = 'K' + lokal_ordet[1:] |
|
255 | 1 | elif ( |
|
256 | lokal_ordet[0:1] == 'C' and lokal_ordet[1:2] in self._uc_c_set |
||
257 | ): |
||
258 | 1 | lokal_ordet = 'K' + lokal_ordet[1:] |
|
259 | 1 | elif lokal_ordet[0:1] == 'X': |
|
260 | 1 | lokal_ordet = 'S' + lokal_ordet[1:] |
|
261 | 1 | elif ( |
|
262 | lokal_ordet[0:1] == 'C' |
||
263 | and lokal_ordet[1:2] in self._mjuka_vokaler |
||
264 | ): |
||
265 | 1 | lokal_ordet = 'S' + lokal_ordet[1:] |
|
266 | 1 | elif lokal_ordet[0:3] in ('SKJ', 'STJ', 'SCH'): |
|
267 | 1 | lokal_ordet = '#' + lokal_ordet[3:] |
|
268 | 1 | elif lokal_ordet[0:2] in ('SH', 'KJ', 'TJ', 'SJ'): |
|
269 | 1 | lokal_ordet = '#' + lokal_ordet[2:] |
|
270 | 1 | elif ( |
|
271 | lokal_ordet[0:2] == 'SK' |
||
272 | and lokal_ordet[2:3] in self._mjuka_vokaler |
||
273 | ): |
||
274 | 1 | lokal_ordet = '#' + lokal_ordet[2:] |
|
275 | 1 | elif ( |
|
276 | lokal_ordet[0:1] == 'K' |
||
277 | and lokal_ordet[1:2] in self._mjuka_vokaler |
||
278 | ): |
||
279 | 1 | lokal_ordet = '#' + lokal_ordet[1:] |
|
280 | 1 | return lokal_ordet |
|
281 | |||
282 | # Steg 1, Versaler |
||
283 | 1 | word = unicode_normalize('NFC', text_type(word.upper())) |
|
284 | 1 | word = word.replace('ß', 'SS') |
|
285 | 1 | word = word.replace('-', ' ') |
|
286 | |||
287 | # Steg 2, Ta bort adelsprefix |
||
288 | 1 | for adelstitel in self._adelstitler: |
|
289 | 1 | while adelstitel in word: |
|
290 | 1 | word = word.replace(adelstitel, ' ') |
|
291 | 1 | if word.startswith(adelstitel[1:]): |
|
292 | 1 | word = word[len(adelstitel) - 1 :] |
|
293 | |||
294 | # Split word into tokens |
||
295 | 1 | ordlista = word.split() |
|
296 | |||
297 | # Steg 3, Ta bort dubbelteckning i början på namnet |
||
298 | 1 | ordlista = [ |
|
299 | self._delete_consecutive_repeats(ordet) for ordet in ordlista |
||
300 | ] |
||
301 | 1 | if not ordlista: |
|
302 | # noinspection PyRedundantParentheses |
||
303 | 1 | return ('',) |
|
304 | |||
305 | # Steg 4, Försvenskning |
||
306 | 1 | ordlista = [_foersvensker(ordet) for ordet in ordlista] |
|
307 | |||
308 | # Steg 5, Ta bort alla tecken som inte är A-Ö (65-90,196,197,214) |
||
309 | 1 | ordlista = [ |
|
310 | ''.join(c for c in ordet if c in self._uc_set) |
||
311 | for ordet in ordlista |
||
312 | ] |
||
313 | |||
314 | # Steg 6, Koda första ljudet |
||
315 | 1 | ordlista = [_koda_foersta_ljudet(ordet) for ordet in ordlista] |
|
316 | |||
317 | # Steg 7, Dela upp namnet i två delar |
||
318 | 1 | rest = [ordet[1:] for ordet in ordlista] |
|
319 | |||
320 | # Steg 8, Utför fonetisk transformation i resten |
||
321 | 1 | rest = [ordet.replace('DT', 'T') for ordet in rest] |
|
322 | 1 | rest = [ordet.replace('X', 'KS') for ordet in rest] |
|
323 | |||
324 | # Steg 9, Koda resten till en sifferkod |
||
325 | 1 | for vokal in self._mjuka_vokaler: |
|
326 | 1 | rest = [ordet.replace('C' + vokal, '8' + vokal) for ordet in rest] |
|
327 | 1 | rest = [ordet.translate(self._trans) for ordet in rest] |
|
328 | |||
329 | # Steg 10, Ta bort intilliggande dubbletter |
||
330 | 1 | rest = [self._delete_consecutive_repeats(ordet) for ordet in rest] |
|
331 | |||
332 | # Steg 11, Ta bort alla "9" |
||
333 | 1 | rest = [ordet.replace('9', '') for ordet in rest] |
|
334 | |||
335 | # Steg 12, Sätt ihop delarna igen |
||
336 | 1 | ordlista = [ |
|
337 | ''.join(ordet) for ordet in zip((_[0:1] for _ in ordlista), rest) |
||
338 | ] |
||
339 | |||
340 | # truncate, if max_length is set |
||
341 | 1 | if max_length > 0: |
|
342 | 1 | ordlista = [ordet[:max_length] for ordet in ordlista] |
|
343 | |||
344 | 1 | return tuple(ordlista) |
|
345 | |||
383 |
This check looks for invalid names for a range of different identifiers.
You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements.
If your project includes a Pylint configuration file, the settings contained in that file take precedence.
To find out more about Pylint, please refer to their site.