Conditions | 32 |
Total Lines | 171 |
Code Lines | 98 |
Lines | 0 |
Ratio | 0 % |
Tests | 80 |
CRAP Score | 32 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like abydos.phonetic._sv.SfinxBis.encode() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | # -*- coding: utf-8 -*- |
||
153 | 1 | def encode(self, word, max_length=-1): |
|
154 | """Return the SfinxBis code for a word. |
||
155 | |||
156 | :param str word: the word to transform |
||
157 | :param int max_length: the length of the code returned (defaults to |
||
158 | unlimited) |
||
159 | :returns: the SfinxBis value |
||
160 | :rtype: tuple |
||
161 | |||
162 | >>> pe = SfinxBis() |
||
163 | >>> pe.encode('Christopher') |
||
164 | ('K68376',) |
||
165 | >>> pe.encode('Niall') |
||
166 | ('N4',) |
||
167 | >>> pe.encode('Smith') |
||
168 | ('S53',) |
||
169 | >>> pe.encode('Schmidt') |
||
170 | ('S53',) |
||
171 | |||
172 | >>> pe.encode('Johansson') |
||
173 | ('J585',) |
||
174 | >>> pe.encode('Sjöberg') |
||
175 | ('#162',) |
||
176 | """ |
||
177 | |||
178 | 1 | def _foersvensker(lokal_ordet): |
|
179 | """Return the Swedish-ized form of the word.""" |
||
180 | 1 | lokal_ordet = lokal_ordet.replace('STIERN', 'STJÄRN') |
|
181 | 1 | lokal_ordet = lokal_ordet.replace('HIE', 'HJ') |
|
182 | 1 | lokal_ordet = lokal_ordet.replace('SIÖ', 'SJÖ') |
|
183 | 1 | lokal_ordet = lokal_ordet.replace('SCH', 'SH') |
|
184 | 1 | lokal_ordet = lokal_ordet.replace('QU', 'KV') |
|
185 | 1 | lokal_ordet = lokal_ordet.replace('IO', 'JO') |
|
186 | 1 | lokal_ordet = lokal_ordet.replace('PH', 'F') |
|
187 | |||
188 | 1 | for i in self._harde_vokaler: |
|
189 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Ü', i + 'J') |
|
190 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Y', i + 'J') |
|
191 | 1 | lokal_ordet = lokal_ordet.replace(i + 'I', i + 'J') |
|
192 | 1 | for i in self._mjuka_vokaler: |
|
193 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Ü', i + 'J') |
|
194 | 1 | lokal_ordet = lokal_ordet.replace(i + 'Y', i + 'J') |
|
195 | 1 | lokal_ordet = lokal_ordet.replace(i + 'I', i + 'J') |
|
196 | |||
197 | 1 | if 'H' in lokal_ordet: |
|
198 | 1 | for i in self._uc_c_set: |
|
199 | 1 | lokal_ordet = lokal_ordet.replace('H' + i, i) |
|
200 | |||
201 | 1 | lokal_ordet = lokal_ordet.translate(self._substitutions) |
|
202 | |||
203 | 1 | lokal_ordet = lokal_ordet.replace('Ð', 'ETH') |
|
204 | 1 | lokal_ordet = lokal_ordet.replace('Þ', 'TH') |
|
205 | 1 | lokal_ordet = lokal_ordet.replace('ß', 'SS') |
|
206 | |||
207 | 1 | return lokal_ordet |
|
208 | |||
209 | 1 | def _koda_foersta_ljudet(lokal_ordet): |
|
210 | """Return the word with the first sound coded.""" |
||
211 | 1 | if ( |
|
212 | lokal_ordet[0:1] in self._mjuka_vokaler |
||
213 | or lokal_ordet[0:1] in self._harde_vokaler |
||
214 | ): |
||
215 | 1 | lokal_ordet = '$' + lokal_ordet[1:] |
|
216 | 1 | elif lokal_ordet[0:2] in ('DJ', 'GJ', 'HJ', 'LJ'): |
|
217 | 1 | lokal_ordet = 'J' + lokal_ordet[2:] |
|
218 | 1 | elif ( |
|
219 | lokal_ordet[0:1] == 'G' |
||
220 | and lokal_ordet[1:2] in self._mjuka_vokaler |
||
221 | ): |
||
222 | 1 | lokal_ordet = 'J' + lokal_ordet[1:] |
|
223 | 1 | elif lokal_ordet[0:1] == 'Q': |
|
224 | 1 | lokal_ordet = 'K' + lokal_ordet[1:] |
|
225 | 1 | elif lokal_ordet[0:2] == 'CH' and lokal_ordet[2:3] in frozenset( |
|
226 | self._mjuka_vokaler | self._harde_vokaler |
||
227 | ): |
||
228 | 1 | lokal_ordet = '#' + lokal_ordet[2:] |
|
229 | 1 | elif ( |
|
230 | lokal_ordet[0:1] == 'C' |
||
231 | and lokal_ordet[1:2] in self._harde_vokaler |
||
232 | ): |
||
233 | 1 | lokal_ordet = 'K' + lokal_ordet[1:] |
|
234 | 1 | elif ( |
|
235 | lokal_ordet[0:1] == 'C' and lokal_ordet[1:2] in self._uc_c_set |
||
236 | ): |
||
237 | 1 | lokal_ordet = 'K' + lokal_ordet[1:] |
|
238 | 1 | elif lokal_ordet[0:1] == 'X': |
|
239 | 1 | lokal_ordet = 'S' + lokal_ordet[1:] |
|
240 | 1 | elif ( |
|
241 | lokal_ordet[0:1] == 'C' |
||
242 | and lokal_ordet[1:2] in self._mjuka_vokaler |
||
243 | ): |
||
244 | 1 | lokal_ordet = 'S' + lokal_ordet[1:] |
|
245 | 1 | elif lokal_ordet[0:3] in ('SKJ', 'STJ', 'SCH'): |
|
246 | 1 | lokal_ordet = '#' + lokal_ordet[3:] |
|
247 | 1 | elif lokal_ordet[0:2] in ('SH', 'KJ', 'TJ', 'SJ'): |
|
248 | 1 | lokal_ordet = '#' + lokal_ordet[2:] |
|
249 | 1 | elif ( |
|
250 | lokal_ordet[0:2] == 'SK' |
||
251 | and lokal_ordet[2:3] in self._mjuka_vokaler |
||
252 | ): |
||
253 | 1 | lokal_ordet = '#' + lokal_ordet[2:] |
|
254 | 1 | elif ( |
|
255 | lokal_ordet[0:1] == 'K' |
||
256 | and lokal_ordet[1:2] in self._mjuka_vokaler |
||
257 | ): |
||
258 | 1 | lokal_ordet = '#' + lokal_ordet[1:] |
|
259 | 1 | return lokal_ordet |
|
260 | |||
261 | # Steg 1, Versaler |
||
262 | 1 | word = unicode_normalize('NFC', text_type(word.upper())) |
|
263 | 1 | word = word.replace('ß', 'SS') |
|
264 | 1 | word = word.replace('-', ' ') |
|
265 | |||
266 | # Steg 2, Ta bort adelsprefix |
||
267 | 1 | for adelstitel in self._adelstitler: |
|
268 | 1 | while adelstitel in word: |
|
269 | 1 | word = word.replace(adelstitel, ' ') |
|
270 | 1 | if word.startswith(adelstitel[1:]): |
|
271 | 1 | word = word[len(adelstitel) - 1 :] |
|
272 | |||
273 | # Split word into tokens |
||
274 | 1 | ordlista = word.split() |
|
275 | |||
276 | # Steg 3, Ta bort dubbelteckning i början på namnet |
||
277 | 1 | ordlista = [ |
|
278 | self._delete_consecutive_repeats(ordet) for ordet in ordlista |
||
279 | ] |
||
280 | 1 | if not ordlista: |
|
281 | # noinspection PyRedundantParentheses |
||
282 | 1 | return ('',) |
|
283 | |||
284 | # Steg 4, Försvenskning |
||
285 | 1 | ordlista = [_foersvensker(ordet) for ordet in ordlista] |
|
286 | |||
287 | # Steg 5, Ta bort alla tecken som inte är A-Ö (65-90,196,197,214) |
||
288 | 1 | ordlista = [ |
|
289 | ''.join(c for c in ordet if c in self._uc_set) |
||
290 | for ordet in ordlista |
||
291 | ] |
||
292 | |||
293 | # Steg 6, Koda första ljudet |
||
294 | 1 | ordlista = [_koda_foersta_ljudet(ordet) for ordet in ordlista] |
|
295 | |||
296 | # Steg 7, Dela upp namnet i två delar |
||
297 | 1 | rest = [ordet[1:] for ordet in ordlista] |
|
298 | |||
299 | # Steg 8, Utför fonetisk transformation i resten |
||
300 | 1 | rest = [ordet.replace('DT', 'T') for ordet in rest] |
|
301 | 1 | rest = [ordet.replace('X', 'KS') for ordet in rest] |
|
302 | |||
303 | # Steg 9, Koda resten till en sifferkod |
||
304 | 1 | for vokal in self._mjuka_vokaler: |
|
305 | 1 | rest = [ordet.replace('C' + vokal, '8' + vokal) for ordet in rest] |
|
306 | 1 | rest = [ordet.translate(self._trans) for ordet in rest] |
|
307 | |||
308 | # Steg 10, Ta bort intilliggande dubbletter |
||
309 | 1 | rest = [self._delete_consecutive_repeats(ordet) for ordet in rest] |
|
310 | |||
311 | # Steg 11, Ta bort alla "9" |
||
312 | 1 | rest = [ordet.replace('9', '') for ordet in rest] |
|
313 | |||
314 | # Steg 12, Sätt ihop delarna igen |
||
315 | 1 | ordlista = [ |
|
316 | ''.join(ordet) for ordet in zip((_[0:1] for _ in ordlista), rest) |
||
317 | ] |
||
318 | |||
319 | # truncate, if max_length is set |
||
320 | 1 | if max_length > 0: |
|
321 | 1 | ordlista = [ordet[:max_length] for ordet in ordlista] |
|
322 | |||
323 | 1 | return tuple(ordlista) |
|
324 | |||
493 |