Issues in HasStatus.php (master) - Issues in master - chrisjk123/laravel-projects - Measure and Improve Code Quality continuously with Scrutinizer

Issues (29)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Traits/HasStatus.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Chriscreates\Projects\Traits;

use Chriscreates\Projects\Models\Status;
use Illuminate\Database\Eloquent\Builder;

trait HasStatus
{
    /**
     * Check the status of the given model.
     *
     * @param  string|int|\Chriscreates\Projects\Models\Status $status
     * @return bool
     */
    public function hasStatus($status) : bool
    {
        if (is_null($this->status)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return false;
        }

        if (is_int($status) || is_string($status)) {
            $status = Status::findByIdOrName($status);
        }

        if (is_null($status)) {
            return false;
        }

        if ($status instanceof Status) {
            $status = $status->id;
        }

        return $this->status_id === $status;

    }

    /**
     * Check if the given model has any status.
     *
     * @param  array                  $statuses
     * @return boolean
     */
    public function hasAnyStatus(array $statuses) : bool
    {
        return ! collect($statuses)->reject(function ($status, $key) {

            return ! $this->hasStatus($status);
        })->isEmpty();
    }

    /**
     * Set the status of the given model.
     *
     * @param  void                  $status
     */
    public function setStatus($status) : void
    {
        if (is_int($status) || is_string($status)) {
            $status = Status::findByIdOrName($status);
        }

        if (is_null($status)) {
            return;
        }

        $this->status()->save($status);

    }

    /**
     * Scope - return any model where status.
     *
     * @param  \Illuminate\Database\Eloquent\Builder $query
     * @param  string|int|\Chriscreates\Projects\Models\Status $status
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeWhereHasStatus(Builder $query, $status)
    {
        $key = ! is_string($status) ? 'id' : 'name';

        $status = $status instanceof Status ? $status->id : $status;

        return $query->whereHas('status', function ($query) use ($key, $status) {
            return $query->where($key, $status);
        });
    }

    /**
     * Scope - return any model whereIn statuses.
     *
     * @param  \Illuminate\Database\Eloquent\Builder $query
     * @param  string                  $key
     * @param  array                   $statuses
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeWhereHasAnyStatus(Builder $query, string $key, array $statuses)
    {
        return $query->whereHas('status', function ($query) use ($key, $statuses) {
            return $query->whereIn($key, $statuses);
        });
    }
}


1		<?php
2
3		namespace Chriscreates\Projects\Traits;
4
5		use Chriscreates\Projects\Models\Status;
6		use Illuminate\Database\Eloquent\Builder;
7
8	View Code Duplication	trait HasStatus
9		{
10		/**
11		* Check the status of the given model.
12		*
13		* @param string\|int\|\Chriscreates\Projects\Models\Status $status
14		* @return bool
15		*/
16		public function hasStatus($status) : bool
17		{
18		if (is_null($this->status)) {
		0 ignored issues – show Bug introduced 2020-04-06 14:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `status` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19		return false;
20		}
21
22		if (is_int($status) \|\| is_string($status)) {
23		$status = Status::findByIdOrName($status);
24		}
25
26		if (is_null($status)) {
27		return false;
28		}
29
30		if ($status instanceof Status) {
31		$status = $status->id;
32		}
33
34		return $this->status_id === $status;
		0 ignored issues – show Bug introduced 2020-04-06 14:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `status_id` does not seem to exist. Did you mean `status`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
35		}
36
37		/**
38		* Check if the given model has any status.
39		*
40		* @param array $statuses
41		* @return boolean
42		*/
43		public function hasAnyStatus(array $statuses) : bool
44		{
45		return ! collect($statuses)->reject(function ($status, $key) {
		0 ignored issues – show Unused Code introduced 2020-04-06 14:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
46		return ! $this->hasStatus($status);
47		})->isEmpty();
48		}
49
50		/**
51		* Set the status of the given model.
52		*
53		* @param void $status
54		*/
55		public function setStatus($status) : void
56		{
57		if (is_int($status) \|\| is_string($status)) {
58		$status = Status::findByIdOrName($status);
59		}
60
61		if (is_null($status)) {
62		return;
63		}
64
65		$this->status()->save($status);
		0 ignored issues – show Bug introduced 2020-04-06 14:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `status()` does not exist on `Chriscreates\Projects\Traits\HasStatus`. Did you maybe mean `hasStatus()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
66		}
67
68		/**
69		* Scope - return any model where status.
70		*
71		* @param \Illuminate\Database\Eloquent\Builder $query
72		* @param string\|int\|\Chriscreates\Projects\Models\Status $status
73		* @return \Illuminate\Database\Eloquent\Builder
74		*/
75		public function scopeWhereHasStatus(Builder $query, $status)
76		{
77		$key = ! is_string($status) ? 'id' : 'name';
78
79		$status = $status instanceof Status ? $status->id : $status;
80
81		return $query->whereHas('status', function ($query) use ($key, $status) {
82		return $query->where($key, $status);
83		});
84		}
85
86		/**
87		* Scope - return any model whereIn statuses.
88		*
89		* @param \Illuminate\Database\Eloquent\Builder $query
90		* @param string $key
91		* @param array $statuses
92		* @return \Illuminate\Database\Eloquent\Builder
93		*/
94		public function scopeWhereHasAnyStatus(Builder $query, string $key, array $statuses)
95		{
96		return $query->whereHas('status', function ($query) use ($key, $statuses) {
97		return $query->whereIn($key, $statuses);
98		});
99		}
100		}
101

chrisjk123 / laravel-projects

Issues (29)

Security Analysis not enabled

src/Traits/HasStatus.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like