CategoryController::create() - Code Metrics - Inspection of "WIP: Controllers and publishing of assets" - chrisjk123/laravel-blogger - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f8f8d3...65f853 )

by Christopher

created 2020-01-18 20:59 UTC

CategoryController::create() A

↳ Parent: CategoryController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Chriscreates\Blog\Controllers;

use Chriscreates\Blog\Category;
use Chriscreates\Blog\Requests\ValidateCategoryRequest;
use Illuminate\Http\Request;

class CategoryController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Chriscreates\Blog\Requests\ValidateCategoryRequest  $request
     * @return \Illuminate\Http\Response
     */
    public function store(ValidateCategoryRequest $request)
    {
        $category = Category::create($request->only([
            'name',
            'slug',
            'parent_id',
        ]));

        return response()->json($category);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Display the specified resource.
     *
     * @param  \Chriscreates\Blog\Category  $category
     * @return \Illuminate\Http\Response
     */
    public function show(Category $category)

    {
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \Chriscreates\Blog\Category  $category
     * @return \Illuminate\Http\Response
     */
    public function edit(Category $category)

    {
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Chriscreates\Blog\Requests\ValidateCategoryRequest  $request
     * @return \Illuminate\Http\Response
     */
    public function update(ValidateCategoryRequest $request, Category $category)

    {
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \Chriscreates\Blog\Category  $category
     * @return \Illuminate\Http\Response
     */
    public function destroy(Category $category)

    {
    }
}


1			<?php
2
3			namespace Chriscreates\Blog\Controllers;
4
5			use Chriscreates\Blog\Category;
6			use Chriscreates\Blog\Requests\ValidateCategoryRequest;
7			use Illuminate\Http\Request;
8
9			class CategoryController extends Controller
10			{
11			/**
12			* Display a listing of the resource.
13			*
14			* @return \Illuminate\Http\Response
15			*/
16			public function index()
17			{
18			}
19
20			/**
21			* Show the form for creating a new resource.
22			*
23			* @return \Illuminate\Http\Response
24			*/
25			public function create()
26			{
27			}
28
29			/**
30			* Store a newly created resource in storage.
31			*
32			* @param \Chriscreates\Blog\Requests\ValidateCategoryRequest $request
33			* @return \Illuminate\Http\Response
34			*/
35			public function store(ValidateCategoryRequest $request)
36			{
37			$category = Category::create($request->only([
38			'name',
39			'slug',
40			'parent_id',
41			]));
42
43			return response()->json($category);
			0 ignored issues – show Bug introduced 2020-01-18 21:00 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44			}
45
46			/**
47			* Display the specified resource.
48			*
49			* @param \Chriscreates\Blog\Category $category
50			* @return \Illuminate\Http\Response
51			*/
52			public function show(Category $category)
			0 ignored issues – show Unused Code introduced 2020-01-18 21:00 UTC by Report Bug Copy Issue Report The parameter `$category` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
53			{
54			}
55
56			/**
57			* Show the form for editing the specified resource.
58			*
59			* @param \Chriscreates\Blog\Category $category
60			* @return \Illuminate\Http\Response
61			*/
62			public function edit(Category $category)
			0 ignored issues – show Unused Code introduced 2020-01-18 18:39 UTC by Report Bug Copy Issue Report The parameter `$category` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
63			{
64			}
65
66			/**
67			* Update the specified resource in storage.
68			*
69			* @param \Illuminate\Http\Request $request
70			* @param \Chriscreates\Blog\Requests\ValidateCategoryRequest $request
71			* @return \Illuminate\Http\Response
72			*/
73			public function update(ValidateCategoryRequest $request, Category $category)
			0 ignored issues – show Unused Code introduced 2020-01-18 21:00 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2020-01-18 21:00 UTC by Report Bug Copy Issue Report The parameter `$category` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
74			{
75			}
76
77			/**
78			* Remove the specified resource from storage.
79			*
80			* @param \Chriscreates\Blog\Category $category
81			* @return \Illuminate\Http\Response
82			*/
83			public function destroy(Category $category)
			0 ignored issues – show Unused Code introduced 2020-01-18 21:00 UTC by Report Bug Copy Issue Report The parameter `$category` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
84			{
85			}
86			}
87

chrisjk123 / laravel-blogger

Push — master ( f8f8d3...65f853 )

CategoryController::create() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like