Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class SetupCommand extends Command |
||
| 12 | { |
||
| 13 | use DetectsApplicationNamespace; |
||
| 14 | |||
| 15 | /** |
||
| 16 | * The name and signature of the console command. |
||
| 17 | * |
||
| 18 | * @var string |
||
| 19 | */ |
||
| 20 | protected $signature = 'blog:setup {--data : Specifies that demo data should be seeded}'; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * The console command description. |
||
| 24 | * |
||
| 25 | * @var string |
||
| 26 | */ |
||
| 27 | protected $description = 'Scaffold basic blog views and routes'; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * Execute the console command. |
||
| 31 | * |
||
| 32 | * @return void |
||
| 33 | */ |
||
| 34 | public function handle() |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Run the demo data seeder. |
||
| 51 | * |
||
| 52 | * @return void |
||
| 53 | */ |
||
| 54 | private function seed() |
||
| 78 | } |
||
| 79 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.