Curl::get() - Code Metrics - chrisaugustsson/weatherService - Measure and Improve Code Quality continuously with Scrutinizer

Curl::get() A
last analyzed 2019-01-09 14:54 UTC

↳ Parent: Curl

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.7938

Importance

Changes

Metric	Value
cc	2
eloc	11
nc	2
nop	1
dl	0
loc	19
ccs	5
cts	12
cp	0.4167
crap	2.7938
rs	9.9
c	0
b	0
f	0

<?php

namespace Anax\Curl;

class Curl
{
    private $cache;

    public function __construct($cache)
    {
        $this->cache = $cache;
    }


    public function get(string $url)
    {
        $cache = $this->cache;

        $cleanUrl = preg_replace('/[^A-Za-z0-9\-]/', '', $url);

        if ($cache->get($cleanUrl)) {
            return json_decode($cache->get($cleanUrl));
        }

        $ch = curl_init();
        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
        $res = curl_exec($ch);
        curl_close($ch);

        $cache->set($cleanUrl, $res);

        return json_decode($res);
    }

    public function getMulti(array $urls)
    {
        $res = [];
        $mh = curl_multi_init();

        foreach ($urls as $key => $value) {
            $multiCurl[$key] = curl_init();
            curl_setopt($multiCurl[$key], CURLOPT_URL, $urls[$key]);

            curl_setopt($multiCurl[$key], CURLOPT_RETURNTRANSFER, 1);
            curl_multi_add_handle($mh, $multiCurl[$key]);
        }

        $index = null;
        do {
            curl_multi_exec($mh, $index);
        } while ($index > 0);

        foreach ($multiCurl as $k => $ch) {
            $res[$k] = json_decode(curl_multi_getcontent($ch));
            curl_multi_remove_handle($mh, $ch);
        }

        curl_multi_close($mh);

        return $res;
    }
}


1		<?php
2
3		namespace Anax\Curl;
4
5		class Curl
6		{
7		private $cache;
8
9	1	public function __construct($cache)
10		{
11	1	$this->cache = $cache;
12	1	}
13
14
15	1	public function get(string $url)
16		{
17	1	$cache = $this->cache;
18
19	1	$cleanUrl = preg_replace('/[^A-Za-z0-9\-]/', '', $url);
20
21	1	if ($cache->get($cleanUrl)) {
22	1	return json_decode($cache->get($cleanUrl));
23		}
24
25		$ch = curl_init();
26		curl_setopt($ch, CURLOPT_URL, $url);
27		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
28		$res = curl_exec($ch);
29		curl_close($ch);
30
31		$cache->set($cleanUrl, $res);
32
33		return json_decode($res);
34		}
35
36		public function getMulti(array $urls)
37		{
38		$res = [];
39		$mh = curl_multi_init();
40
41		foreach ($urls as $key => $value) {
42		$multiCurl[$key] = curl_init();
43		curl_setopt($multiCurl[$key], CURLOPT_URL, $urls[$key]);
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-12-06 16:18 UTC by Report Bug Copy Issue Report The variable `$multiCurl` seems to be defined later in this `foreach` loop on line `42`. Are you sure it is defined here? Loading history...
44		curl_setopt($multiCurl[$key], CURLOPT_RETURNTRANSFER, 1);
45		curl_multi_add_handle($mh, $multiCurl[$key]);
46		}
47
48		$index = null;
49		do {
50		curl_multi_exec($mh, $index);
51		} while ($index > 0);
52
53		foreach ($multiCurl as $k => $ch) {
54		$res[$k] = json_decode(curl_multi_getcontent($ch));
55		curl_multi_remove_handle($mh, $ch);
56		}
57
58		curl_multi_close($mh);
59
60		return $res;
61		}
62		}
63

chrisaugustsson / weatherService

Curl::get() A last analyzed 2019-01-09 14:54 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Curl::get() A
last analyzed 2019-01-09 14:54 UTC