BookController::showAction() - Code Metrics - Inspection of "Add support for MOBI and PDF" - chitanka/chitanka - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( c13757...19c3c0 )

by Borislav
created 2021-10-19 12:52 UTC
BookController::showAction() D

↳ Parent: BookController
Complexity

Conditions	21
Paths	20
Size

Total Lines	58
Code Lines	50
Duplication

Lines	0
Ratio	0 %
Importance

Changes	2
Bugs	0	Features	0
Metric	Value
cc	21
eloc	50
c	2
b	0
f	0
nc	20
nop	3
dl	0
loc	58
rs	4.1666
How to fix Long Method Complexity

<?php namespace App\Controller;

use App\Entity\BaseWork;
use App\Entity\Book;
use App\Generator\DownloadFile;
use App\Generator\DownloadUrlGenerator;
use App\Legacy\Setup;
use App\Pagination\Pager;
use App\Service\ContentService;
use App\Service\SearchService;
use App\Util\Stringy;
use Doctrine\ORM\NoResultException;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;

/**
 * @Route("/books")
 */
class BookController extends Controller {

	const PAGE_COUNT_DEFAULT = 30;
	const PAGE_COUNT_LIMIT = 300;

	public function indexAction($_format) {
		if (in_array($_format, ['html', 'json'])) {
			return [
				'categories' => $this->em()->getCategoryRepository()->getAllAsTree(),
			];
		}
		return [];
	}

	public function listByCategoryIndexAction($_format) {
		switch ($_format) {
			case 'html':
			case 'opds':
				return [
					'categories' => $this->em()->getCategoryRepository()->getAll(),
				];
		}
	}

	public function listByAlphaIndexAction() {
		return [];
	}

	public function listByCategoryAction(Request $request, $slug, $page) {
		$slug = Stringy::slugify($slug);
		$bookRepo = $this->em()->getBookRepository();
		$categoryRepo = $this->em()->getCategoryRepository();
		$category = $categoryRepo->findBySlug($slug);
		if ($category === null) {
			throw $this->createNotFoundException("Няма категория с код $slug.");
		}
		$limit = min($request->query->get('limit', static::PAGE_COUNT_DEFAULT), static::PAGE_COUNT_LIMIT);
		return [
			'category' => $category,
			'parents' => array_reverse($categoryRepo->findCategoryAncestors($category)),
			'books' => $bookRepo->findByCategory($categoryRepo->getCategoryDescendantIdsWithSelf($category), $page, $limit),
			'pager' => new Pager($page, $category->getNrOfBooks(), $limit),
			'route_params' => ['slug' => $slug],
		];
	}

	public function listByAlphaAction(Request $request, $letter, $page) {
		$bookRepo = $this->em()->getBookRepository();
		$limit = min($request->query->get('limit', static::PAGE_COUNT_DEFAULT), static::PAGE_COUNT_LIMIT);
		$prefix = $letter == '-' ? null : $letter;
		return [
			'letter' => $letter,
			'books' => $bookRepo->findByPrefix($prefix, $page, $limit),
			'pager'    => new Pager($page, $bookRepo->countByPrefix($prefix), $limit),
			'route_params' => ['letter' => $letter],
		];
	}

	public function listWoCoverAction(Request $request, $page) {
		$limit = min($request->query->get('limit', static::PAGE_COUNT_DEFAULT), static::PAGE_COUNT_LIMIT);
		$bookRepo = $this->em()->getBookRepository();
		return [
			'books' => $bookRepo->findWithMissingCover($page, $limit),
			'pager' => new Pager($page, $bookRepo->getCountWithMissingCover(), $limit),
		];
	}

	/**
	 * @Route("/wo-biblioman/{page}.{_format}", name="books_wo_biblioman", defaults={"page": 1, "_format": "html"})
	 */
	public function listWoBibliomanAction(Request $request, $page) {
		$limit = min($request->query->get('limit', static::PAGE_COUNT_DEFAULT), static::PAGE_COUNT_LIMIT);
		$bookRepo = $this->em()->getBookRepository();
		return [
			'books' => $bookRepo->findWithMissingBibliomanId($page, $limit),
			'pager' => new Pager($page, $bookRepo->getCountWithMissingBibliomanId(), $limit),
		];
	}

	public function listByIsbnAction($isbn) {
		$books = $this->em()->getBookRepository()->findByIsbn($isbn);
		if (count($books) == 1) {
			return $this->redirectToRoute('book_show', ['id' => $books[0]->getId()]);
		}
		return [
			'isbn' => $isbn,
			'books' => $books,
		];
	}

	public function showAction(Request $request, $id, $_format) {
		list($id) = explode('-', $id); // remove optional slug
		try {
			$book = $this->em()->getBookRepository()->get($id);
			$book = $this->em()->getBookRepository()->get(/** @scrutinizer ignore-type */ $id);
		} catch (NoResultException $e) {
			throw $this->createNotFoundException("Няма книга с номер $id.");
		}

		switch ($_format) {
			case 'sfb.zip':
			case 'txt.zip':
			case 'fb2.zip':
			case 'epub':
				Setup::doSetup($this->container);
				return $this->urlRedirect($this->processDownload($book, $_format));
			case 'djvu':
				return $this->urlRedirect($this->processDownload($book, $_format));
			case 'pdf':
				if ($book->hasCustomPdf()) {
					return $this->urlRedirect($this->processDownload($book, $_format));
				}
				if ( ! $this->container->getParameter('pdf_download_enabled')) {
					throw $this->createNotFoundException("Няма поддръжка на формата PDF.");
				}
				return $this->urlRedirect($this->generateConverterUrl($this->container->getParameter('pdf_converter_url'), $book));
			case 'mobi':
				if ( ! $this->container->getParameter('mobi_download_enabled')) {
					throw $this->createNotFoundException("Няма поддръжка на формата MOBI.");
				}
				return $this->urlRedirect($this->generateConverterUrl($this->container->getParameter('mobi_converter_url'), $book));
			case 'txt':
				Setup::doSetup($this->container);
				return $this->asText($book->getContentAsTxt());
			case 'fb2':
				Setup::doSetup($this->container);
				return $this->asText($book->getContentAsFb2(), 'application/xml');
			case 'sfb':
				Setup::doSetup($this->container);
				return $this->asText($book->getContentAsSfb());
			case 'data':
				return $this->asText($book->getDataAsPlain());
			case 'opds':
				break;
			case 'pic':
				Setup::doSetup($this->container);
				break;
			case 'cover':
				return $this->urlRedirect('/'.ContentService::getCover($book->hasCover() ? $book->getId() : 0, $request->get('size', 300)));
			case 'html':
			default:
		}

		return [
			'book' => $book,
			'authors' => $book->getAuthors(),
			'template' => $book->getTemplateAsXhtml(),
			'info' => $book->getExtraInfoAsXhtml(),
			'js_extra' => ['book'],
		];
	}

	public function searchAction(Request $request, $_format) {
		if ($_format == 'osd') {
			return [];
		}
		if ($_format == 'suggest') {
			$query = $request->query->get('q');
			$books = $this->findByQuery([
				'text'  => $query,
				'by'    => 'title,subtitle,origTitle',
				'match' => 'prefix',
				'limit' => self::PAGE_COUNT_LIMIT,
			]);
			$items = $descs = $urls = [];
			foreach ($books as $book) {
				$authors = $book->getAuthorNamesString();
				$items[] = $book->getTitle() . ($authors ? " – $authors" : '');
				$descs[] = '';
				$urls[] = $this->generateAbsoluteUrl('book_show', ['id' => $book->getId()]);
			}

			return [$query, $items, $descs, $urls];
		}
		$searchService = new SearchService($this->em());
		$query = $searchService->prepareQuery($request, $_format);
		if (isset($query['_template'])) {
			return $query;
		}

		if (empty($query['by'])) {
			$query['by'] = 'title,subtitle,origTitle';
		}
		$books = $this->findByQuery($query);
		$found = count($books) > 0;
		return [
			'query' => $query,
			'books' => $books,
			'found' => $found,
			'_status' => !$found ? 404 : null,
		];
	}

	public function randomAction() {
		$id = $this->em()->getBookRepository()->getRandomId();

		return $this->urlRedirect($this->generateUrl('book_show', ['id' => $id]));
	}

	/**
	 * @param Book $book
	 * @param string $format
	 * @return string File URL
	 */
	protected function processDownload(Book $book, $format) {
		$dlSite = $this->getMirrorServer();
		if ( $dlSite !== false ) {
			return "$dlSite/book/{$book->getId()}.$format";
		}

		$dlFile = new DownloadFile;
		switch ($format) {
			case 'sfb.zip':
				return $this->getWebRoot() . $dlFile->getSfbForBook($book);
			case 'txt.zip':
				return $this->getWebRoot() . $dlFile->getTxtForBook($book);
			case 'fb2.zip':
				return $this->getWebRoot() . $dlFile->getFb2ForBook($book);
			case 'epub':
				return $this->getWebRoot() . $dlFile->getEpubForBook($book);
			case 'djvu':
			case 'pdf':
				return $this->getWebRoot() . $dlFile->getStaticFileForBook($book, $format);
		}
		throw $this->createNotFoundException("Книгата не е налична във формат {$format}.");
	}

	protected function generateConverterUrl(string $urlTemplate, Book $book): string {
		$epubUrl = $this->generateAbsoluteUrl('book_show', ['id' => $book->getId(), '_format' => Book::FORMAT_EPUB]);
		return (new DownloadUrlGenerator())->generateConverterUrl($urlTemplate, $epubUrl);
	}

	/**
	 * @param array $query
	 * @return Book[]
	 */
	protected function findByQuery(array $query) {
		return $this->em()->getBookRepository()->findByQuery($query);
	}
}

chitanka / chitanka

Push — master ( c13757...19c3c0 )

BookController::showAction() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
