SudokuValidator::getLocationHaveContents() - Code Metrics - chipulaja/algo-backtrack-sudoku - Measure and Improve Code Quality continuously with Scrutinizer

SudokuValidator::getLocationHaveContents() A
last analyzed 2021-01-01 23:57 UTC

↳ Parent: SudokuValidator

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	17
Ratio	100 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes

Metric	Value
dl	17
loc	17
ccs	10
cts	10
cp	1
rs	9.7
c	0
b	0
f	0
cc	4
nc	4
nop	1
crap	4

<?php

namespace Chipulaja\Algo\Backtrack\Sudoku;

class SudokuValidator
{
    public function isValidSudoku($data)
    {
        $isValid = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $locationHaveContents = $this->getLocationHaveContents($data);
        foreach ($locationHaveContents as $location) {
            $x = $location['x'];
            $y = $location['y'];
            $value = $data[$x][$y];
            $vertical = $this->isValidVertical($location, $value, $data);
            if ($vertical === false) {
                return false;
            }
            $horisontal = $this->isValidHorisontal($location, $value, $data);
            if ($horisontal === false) {
                return false;
            }
            $squere = $this->isValidSquere($location, $value, $data);
            if ($squere === false) {
                return false;
            }
        }
        return true;
    }

    public function getLocationHaveContents($data)
    {
        $location = [];
        foreach ($data as $x => $cells) {
            foreach ($cells as $y => $value) {
                if (!empty($value)) {
                    $position = (int)($x."".$y);
                    $location[$position] = [
                        'x' => $x,
                        'y' => $y
                    ];
                }
            }
        }

        return $location;
    }

    protected function isValidVertical($location, $value, $data)
    {
        $x = $location["x"];
        $count = array_count_values($data[$x]);
        if ($count[$value] > 1) {
            return false;
        }
        return true;
    }

    protected function isValidHorisontal($location, $value, $data)
    {
        $dataY = [];
        foreach ($data as $x => $cells) {
            foreach ($cells as $y => $cellValue) {
                if ($y == $location["y"]) {
                    $dataY[] = $cellValue;
                }
            }
        }
        $count = array_count_values($dataY);
        if ($count[$value] > 1) {
            return false;
        }
        return true;
    }

    protected function isValidSquere($location, $value, $data)
    {
        $squereData = [];
        $x = $location['x'];
        $y = $location['y'];

        $iStart = 3 * floor($x/3);
        $iEnd   = $iStart + 2;
        $jStart = 3 * floor($y/3);
        $jEnd   = $jStart + 2;

        for ($i=$iStart; $i<=$iEnd; $i++) {

            for ($j=$jStart; $j<=$jEnd; $j++) {
                if (!empty($data[$i][$j])) {
                    $squereData[] = $data[$i][$j];
                }
            }
        }

        $count = array_count_values($squereData);
        if ($count[$value] > 1) {
            return false;
        }
        return true;
    }
}


1			<?php
2
3			namespace Chipulaja\Algo\Backtrack\Sudoku;
4
5			class SudokuValidator
6			{
7	1		public function isValidSudoku($data)
8			{
9	1		$isValid = true;
			0 ignored issues – show Unused Code introduced 2021-01-01 21:35 UTC by Report Bug Copy Issue Report `$isValid` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
10	1		$locationHaveContents = $this->getLocationHaveContents($data);
11	1		foreach ($locationHaveContents as $location) {
12	1		$x = $location['x'];
13	1		$y = $location['y'];
14	1		$value = $data[$x][$y];
15	1		$vertical = $this->isValidVertical($location, $value, $data);
16	1		if ($vertical === false) {
17	1		return false;
18			}
19	1		$horisontal = $this->isValidHorisontal($location, $value, $data);
20	1		if ($horisontal === false) {
21	1		return false;
22			}
23	1		$squere = $this->isValidSquere($location, $value, $data);
24	1		if ($squere === false) {
25	1		return false;
26			}
27			}
28	1		return true;
29			}
30
31	1	View Code Duplication	public function getLocationHaveContents($data)
32			{
33	1		$location = [];
34	1		foreach ($data as $x => $cells) {
35	1		foreach ($cells as $y => $value) {
36	1		if (!empty($value)) {
37	1		$position = (int)($x."".$y);
38	1		$location[$position] = [
39	1		'x' => $x,
40	1		'y' => $y
41			];
42			}
43			}
44			}
45
46	1		return $location;
47			}
48
49	1		protected function isValidVertical($location, $value, $data)
50			{
51	1		$x = $location["x"];
52	1		$count = array_count_values($data[$x]);
53	1		if ($count[$value] > 1) {
54	1		return false;
55			}
56	1		return true;
57			}
58
59	1		protected function isValidHorisontal($location, $value, $data)
60			{
61	1		$dataY = [];
62	1		foreach ($data as $x => $cells) {
63	1		foreach ($cells as $y => $cellValue) {
64	1		if ($y == $location["y"]) {
65	1		$dataY[] = $cellValue;
66			}
67			}
68			}
69	1		$count = array_count_values($dataY);
70	1		if ($count[$value] > 1) {
71	1		return false;
72			}
73	1		return true;
74			}
75
76	1		protected function isValidSquere($location, $value, $data)
77			{
78	1		$squereData = [];
79	1		$x = $location['x'];
80	1		$y = $location['y'];
81
82	1		$iStart = 3 * floor($x/3);
83	1		$iEnd = $iStart + 2;
84	1		$jStart = 3 * floor($y/3);
85	1		$jEnd = $jStart + 2;
86
87	1	View Code Duplication	for ($i=$iStart; $i<=$iEnd; $i++) {
			0 ignored issues – show Duplication introduced 2021-01-01 21:35 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88	1		for ($j=$jStart; $j<=$jEnd; $j++) {
89	1		if (!empty($data[$i][$j])) {
90	1		$squereData[] = $data[$i][$j];
91			}
92			}
93			}
94
95	1		$count = array_count_values($squereData);
96	1		if ($count[$value] > 1) {
97	1		return false;
98			}
99	1		return true;
100			}
101			}
102

chipulaja / algo-backtrack-sudoku

SudokuValidator::getLocationHaveContents() A last analyzed 2021-01-01 23:57 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

SudokuValidator::getLocationHaveContents() A
last analyzed 2021-01-01 23:57 UTC