| Conditions | 1 |
| Paths | 1 |
| Total Lines | 499 |
| Code Lines | 331 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 62 | public function dataProviderForTestFindAll() { |
||
| 63 | return array( |
||
| 64 | array( |
||
| 65 | // {{{ #0 |
||
| 66 | 'Attachment', |
||
| 67 | array( |
||
| 68 | 'fields' => 'Attachment.id', |
||
| 69 | 'contain' => array( |
||
| 70 | 'Comment' => array('fields' => 'Comment.id'), |
||
| 71 | 'Comment.Article' => array('fields' => 'Article.id'), |
||
| 72 | 'Comment.Article.User' => array('fields' => 'User.id'), |
||
| 73 | ), |
||
| 74 | ), |
||
| 75 | array('Attachment', 'Comment', 'Article', 'User'), |
||
| 76 | 1, |
||
| 77 | array( |
||
| 78 | array( |
||
| 79 | 'Attachment' => array( |
||
| 80 | 'id' => '1', |
||
| 81 | 'comment_id' => '5', |
||
| 82 | ), |
||
| 83 | 'Comment' => array( |
||
| 84 | 'id' => '5', |
||
| 85 | 'article_id' => '2', |
||
| 86 | 'Article' => array( |
||
| 87 | 'id' => '2', |
||
| 88 | 'user_id' => '3', |
||
| 89 | 'User' => array( |
||
| 90 | 'id' => '3', |
||
| 91 | ), |
||
| 92 | ), |
||
| 93 | ), |
||
| 94 | ), |
||
| 95 | ), |
||
| 96 | // }}} |
||
| 97 | ), |
||
| 98 | array( |
||
| 99 | // {{{ #1 |
||
| 100 | 'Article', |
||
| 101 | array( |
||
| 102 | 'fields' => array('Article.id'), |
||
| 103 | 'contain' => array( |
||
| 104 | 'User' => array('fields' => 'User.id'), |
||
| 105 | 'Comment' => array( |
||
| 106 | 'fields' => 'Comment.id', |
||
| 107 | 'order' => 'Comment.id', |
||
| 108 | 'User' => array('fields' => 'User.id'), |
||
| 109 | ), |
||
| 110 | ), |
||
| 111 | ), |
||
| 112 | array('Article', 'Comment', 'User'), |
||
| 113 | 2, |
||
| 114 | array( |
||
| 115 | array( |
||
| 116 | 'Article' => array( |
||
| 117 | 'id' => '1', |
||
| 118 | 'user_id' => '1', |
||
| 119 | ), |
||
| 120 | 'User' => array( |
||
| 121 | 'id' => '1', |
||
| 122 | ), |
||
| 123 | 'Comment' => array( |
||
| 124 | array( |
||
| 125 | 'id' => '1', |
||
| 126 | 'article_id' => '1', |
||
| 127 | 'user_id' => '2', |
||
| 128 | 'User' => array( |
||
| 129 | 'id' => '2', |
||
| 130 | ), |
||
| 131 | ), |
||
| 132 | array( |
||
| 133 | 'id' => '2', |
||
| 134 | 'article_id' => '1', |
||
| 135 | 'user_id' => '4', |
||
| 136 | 'User' => array( |
||
| 137 | 'id' => '4', |
||
| 138 | ), |
||
| 139 | ), |
||
| 140 | array( |
||
| 141 | 'id' => '3', |
||
| 142 | 'article_id' => '1', |
||
| 143 | 'user_id' => '1', |
||
| 144 | 'User' => array( |
||
| 145 | 'id' => '1', |
||
| 146 | ), |
||
| 147 | ), |
||
| 148 | array( |
||
| 149 | 'id' => '4', |
||
| 150 | 'article_id' => '1', |
||
| 151 | 'user_id' => '1', |
||
| 152 | 'User' => array( |
||
| 153 | 'id' => '1', |
||
| 154 | ), |
||
| 155 | ), |
||
| 156 | ), |
||
| 157 | ), |
||
| 158 | array( |
||
| 159 | 'Article' => array( |
||
| 160 | 'id' => '2', |
||
| 161 | 'user_id' => '3', |
||
| 162 | ), |
||
| 163 | 'User' => array( |
||
| 164 | 'id' => '3', |
||
| 165 | ), |
||
| 166 | 'Comment' => array( |
||
| 167 | array( |
||
| 168 | 'id' => '5', |
||
| 169 | 'article_id' => '2', |
||
| 170 | 'user_id' => '1', |
||
| 171 | 'User' => array( |
||
| 172 | 'id' => '1', |
||
| 173 | ), |
||
| 174 | ), |
||
| 175 | array( |
||
| 176 | 'id' => '6', |
||
| 177 | 'article_id' => '2', |
||
| 178 | 'user_id' => '2', |
||
| 179 | 'User' => array( |
||
| 180 | 'id' => '2', |
||
| 181 | ), |
||
| 182 | ), |
||
| 183 | ), |
||
| 184 | ), |
||
| 185 | array( |
||
| 186 | 'Article' => array( |
||
| 187 | 'id' => '3', |
||
| 188 | 'user_id' => '1', |
||
| 189 | ), |
||
| 190 | 'User' => array( |
||
| 191 | 'id' => '1', |
||
| 192 | ), |
||
| 193 | 'Comment' => array(), |
||
| 194 | ), |
||
| 195 | ), |
||
| 196 | // }}} |
||
| 197 | ), |
||
| 198 | array( |
||
| 199 | // {{{ #2 |
||
| 200 | 'User', |
||
| 201 | array( |
||
| 202 | 'fields' => array('User.user'), |
||
| 203 | 'contain' => array( |
||
| 204 | 'Article' => array( |
||
| 205 | 'fields' => array('Article.title'), |
||
| 206 | 'limit' => 1, |
||
| 207 | ), |
||
| 208 | ), |
||
| 209 | ), |
||
| 210 | array('User', 'Article'), |
||
| 211 | 5, |
||
| 212 | array( |
||
| 213 | array( |
||
| 214 | 'User' => array( |
||
| 215 | 'id' => '1', |
||
| 216 | 'user' => 'mariano', |
||
| 217 | ), |
||
| 218 | 'Article' => array( |
||
| 219 | array( |
||
| 220 | 'user_id' => '1', |
||
| 221 | 'title' => 'First Article', |
||
| 222 | ), |
||
| 223 | ), |
||
| 224 | ), |
||
| 225 | array( |
||
| 226 | 'User' => array( |
||
| 227 | 'id' => '2', |
||
| 228 | 'user' => 'nate', |
||
| 229 | ), |
||
| 230 | 'Article' => array( |
||
| 231 | ), |
||
| 232 | ), |
||
| 233 | array( |
||
| 234 | 'User' => array( |
||
| 235 | 'id' => '3', |
||
| 236 | 'user' => 'larry', |
||
| 237 | ), |
||
| 238 | 'Article' => array( |
||
| 239 | array( |
||
| 240 | 'user_id' => '3', |
||
| 241 | 'title' => 'Second Article', |
||
| 242 | ), |
||
| 243 | ), |
||
| 244 | ), |
||
| 245 | array( |
||
| 246 | 'User' => array( |
||
| 247 | 'id' => '4', |
||
| 248 | 'user' => 'garrett', |
||
| 249 | ), |
||
| 250 | 'Article' => array( |
||
| 251 | ), |
||
| 252 | ), |
||
| 253 | ), |
||
| 254 | // }}} |
||
| 255 | ), |
||
| 256 | array( |
||
| 257 | // {{{ #3 |
||
| 258 | 'Article', |
||
| 259 | array( |
||
| 260 | 'fields' => 'Article.id', |
||
| 261 | 'contain' => array( |
||
| 262 | 'Tag' => array( |
||
| 263 | 'fields' => array('Tag.tag'), |
||
| 264 | ), |
||
| 265 | ), |
||
| 266 | 'conditions' => array( |
||
| 267 | 'Article.id' => 1, |
||
| 268 | ), |
||
| 269 | ), |
||
| 270 | array('Article', 'Tag', 'ArticlesTag'), |
||
| 271 | 2, |
||
| 272 | array( |
||
| 273 | array( |
||
| 274 | 'Article' => array( |
||
| 275 | 'id' => '1', |
||
| 276 | ), |
||
| 277 | 'Tag' => array( |
||
| 278 | array( |
||
| 279 | 'id' => '1', |
||
| 280 | 'tag' => 'tag1', |
||
| 281 | 'ArticlesTag' => array( |
||
| 282 | 'article_id' => '1', |
||
| 283 | 'tag_id' => '1', |
||
| 284 | ), |
||
| 285 | ), |
||
| 286 | array( |
||
| 287 | 'id' => '2', |
||
| 288 | 'tag' => 'tag2', |
||
| 289 | 'ArticlesTag' => array( |
||
| 290 | 'article_id' => '1', |
||
| 291 | 'tag_id' => '2', |
||
| 292 | ), |
||
| 293 | ), |
||
| 294 | ), |
||
| 295 | ), |
||
| 296 | ), |
||
| 297 | // }}} |
||
| 298 | ), |
||
| 299 | array( |
||
| 300 | // {{{ #4 |
||
| 301 | 'User', |
||
| 302 | array( |
||
| 303 | 'fields' => 'User.id', |
||
| 304 | 'contain' => array( |
||
| 305 | 'Article' => array( |
||
| 306 | 'fields' => array('Article.id'), |
||
| 307 | 'conditions' => array('Article.user_id' => 3), |
||
| 308 | ), |
||
| 309 | ), |
||
| 310 | 'conditions' => array( |
||
| 311 | 'User.id' => array('1', '3'), |
||
| 312 | ), |
||
| 313 | ), |
||
| 314 | array('User', 'Article'), |
||
| 315 | 2, |
||
| 316 | array( |
||
| 317 | array( |
||
| 318 | 'User' => array( |
||
| 319 | 'id' => '1', |
||
| 320 | ), |
||
| 321 | 'Article' => array(), |
||
| 322 | ), |
||
| 323 | array( |
||
| 324 | 'User' => array( |
||
| 325 | 'id' => '3', |
||
| 326 | ), |
||
| 327 | 'Article' => array( |
||
| 328 | array( |
||
| 329 | 'id' => '2', |
||
| 330 | 'user_id' => '3', |
||
| 331 | ), |
||
| 332 | ), |
||
| 333 | ), |
||
| 334 | ), |
||
| 335 | // }}} |
||
| 336 | ), |
||
| 337 | array( |
||
| 338 | // {{{ #5 |
||
| 339 | 'Article', |
||
| 340 | array( |
||
| 341 | 'fields' => 'Article.id', |
||
| 342 | 'contain' => array( |
||
| 343 | 'FirstComment' => array('fields' => 'id'), |
||
| 344 | 'SecondComment' => array('fields' => 'id'), |
||
| 345 | ), |
||
| 346 | ), |
||
| 347 | array('Article', 'Comment'), |
||
| 348 | 7, |
||
| 349 | array( |
||
| 350 | array( |
||
| 351 | 'Article' => array( |
||
| 352 | 'id' => '1', |
||
| 353 | ), |
||
| 354 | 'FirstComment' => array( |
||
| 355 | 'id' => '1', |
||
| 356 | 'article_id' => '1', |
||
| 357 | ), |
||
| 358 | 'SecondComment' => array( |
||
| 359 | 'id' => '2', |
||
| 360 | 'article_id' => '1', |
||
| 361 | ), |
||
| 362 | ), |
||
| 363 | array( |
||
| 364 | 'Article' => array( |
||
| 365 | 'id' => '2', |
||
| 366 | ), |
||
| 367 | 'FirstComment' => array( |
||
| 368 | 'id' => '5', |
||
| 369 | 'article_id' => '2', |
||
| 370 | ), |
||
| 371 | 'SecondComment' => array( |
||
| 372 | 'id' => '6', |
||
| 373 | 'article_id' => '2', |
||
| 374 | ), |
||
| 375 | ), |
||
| 376 | array( |
||
| 377 | 'Article' => array( |
||
| 378 | 'id' => '3', |
||
| 379 | ), |
||
| 380 | 'FirstComment' => array(), |
||
| 381 | 'SecondComment' => array(), |
||
| 382 | ), |
||
| 383 | ), |
||
| 384 | // }}} |
||
| 385 | ), |
||
| 386 | array( |
||
| 387 | // {{{ #6 |
||
| 388 | 'Article', |
||
| 389 | array( |
||
| 390 | 'fields' => 'Article.id', |
||
| 391 | 'contain' => array( |
||
| 392 | 'FirstComment' => array('fields' => 'id'), |
||
| 393 | 'SecondComment' => array('fields' => 'id'), |
||
| 394 | ), |
||
| 395 | ), |
||
| 396 | array('Article', 'Comment'), |
||
| 397 | 7, |
||
| 398 | array( |
||
| 399 | array( |
||
| 400 | 'Article' => array( |
||
| 401 | 'id' => '1', |
||
| 402 | ), |
||
| 403 | 'FirstComment' => array( |
||
| 404 | 'id' => '1', |
||
| 405 | 'article_id' => '1', |
||
| 406 | ), |
||
| 407 | 'SecondComment' => array( |
||
| 408 | 'id' => '2', |
||
| 409 | 'article_id' => '1', |
||
| 410 | ), |
||
| 411 | ), |
||
| 412 | array( |
||
| 413 | 'Article' => array( |
||
| 414 | 'id' => '2', |
||
| 415 | ), |
||
| 416 | 'FirstComment' => array( |
||
| 417 | 'id' => '5', |
||
| 418 | 'article_id' => '2', |
||
| 419 | ), |
||
| 420 | 'SecondComment' => array( |
||
| 421 | 'id' => '6', |
||
| 422 | 'article_id' => '2', |
||
| 423 | ), |
||
| 424 | ), |
||
| 425 | array( |
||
| 426 | 'Article' => array( |
||
| 427 | 'id' => '3', |
||
| 428 | ), |
||
| 429 | 'FirstComment' => array(), |
||
| 430 | 'SecondComment' => array(), |
||
| 431 | ), |
||
| 432 | ), |
||
| 433 | // }}} |
||
| 434 | ), |
||
| 435 | array( |
||
| 436 | // {{{ #7 Deep associations |
||
| 437 | 'User', |
||
| 438 | array( |
||
| 439 | 'fields' => 'User.id', |
||
| 440 | 'contain' => array( |
||
| 441 | 'Article' => array( |
||
| 442 | 'fields' => array('Article.id'), |
||
| 443 | 'User' => array( |
||
| 444 | 'fields' => array('User.id'), |
||
| 445 | 'Profile' => array( |
||
| 446 | 'fields' => array('Profile.id'), |
||
| 447 | ), |
||
| 448 | 'Article' => array( |
||
| 449 | 'fields' => array('Article.id'), |
||
| 450 | 'User' => array( |
||
| 451 | 'fields' => array('User.id'), |
||
| 452 | ), |
||
| 453 | 'Tag' => array( |
||
| 454 | 'fields' => array('Tag.id'), |
||
| 455 | ), |
||
| 456 | ), |
||
| 457 | ), |
||
| 458 | ), |
||
| 459 | ), |
||
| 460 | 'conditions' => array( |
||
| 461 | 'User.id' => '3', |
||
| 462 | ), |
||
| 463 | ), |
||
| 464 | array('User', 'Article', 'Profile', 'ArticlesTag', 'Tag'), |
||
| 465 | 4, |
||
| 466 | array( |
||
| 467 | array( |
||
| 468 | 'User' => array( |
||
| 469 | 'id' => 3, |
||
| 470 | ), |
||
| 471 | 'Article' => array( |
||
| 472 | array( |
||
| 473 | 'id' => '2', |
||
| 474 | 'user_id' => '3', |
||
| 475 | 'User' => array( |
||
| 476 | 'id' => '3', |
||
| 477 | 'Profile' => array( |
||
| 478 | 'id' => '1', |
||
| 479 | 'user_id' => '3', |
||
| 480 | ), |
||
| 481 | 'Article' => array( |
||
| 482 | array( |
||
| 483 | 'id' => '2', |
||
| 484 | 'user_id' => '3', |
||
| 485 | 'User' => array( |
||
| 486 | 'id' => '3', |
||
| 487 | ), |
||
| 488 | 'Tag' => array( |
||
| 489 | array( |
||
| 490 | 'id' => '1', |
||
| 491 | 'ArticlesTag' => array( |
||
| 492 | 'article_id' => '2', |
||
| 493 | 'tag_id' => '1', |
||
| 494 | ), |
||
| 495 | ), |
||
| 496 | array( |
||
| 497 | 'id' => '3', |
||
| 498 | 'ArticlesTag' => array( |
||
| 499 | 'article_id' => '2', |
||
| 500 | 'tag_id' => '3', |
||
| 501 | ), |
||
| 502 | ), |
||
| 503 | ), |
||
| 504 | ), |
||
| 505 | ), |
||
| 506 | ), |
||
| 507 | ), |
||
| 508 | ), |
||
| 509 | ), |
||
| 510 | ), |
||
| 511 | // }}} |
||
| 512 | ), |
||
| 513 | array( |
||
| 514 | // {{{ #8 Parent not exists |
||
| 515 | 'Category', |
||
| 516 | array( |
||
| 517 | 'fields' => 'Category.id', |
||
| 518 | 'contain' => array( |
||
| 519 | 'ParentCategory' => array( |
||
| 520 | 'fields' => array('ParentCategory.id'), |
||
| 521 | 'Article' => array( |
||
| 522 | 'fields' => array('Article.id'), |
||
| 523 | ), |
||
| 524 | ), |
||
| 525 | ), |
||
| 526 | 'conditions' => array('Category.id' => array(1, 2)), |
||
| 527 | ), |
||
| 528 | array('Category', 'Article', 'ArticlesCategory'), |
||
| 529 | 2, |
||
| 530 | array( |
||
| 531 | array( |
||
| 532 | 'Category' => array( |
||
| 533 | 'id' => '1', |
||
| 534 | 'parent_id' => '0', |
||
| 535 | ), |
||
| 536 | 'ParentCategory' => array(), |
||
| 537 | ), |
||
| 538 | array( |
||
| 539 | 'Category' => array( |
||
| 540 | 'id' => '2', |
||
| 541 | 'parent_id' => '1', |
||
| 542 | ), |
||
| 543 | 'ParentCategory' => array( |
||
| 544 | 'id' => '1', |
||
| 545 | 'Article' => array( |
||
| 546 | array( |
||
| 547 | 'id' => '1', |
||
| 548 | 'ArticlesCategory' => array( |
||
| 549 | 'article_id' => '1', |
||
| 550 | 'category_id' => '1', |
||
| 551 | ), |
||
| 552 | ), |
||
| 553 | ), |
||
| 554 | ), |
||
| 555 | ), |
||
| 556 | ), |
||
| 557 | // }}} |
||
| 558 | ), |
||
| 559 | ); |
||
| 560 | } |
||
| 561 | |||
| 1152 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.