RouterMacros::multilingual() - Code Metrics - Inspection of "Closes #26" - chinleung/laravel-multilingual-routes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f22aed...46f558 )

by Chin

created 2020-01-25 03:09 UTC

RouterMacros::multilingual() A

↳ Parent: RouterMacros

Complexity

Conditions	4
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	1
nop	0
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0

<?php

namespace ChinLeung\MultilingualRoutes\Macros;

use ChinLeung\MultilingualRoutes\MultilingualRegistrar;
use ChinLeung\MultilingualRoutes\MultilingualRoutePendingRegistration;
use Closure;

class RouterMacros
{
    /**
     * Register a multilingual GET route.
     *
     * @param  string  $key
     * @param  mixed  $handle
     * @param  array  $locales
     * @return \Closure
     */
    public function multilingual(): Closure
    {
        return function ($key, $handle = null, $locales = []) {
            return new MultilingualRoutePendingRegistration(
                $this->container && $this->container->bound(MultilingualRegistrar::class)
                    ? $this->container->make(MultilingualRegistrar::class)
                    : new MultilingualRegistrar($this),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ltrim($key, '/'),
                $handle,
                $locales ?: locales()
            );
        };
    }
}


1			<?php
2
3			namespace ChinLeung\MultilingualRoutes\Macros;
4
5			use ChinLeung\MultilingualRoutes\MultilingualRegistrar;
6			use ChinLeung\MultilingualRoutes\MultilingualRoutePendingRegistration;
7			use Closure;
8
9			class RouterMacros
10			{
11			/**
12			* Register a multilingual GET route.
13			*
14			* @param string $key
15			* @param mixed $handle
16			* @param array $locales
17			* @return \Closure
18			*/
19			public function multilingual(): Closure
20			{
21			return function ($key, $handle = null, $locales = []) {
22			return new MultilingualRoutePendingRegistration(
23			$this->container && $this->container->bound(MultilingualRegistrar::class)
24			? $this->container->make(MultilingualRegistrar::class)
25			: new MultilingualRegistrar($this),
			0 ignored issues – show Documentation introduced 2020-01-25 03:12 UTC by Report Bug Copy Issue Report `$this` is of type `this<ChinLeung\Multiling...es\Macros\RouterMacros>`, but the function expects a `object<Illuminate\Routing\Router>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			ltrim($key, '/'),
27			$handle,
28			$locales ?: locales()
29			);
30			};
31			}
32			}
33

chinleung / laravel-multilingual-routes

Push — master ( f22aed...46f558 )

RouterMacros::multilingual() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like