chillu / silverstripe-elemental-embedly-block

src/Block/EmbedlyBlock.php

<?php

namespace Chillu\ElementalEmbedlyBlock\Block;

use DNADesign\Elemental\Models\BaseElement;
use SilverStripe\Forms\FieldList;
use SilverStripe\SiteConfig\SiteConfig;
use SilverStripe\View\Requirements;

class EmbedlyBlock extends BaseElement
{
    private static $icon = 'font-icon-block-media';

The private property $icon is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'EmbedURL' => 'Text',
        'Width' => 'Varchar',
        'Align' => 'Enum(array("left","right","center"), "left")',
    ];

    private static $singular_name = 'Embed.ly';

The private property $singular_name is not used, and could be removed.

    private static $plural_name = 'Embed.ly';

The private property $plural_name is not used, and could be removed.

    private static $table_name = 'EmbedlyBlock';

The private property $table_name is not used, and could be removed.

    public function getType()
    {
        return _t(__CLASS__ . '.BlockType', 'Embed.ly');
    }

    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->dataFieldByName('EmbedURL')->setRows(1);

            $fields->dataFieldByName('Width')
                ->setTitle('Maximum width')
                ->setDescription('Example: 500px, 100%. Cards are responsive by default.');
        });

        return parent::getCMSFields();
    }

    /**
     * Return content summary for summary section of ElementEditor
     *
     * @return array
     */
    protected function provideBlockSchema()
    {
        $blockSchema = parent::provideBlockSchema();
        $blockSchema['content'] = $this->EmbedURL;

The property EmbedURL does not exist on Chillu\ElementalEmbedlyBlock\Block\EmbedlyBlock. Since you implemented __get, consider adding a @property annotation.

        return $blockSchema;
    }

    /**
     * @return string
     */
    public function getWidthAttribute()
    {
        if (!$this->Width) {

The property Width does not exist on Chillu\ElementalEmbedlyBlock\Block\EmbedlyBlock. Since you implemented __get, consider adding a @property annotation.

            return '';
        }

        if (is_numeric($this->Width)) {
            return "{$this->Width}px";
        }

        // Sanitisation
        if (!preg_match('/[0-9](\%|px)/', $this->Width)) {
            return '';
        }

        return $this->Width;
    }

    public function getApiKey()
    {
        return SiteConfig::get()->First()->ElementalEmbedlyApiKey;
    }

}