Inspection of ":worried: hmm..." - chillerlan/php-traits - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 52755b...6c4366 )

by smiley

created 2017-11-26 02:39 UTC

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -3,12 +3,12 @@
 block discarded – undo
 
 class CoverageClassExtendedTest extends TestCase
 {
-    /**
-     * @covers CoveredClass<extended>
-     */
-    public function testSomething()
-    {
-        $o = new CoveredClass;
-        $o->publicMethod();
-    }
+	/**
+	 * @covers CoveredClass<extended>
+	 */
+	public function testSomething()
+	{
+		$o = new CoveredClass;
+		$o->publicMethod();
+	}
 }

Please login to merge, or discard this patch.

vendor/phpunit/php-code-coverage/tests/_files/CoverageClassTest.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -3,12 +3,12 @@
 block discarded – undo
 
 class CoverageClassTest extends TestCase
 {
-    /**
-     * @covers CoveredClass
-     */
-    public function testSomething()
-    {
-        $o = new CoveredClass;
-        $o->publicMethod();
-    }
+	/**
+	 * @covers CoveredClass
+	 */
+	public function testSomething()
+	{
+		$o = new CoveredClass;
+		$o->publicMethod();
+	}
 }

Please login to merge, or discard this patch.

vendor/phpunit/php-code-coverage/tests/_files/CoveredClass.php 1 patch

Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

@@ -1,36 +1,36 @@
 block discarded – undo
 <?php
 class CoveredParentClass
 {
-    private function privateMethod()
-    {
-    }
+	private function privateMethod()
+	{
+	}
 
-    protected function protectedMethod()
-    {
-        $this->privateMethod();
-    }
+	protected function protectedMethod()
+	{
+		$this->privateMethod();
+	}
 
-    public function publicMethod()
-    {
-        $this->protectedMethod();
-    }
+	public function publicMethod()
+	{
+		$this->protectedMethod();
+	}
 }
 
 class CoveredClass extends CoveredParentClass
 {
-    private function privateMethod()
-    {
-    }
+	private function privateMethod()
+	{
+	}
 
-    protected function protectedMethod()
-    {
-        parent::protectedMethod();
-        $this->privateMethod();
-    }
+	protected function protectedMethod()
+	{
+		parent::protectedMethod();
+		$this->privateMethod();
+	}
 
-    public function publicMethod()
-    {
-        parent::publicMethod();
-        $this->protectedMethod();
-    }
+	public function publicMethod()
+	{
+		parent::publicMethod();
+		$this->protectedMethod();
+	}
 }

Please login to merge, or discard this patch.

phpunit/php-code-coverage/tests/_files/NamespaceCoverageClassTest.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -3,12 +3,12 @@
 block discarded – undo
 
 class NamespaceCoverageClassTest extends TestCase
 {
-    /**
-     * @covers Foo\CoveredClass
-     */
-    public function testSomething()
-    {
-        $o = new Foo\CoveredClass;
-        $o->publicMethod();
-    }
+	/**
+	 * @covers Foo\CoveredClass
+	 */
+	public function testSomething()
+	{
+		$o = new Foo\CoveredClass;
+		$o->publicMethod();
+	}
 }

Please login to merge, or discard this patch.

php-code-coverage/tests/_files/CoverageTwoDefaultClassAnnotations.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -5,13 +5,13 @@
 block discarded – undo
  */
 class CoverageTwoDefaultClassAnnotations
 {
-    /**
-     * @covers Foo\CoveredClass::<public>
-     */
-    public function testSomething()
-    {
-        $o = new Foo\CoveredClass;
-        $o->publicMethod();
-    }
+	/**
+	 * @covers Foo\CoveredClass::<public>
+	 */
+	public function testSomething()
+	{
+		$o = new Foo\CoveredClass;
+		$o->publicMethod();
+	}
 
 }

Please login to merge, or discard this patch.

vendor/phpunit/php-code-coverage/tests/_files/source_without_namespace.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

		@@ -11,8 +11,8 @@
		block discarded – undo
11	11	*/
12	12	function &foo($bar)
13	13	{
14		- $baz = function () {};
15		- $a = true ? true : false;
16		- $b = "{$a}";
17		- $c = "${b}";
	14	+ $baz = function () {};
	15	+ $a = true ? true : false;
	16	+ $b = "{$a}";
	17	+ $c = "${b}";
18	18	}

Please login to merge, or discard this patch.

phpunit/php-code-coverage/tests/_files/source_with_oneline_annotations.php 1 patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -3,34 +3,34 @@
 block discarded – undo
 /** Docblock */
 interface Foo
 {
-    public function bar();
+	public function bar();
 }
 
 class Foo
 {
-    public function bar()
-    {
-    }
+	public function bar()
+	{
+	}
 }
 
 function baz()
 {
-    // a one-line comment
-    print '*'; // a one-line comment
+	// a one-line comment
+	print '*'; // a one-line comment
 
-    /* a one-line comment */
-    print '*'; /* a one-line comment */
+	/* a one-line comment */
+	print '*'; /* a one-line comment */
 
-    /* a one-line comment
+	/* a one-line comment
      */
-    print '*'; /* a one-line comment
+	print '*'; /* a one-line comment
     */
 
-    print '*'; // @codeCoverageIgnore
+	print '*'; // @codeCoverageIgnore
 
-    print '*'; // @codeCoverageIgnoreStart
-    print '*';
-    print '*'; // @codeCoverageIgnoreEnd
+	print '*'; // @codeCoverageIgnoreStart
+	print '*';
+	print '*'; // @codeCoverageIgnoreEnd
 
-    print '*';
+	print '*';
 }

Please login to merge, or discard this patch.

vendor/phpunit/php-code-coverage/tests/_files/CoverageNotProtectedTest.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -3,12 +3,12 @@
 block discarded – undo
 
 class CoverageNotProtectedTest extends TestCase
 {
-    /**
-     * @covers CoveredClass::<!protected>
-     */
-    public function testSomething()
-    {
-        $o = new CoveredClass;
-        $o->publicMethod();
-    }
+	/**
+	 * @covers CoveredClass::<!protected>
+	 */
+	public function testSomething()
+	{
+		$o = new CoveredClass;
+		$o->publicMethod();
+	}
 }

Please login to merge, or discard this patch.

vendor/phpunit/php-code-coverage/tests/_files/BankAccountTest.php 1 patch

Indentation +51 added lines, -51 removed lines patch added patch discarded remove patch

@@ -5,64 +5,64 @@
 block discarded – undo
 
 class BankAccountTest extends TestCase
 {
-    protected $ba;
+	protected $ba;
 
-    protected function setUp()
-    {
-        $this->ba = new BankAccount;
-    }
+	protected function setUp()
+	{
+		$this->ba = new BankAccount;
+	}
 
-    /**
-     * @covers BankAccount::getBalance
-     */
-    public function testBalanceIsInitiallyZero()
-    {
-        $this->assertEquals(0, $this->ba->getBalance());
-    }
+	/**
+	 * @covers BankAccount::getBalance
+	 */
+	public function testBalanceIsInitiallyZero()
+	{
+		$this->assertEquals(0, $this->ba->getBalance());
+	}
 
-    /**
-     * @covers BankAccount::withdrawMoney
-     */
-    public function testBalanceCannotBecomeNegative()
-    {
-        try {
-            $this->ba->withdrawMoney(1);
-        } catch (RuntimeException $e) {
-            $this->assertEquals(0, $this->ba->getBalance());
+	/**
+	 * @covers BankAccount::withdrawMoney
+	 */
+	public function testBalanceCannotBecomeNegative()
+	{
+		try {
+			$this->ba->withdrawMoney(1);
+		} catch (RuntimeException $e) {
+			$this->assertEquals(0, $this->ba->getBalance());
 
-            return;
-        }
+			return;
+		}
 
-        $this->fail();
-    }
+		$this->fail();
+	}
 
-    /**
-     * @covers BankAccount::depositMoney
-     */
-    public function testBalanceCannotBecomeNegative2()
-    {
-        try {
-            $this->ba->depositMoney(-1);
-        } catch (RuntimeException $e) {
-            $this->assertEquals(0, $this->ba->getBalance());
+	/**
+	 * @covers BankAccount::depositMoney
+	 */
+	public function testBalanceCannotBecomeNegative2()
+	{
+		try {
+			$this->ba->depositMoney(-1);
+		} catch (RuntimeException $e) {
+			$this->assertEquals(0, $this->ba->getBalance());
 
-            return;
-        }
+			return;
+		}
 
-        $this->fail();
-    }
+		$this->fail();
+	}
 
-    /**
-     * @covers BankAccount::getBalance
-     * @covers BankAccount::depositMoney
-     * @covers BankAccount::withdrawMoney
-     */
-    public function testDepositWithdrawMoney()
-    {
-        $this->assertEquals(0, $this->ba->getBalance());
-        $this->ba->depositMoney(1);
-        $this->assertEquals(1, $this->ba->getBalance());
-        $this->ba->withdrawMoney(1);
-        $this->assertEquals(0, $this->ba->getBalance());
-    }
+	/**
+	 * @covers BankAccount::getBalance
+	 * @covers BankAccount::depositMoney
+	 * @covers BankAccount::withdrawMoney
+	 */
+	public function testDepositWithdrawMoney()
+	{
+		$this->assertEquals(0, $this->ba->getBalance());
+		$this->ba->depositMoney(1);
+		$this->assertEquals(1, $this->ba->getBalance());
+		$this->ba->withdrawMoney(1);
+		$this->assertEquals(0, $this->ba->getBalance());
+	}
 }

Please login to merge, or discard this patch.

		@@ -3,12 +3,12 @@
		block discarded – undo
3	3
4	4	class CoverageClassExtendedTest extends TestCase
5	5	{
6		- /**
7		- * @covers CoveredClass<extended>
8		- */
9		- public function testSomething()
10		- {
11		- $o = new CoveredClass;
12		- $o->publicMethod();
13		- }
	6	+ /**
	7	+ * @covers CoveredClass<extended>
	8	+ */
	9	+ public function testSomething()
	10	+ {
	11	+ $o = new CoveredClass;
	12	+ $o->publicMethod();
	13	+ }
14	14	}

		@@ -3,12 +3,12 @@
		block discarded – undo
3	3
4	4	class CoverageClassTest extends TestCase
5	5	{
6		- /**
7		- * @covers CoveredClass
8		- */
9		- public function testSomething()
10		- {
11		- $o = new CoveredClass;
12		- $o->publicMethod();
13		- }
	6	+ /**
	7	+ * @covers CoveredClass
	8	+ */
	9	+ public function testSomething()
	10	+ {
	11	+ $o = new CoveredClass;
	12	+ $o->publicMethod();
	13	+ }
14	14	}

		@@ -1,36 +1,36 @@
		block discarded – undo
1	1	<?php
2	2	class CoveredParentClass
3	3	{
4		- private function privateMethod()
5		- {
6		- }
	4	+ private function privateMethod()
	5	+ {
	6	+ }
7	7
8		- protected function protectedMethod()
9		- {
10		- $this->privateMethod();
11		- }
	8	+ protected function protectedMethod()
	9	+ {
	10	+ $this->privateMethod();
	11	+ }
12	12
13		- public function publicMethod()
14		- {
15		- $this->protectedMethod();
16		- }
	13	+ public function publicMethod()
	14	+ {
	15	+ $this->protectedMethod();
	16	+ }
17	17	}
18	18
19	19	class CoveredClass extends CoveredParentClass
20	20	{
21		- private function privateMethod()
22		- {
23		- }
	21	+ private function privateMethod()
	22	+ {
	23	+ }
24	24
25		- protected function protectedMethod()
26		- {
27		- parent::protectedMethod();
28		- $this->privateMethod();
29		- }
	25	+ protected function protectedMethod()
	26	+ {
	27	+ parent::protectedMethod();
	28	+ $this->privateMethod();
	29	+ }
30	30
31		- public function publicMethod()
32		- {
33		- parent::publicMethod();
34		- $this->protectedMethod();
35		- }
	31	+ public function publicMethod()
	32	+ {
	33	+ parent::publicMethod();
	34	+ $this->protectedMethod();
	35	+ }
36	36	}

		@@ -3,12 +3,12 @@
		block discarded – undo
3	3
4	4	class NamespaceCoverageClassTest extends TestCase
5	5	{
6		- /**
7		- * @covers Foo\CoveredClass
8		- */
9		- public function testSomething()
10		- {
11		- $o = new Foo\CoveredClass;
12		- $o->publicMethod();
13		- }
	6	+ /**
	7	+ * @covers Foo\CoveredClass
	8	+ */
	9	+ public function testSomething()
	10	+ {
	11	+ $o = new Foo\CoveredClass;
	12	+ $o->publicMethod();
	13	+ }
14	14	}

		@@ -5,13 +5,13 @@
		block discarded – undo
5	5	*/
6	6	class CoverageTwoDefaultClassAnnotations
7	7	{
8		- /**
9		- * @covers Foo\CoveredClass::<public>
10		- */
11		- public function testSomething()
12		- {
13		- $o = new Foo\CoveredClass;
14		- $o->publicMethod();
15		- }
	8	+ /**
	9	+ * @covers Foo\CoveredClass::<public>
	10	+ */
	11	+ public function testSomething()
	12	+ {
	13	+ $o = new Foo\CoveredClass;
	14	+ $o->publicMethod();
	15	+ }
16	16
17	17	}

		@@ -3,34 +3,34 @@
		block discarded – undo
3	3	/** Docblock */
4	4	interface Foo
5	5	{
6		- public function bar();
	6	+ public function bar();
7	7	}
8	8
9	9	class Foo
10	10	{
11		- public function bar()
12		- {
13		- }
	11	+ public function bar()
	12	+ {
	13	+ }
14	14	}
15	15
16	16	function baz()
17	17	{
18		- // a one-line comment
19		- print '*'; // a one-line comment
	18	+ // a one-line comment
	19	+ print '*'; // a one-line comment
20	20
21		- /* a one-line comment */
22		- print ''; / a one-line comment */
	21	+ /* a one-line comment */
	22	+ print ''; / a one-line comment */
23	23
24		- /* a one-line comment
	24	+ /* a one-line comment
25	25	*/
26		- print ''; / a one-line comment
	26	+ print ''; / a one-line comment
27	27	*/
28	28
29		- print '*'; // @codeCoverageIgnore
	29	+ print '*'; // @codeCoverageIgnore
30	30
31		- print '*'; // @codeCoverageIgnoreStart
32		- print '*';
33		- print '*'; // @codeCoverageIgnoreEnd
	31	+ print '*'; // @codeCoverageIgnoreStart
	32	+ print '*';
	33	+ print '*'; // @codeCoverageIgnoreEnd
34	34
35		- print '*';
	35	+ print '*';
36	36	}

		@@ -3,12 +3,12 @@
		block discarded – undo
3	3
4	4	class CoverageNotProtectedTest extends TestCase
5	5	{
6		- /**
7		- * @covers CoveredClass::<!protected>
8		- */
9		- public function testSomething()
10		- {
11		- $o = new CoveredClass;
12		- $o->publicMethod();
13		- }
	6	+ /**
	7	+ * @covers CoveredClass::<!protected>
	8	+ */
	9	+ public function testSomething()
	10	+ {
	11	+ $o = new CoveredClass;
	12	+ $o->publicMethod();
	13	+ }
14	14	}

		@@ -5,64 +5,64 @@
		block discarded – undo
5	5
6	6	class BankAccountTest extends TestCase
7	7	{
8		- protected $ba;
	8	+ protected $ba;
9	9
10		- protected function setUp()
11		- {
12		- $this->ba = new BankAccount;
13		- }
	10	+ protected function setUp()
	11	+ {
	12	+ $this->ba = new BankAccount;
	13	+ }
14	14
15		- /**
16		- * @covers BankAccount::getBalance
17		- */
18		- public function testBalanceIsInitiallyZero()
19		- {
20		- $this->assertEquals(0, $this->ba->getBalance());
21		- }
	15	+ /**
	16	+ * @covers BankAccount::getBalance
	17	+ */
	18	+ public function testBalanceIsInitiallyZero()
	19	+ {
	20	+ $this->assertEquals(0, $this->ba->getBalance());
	21	+ }
22	22
23		- /**
24		- * @covers BankAccount::withdrawMoney
25		- */
26		- public function testBalanceCannotBecomeNegative()
27		- {
28		- try {
29		- $this->ba->withdrawMoney(1);
30		- } catch (RuntimeException $e) {
31		- $this->assertEquals(0, $this->ba->getBalance());
	23	+ /**
	24	+ * @covers BankAccount::withdrawMoney
	25	+ */
	26	+ public function testBalanceCannotBecomeNegative()
	27	+ {
	28	+ try {
	29	+ $this->ba->withdrawMoney(1);
	30	+ } catch (RuntimeException $e) {
	31	+ $this->assertEquals(0, $this->ba->getBalance());
32	32
33		- return;
34		- }
	33	+ return;
	34	+ }
35	35
36		- $this->fail();
37		- }
	36	+ $this->fail();
	37	+ }
38	38
39		- /**
40		- * @covers BankAccount::depositMoney
41		- */
42		- public function testBalanceCannotBecomeNegative2()
43		- {
44		- try {
45		- $this->ba->depositMoney(-1);
46		- } catch (RuntimeException $e) {
47		- $this->assertEquals(0, $this->ba->getBalance());
	39	+ /**
	40	+ * @covers BankAccount::depositMoney
	41	+ */
	42	+ public function testBalanceCannotBecomeNegative2()
	43	+ {
	44	+ try {
	45	+ $this->ba->depositMoney(-1);
	46	+ } catch (RuntimeException $e) {
	47	+ $this->assertEquals(0, $this->ba->getBalance());
48	48
49		- return;
50		- }
	49	+ return;
	50	+ }
51	51
52		- $this->fail();
53		- }
	52	+ $this->fail();
	53	+ }
54	54
55		- /**
56		- * @covers BankAccount::getBalance
57		- * @covers BankAccount::depositMoney
58		- * @covers BankAccount::withdrawMoney
59		- */
60		- public function testDepositWithdrawMoney()
61		- {
62		- $this->assertEquals(0, $this->ba->getBalance());
63		- $this->ba->depositMoney(1);
64		- $this->assertEquals(1, $this->ba->getBalance());
65		- $this->ba->withdrawMoney(1);
66		- $this->assertEquals(0, $this->ba->getBalance());
67		- }
	55	+ /**
	56	+ * @covers BankAccount::getBalance
	57	+ * @covers BankAccount::depositMoney
	58	+ * @covers BankAccount::withdrawMoney
	59	+ */
	60	+ public function testDepositWithdrawMoney()
	61	+ {
	62	+ $this->assertEquals(0, $this->ba->getBalance());
	63	+ $this->ba->depositMoney(1);
	64	+ $this->assertEquals(1, $this->ba->getBalance());
	65	+ $this->ba->withdrawMoney(1);
	66	+ $this->assertEquals(0, $this->ba->getBalance());
	67	+ }
68	68	}

chillerlan / php-traits

Push — master ( 52755b...6c4366 )

Category

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +24 added lines, -24 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +51 added lines, -51 removed lines patch added patch discarded remove patch