| Total Complexity | 40 |
| Total Lines | 247 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like GenericGFPoly often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use GenericGFPoly, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 27 | final class GenericGFPoly{ |
||
| 28 | |||
| 29 | private array $coefficients; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * @param array $coefficients array coefficients as ints representing elements of GF(size), arranged |
||
| 33 | * from most significant (highest-power term) coefficient to least significant |
||
| 34 | * @param int|null $degree |
||
| 35 | * |
||
| 36 | * @throws \InvalidArgumentException if argument is null or empty, or if leading coefficient is 0 and this is not a |
||
| 37 | * constant polynomial (that is, it is not the monomial "0") |
||
| 38 | */ |
||
| 39 | public function __construct(array $coefficients, int $degree = null){ |
||
| 40 | $degree ??= 0; |
||
| 41 | |||
| 42 | if(empty($coefficients)){ |
||
| 43 | throw new InvalidArgumentException('arg $coefficients is empty'); |
||
| 44 | } |
||
| 45 | |||
| 46 | if($degree < 0){ |
||
| 47 | throw new InvalidArgumentException('negative degree'); |
||
| 48 | } |
||
| 49 | |||
| 50 | $coefficientsLength = count($coefficients); |
||
| 51 | |||
| 52 | // Leading term must be non-zero for anything except the constant polynomial "0" |
||
| 53 | $firstNonZero = 0; |
||
| 54 | |||
| 55 | while($firstNonZero < $coefficientsLength && $coefficients[$firstNonZero] === 0){ |
||
| 56 | $firstNonZero++; |
||
| 57 | } |
||
| 58 | |||
| 59 | if($firstNonZero === $coefficientsLength){ |
||
| 60 | $this->coefficients = [0]; |
||
| 61 | } |
||
| 62 | else{ |
||
| 63 | $this->coefficients = array_fill(0, $coefficientsLength - $firstNonZero + $degree, 0); |
||
| 64 | |||
| 65 | for($i = 0; $i < $coefficientsLength - $firstNonZero; $i++){ |
||
| 66 | $this->coefficients[$i] = $coefficients[$i + $firstNonZero]; |
||
| 67 | } |
||
| 68 | } |
||
| 69 | } |
||
| 70 | |||
| 71 | /** |
||
| 72 | * @return int $coefficient of x^degree term in this polynomial |
||
| 73 | */ |
||
| 74 | public function getCoefficient(int $degree):int{ |
||
| 75 | return $this->coefficients[count($this->coefficients) - 1 - $degree]; |
||
| 76 | } |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @return int[] |
||
| 80 | */ |
||
| 81 | public function getCoefficients():array{ |
||
| 82 | return $this->coefficients; |
||
| 83 | } |
||
| 84 | |||
| 85 | /** |
||
| 86 | * @return int $degree of this polynomial |
||
| 87 | */ |
||
| 88 | public function getDegree():int{ |
||
| 89 | return count($this->coefficients) - 1; |
||
| 90 | } |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @return bool true if this polynomial is the monomial "0" |
||
| 94 | */ |
||
| 95 | public function isZero():bool{ |
||
| 96 | return $this->coefficients[0] === 0; |
||
| 97 | } |
||
| 98 | |||
| 99 | /** |
||
| 100 | * @return int evaluation of this polynomial at a given point |
||
| 101 | */ |
||
| 102 | public function evaluateAt(int $a):int{ |
||
| 117 | } |
||
| 118 | |||
| 119 | /** |
||
| 120 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
| 121 | * |
||
| 122 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
| 123 | */ |
||
| 124 | public function multiply(GenericGFPoly $other):GenericGFPoly{ |
||
| 125 | |||
| 126 | if($this->isZero() || $other->isZero()){ |
||
| 127 | return new self([0]); |
||
| 128 | } |
||
| 129 | |||
| 130 | $product = array_fill(0, count($this->coefficients) + count($other->coefficients) - 1, 0); |
||
| 131 | |||
| 132 | foreach($this->coefficients as $i => $aCoeff){ |
||
| 133 | foreach($other->coefficients as $j => $bCoeff){ |
||
| 134 | $product[$i + $j] ^= GF256::multiply($aCoeff, $bCoeff); |
||
| 135 | } |
||
| 136 | } |
||
| 137 | |||
| 138 | return new self($product); |
||
| 139 | } |
||
| 140 | |||
| 141 | /** |
||
| 142 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
| 143 | * |
||
| 144 | * @return \chillerlan\QRCode\Common\GenericGFPoly[] [quotient, remainder] |
||
| 145 | */ |
||
| 146 | public function divide(GenericGFPoly $other):array{ |
||
| 147 | |||
| 148 | if($other->isZero()){ |
||
| 149 | throw new InvalidArgumentException('Division by 0'); |
||
| 150 | } |
||
| 151 | |||
| 152 | $quotient = new self([0]); |
||
| 153 | $remainder = clone $this; |
||
| 154 | |||
| 155 | $denominatorLeadingTerm = $other->getCoefficient($other->getDegree()); |
||
| 156 | $inverseDenominatorLeadingTerm = GF256::inverse($denominatorLeadingTerm); |
||
| 157 | |||
| 158 | while($remainder->getDegree() >= $other->getDegree() && !$remainder->isZero()){ |
||
| 159 | $scale = GF256::multiply($remainder->getCoefficient($remainder->getDegree()), $inverseDenominatorLeadingTerm); |
||
| 160 | $diff = $remainder->getDegree() - $other->getDegree(); |
||
| 161 | $quotient = $quotient->addOrSubtract(GF256::buildMonomial($diff, $scale)); |
||
| 162 | $remainder = $remainder->addOrSubtract($other->multiplyByMonomial($diff, $scale)); |
||
| 163 | } |
||
| 164 | |||
| 165 | return [$quotient, $remainder]; |
||
| 166 | |||
| 167 | } |
||
| 168 | |||
| 169 | /** |
||
| 170 | * @param int $scalar |
||
| 171 | * |
||
| 172 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
| 173 | */ |
||
| 174 | public function multiplyInt(int $scalar):GenericGFPoly{ |
||
| 191 | } |
||
| 192 | |||
| 193 | /** |
||
| 194 | * @param int $degree |
||
| 195 | * @param int $coefficient |
||
| 196 | * |
||
| 197 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
| 198 | */ |
||
| 199 | public function multiplyByMonomial(int $degree, int $coefficient):GenericGFPoly{ |
||
| 216 | } |
||
| 217 | |||
| 218 | /** |
||
| 219 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
| 220 | * |
||
| 221 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
| 222 | */ |
||
| 223 | public function mod(GenericGFPoly $other):GenericGFPoly{ |
||
| 224 | |||
| 225 | if(count($this->coefficients) - count($other->coefficients) < 0){ |
||
| 226 | return $this; |
||
| 227 | } |
||
| 228 | |||
| 229 | $ratio = GF256::log($this->coefficients[0]) - GF256::log($other->coefficients[0]); |
||
| 230 | |||
| 231 | foreach($other->coefficients as $i => $c){ |
||
| 232 | $this->coefficients[$i] ^= GF256::exp(GF256::log($c) + $ratio); |
||
| 233 | } |
||
| 234 | |||
| 235 | return (new self($this->coefficients))->mod($other); |
||
| 236 | } |
||
| 237 | |||
| 238 | /** |
||
| 239 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
| 240 | * |
||
| 241 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
| 242 | */ |
||
| 243 | public function addOrSubtract(GenericGFPoly $other):GenericGFPoly{ |
||
| 274 | } |
||
| 275 | |||
| 276 | } |
||
| 277 |