Total Complexity | 40 |
Total Lines | 247 |
Duplicated Lines | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Complex classes like GenericGFPoly often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use GenericGFPoly, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
29 | final class GenericGFPoly{ |
||
30 | |||
31 | private array $coefficients; |
||
32 | |||
33 | /** |
||
34 | * @param array|null $coefficients array coefficients as ints representing elements of GF(size), arranged |
||
35 | * from most significant (highest-power term) coefficient to least significant |
||
36 | * @param int|null $degree |
||
37 | * |
||
38 | * @throws \InvalidArgumentException if argument is null or empty, or if leading coefficient is 0 and this is not a |
||
39 | * constant polynomial (that is, it is not the monomial "0") |
||
40 | */ |
||
41 | public function __construct(array $coefficients, int $degree = null){ |
||
42 | $degree ??= 0; |
||
43 | |||
44 | if(empty($coefficients)){ |
||
45 | throw new InvalidArgumentException('arg $coefficients is empty'); |
||
46 | } |
||
47 | |||
48 | if($degree < 0){ |
||
49 | throw new InvalidArgumentException('negative degree'); |
||
50 | } |
||
51 | |||
52 | $coefficientsLength = count($coefficients); |
||
53 | |||
54 | // Leading term must be non-zero for anything except the constant polynomial "0" |
||
55 | $firstNonZero = 0; |
||
56 | |||
57 | while($firstNonZero < $coefficientsLength && $coefficients[$firstNonZero] === 0){ |
||
58 | $firstNonZero++; |
||
59 | } |
||
60 | |||
61 | if($firstNonZero === $coefficientsLength){ |
||
62 | $this->coefficients = [0]; |
||
63 | } |
||
64 | else{ |
||
65 | $this->coefficients = array_fill(0, $coefficientsLength - $firstNonZero + $degree, 0); |
||
66 | |||
67 | for($i = 0; $i < $coefficientsLength - $firstNonZero; $i++){ |
||
68 | $this->coefficients[$i] = $coefficients[$i + $firstNonZero]; |
||
69 | } |
||
70 | } |
||
71 | } |
||
72 | |||
73 | /** |
||
74 | * @return int $coefficient of x^degree term in this polynomial |
||
75 | */ |
||
76 | public function getCoefficient(int $degree):int{ |
||
77 | return $this->coefficients[count($this->coefficients) - 1 - $degree]; |
||
78 | } |
||
79 | |||
80 | /** |
||
81 | * @return int[] |
||
82 | */ |
||
83 | public function getCoefficients():array{ |
||
84 | return $this->coefficients; |
||
85 | } |
||
86 | |||
87 | /** |
||
88 | * @return int $degree of this polynomial |
||
89 | */ |
||
90 | public function getDegree():int{ |
||
91 | return count($this->coefficients) - 1; |
||
92 | } |
||
93 | |||
94 | /** |
||
95 | * @return bool true if this polynomial is the monomial "0" |
||
96 | */ |
||
97 | public function isZero():bool{ |
||
98 | return $this->coefficients[0] === 0; |
||
99 | } |
||
100 | |||
101 | /** |
||
102 | * @return int evaluation of this polynomial at a given point |
||
103 | */ |
||
104 | public function evaluateAt(int $a):int{ |
||
119 | } |
||
120 | |||
121 | /** |
||
122 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
123 | * |
||
124 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
125 | */ |
||
126 | public function multiply(GenericGFPoly $other):GenericGFPoly{ |
||
127 | |||
128 | if($this->isZero() || $other->isZero()){ |
||
129 | return new self([0]); |
||
130 | } |
||
131 | |||
132 | $product = array_fill(0, count($this->coefficients) + count($other->coefficients) - 1, 0); |
||
133 | |||
134 | foreach($this->coefficients as $i => $aCoeff){ |
||
135 | foreach($other->coefficients as $j => $bCoeff){ |
||
136 | $product[$i + $j] ^= GF256::multiply($aCoeff, $bCoeff); |
||
137 | } |
||
138 | } |
||
139 | |||
140 | return new self($product); |
||
141 | } |
||
142 | |||
143 | /** |
||
144 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
145 | * |
||
146 | * @return \chillerlan\QRCode\Common\GenericGFPoly[] [quotient, remainder] |
||
147 | */ |
||
148 | public function divide(GenericGFPoly $other):array{ |
||
149 | |||
150 | if($other->isZero()){ |
||
151 | throw new InvalidArgumentException('Division by 0'); |
||
152 | } |
||
153 | |||
154 | $quotient = new self([0]); |
||
155 | $remainder = clone $this; |
||
156 | |||
157 | $denominatorLeadingTerm = $other->getCoefficient($other->getDegree()); |
||
158 | $inverseDenominatorLeadingTerm = GF256::inverse($denominatorLeadingTerm); |
||
159 | |||
160 | while($remainder->getDegree() >= $other->getDegree() && !$remainder->isZero()){ |
||
161 | $scale = GF256::multiply($remainder->getCoefficient($remainder->getDegree()), $inverseDenominatorLeadingTerm); |
||
162 | $diff = $remainder->getDegree() - $other->getDegree(); |
||
163 | $quotient = $quotient->addOrSubtract(GF256::buildMonomial($diff, $scale)); |
||
164 | $remainder = $remainder->addOrSubtract($other->multiplyByMonomial($diff, $scale)); |
||
165 | } |
||
166 | |||
167 | return [$quotient, $remainder]; |
||
168 | |||
169 | } |
||
170 | |||
171 | /** |
||
172 | * @param int $scalar |
||
173 | * |
||
174 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
175 | */ |
||
176 | public function multiplyInt(int $scalar):GenericGFPoly{ |
||
193 | } |
||
194 | |||
195 | /** |
||
196 | * @param int $degree |
||
197 | * @param int $coefficient |
||
198 | * |
||
199 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
200 | */ |
||
201 | public function multiplyByMonomial(int $degree, int $coefficient):GenericGFPoly{ |
||
218 | } |
||
219 | |||
220 | /** |
||
221 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
222 | * |
||
223 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
224 | */ |
||
225 | public function mod(GenericGFPoly $other):GenericGFPoly{ |
||
226 | |||
227 | if(count($this->coefficients) - count($other->coefficients) < 0){ |
||
228 | return $this; |
||
229 | } |
||
230 | |||
231 | $ratio = GF256::log($this->coefficients[0]) - GF256::log($other->coefficients[0]); |
||
232 | |||
233 | foreach($other->coefficients as $i => $c){ |
||
234 | $this->coefficients[$i] ^= GF256::exp(GF256::log($c) + $ratio); |
||
235 | } |
||
236 | |||
237 | return (new self($this->coefficients))->mod($other); |
||
238 | } |
||
239 | |||
240 | /** |
||
241 | * @param \chillerlan\QRCode\Common\GenericGFPoly $other |
||
242 | * |
||
243 | * @return \chillerlan\QRCode\Common\GenericGFPoly |
||
244 | */ |
||
245 | public function addOrSubtract(GenericGFPoly $other):GenericGFPoly{ |
||
276 | } |
||
277 | |||
278 | } |
||
279 |