chillerlan /
php-httpinterface
| Conditions | 13 |
| Paths | 10 |
| Total Lines | 35 |
| Code Lines | 20 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 49 | public static function cleanParams(iterable $params, int $bool_cast = null, bool $remove_empty = null):array{ |
||
| 50 | $p = []; |
||
| 51 | $bool_cast = $bool_cast ?? self::BOOLEANS_AS_BOOL; |
||
| 52 | $remove_empty = $remove_empty ?? true; |
||
| 53 | |||
| 54 | foreach($params as $key => $value){ |
||
| 55 | |||
| 56 | if(is_bool($value)){ |
||
| 57 | |||
| 58 | if($bool_cast === self::BOOLEANS_AS_BOOL){ |
||
| 59 | $p[$key] = $value; |
||
| 60 | } |
||
| 61 | elseif($bool_cast === self::BOOLEANS_AS_INT){ |
||
| 62 | $p[$key] = (int)$value; |
||
| 63 | } |
||
| 64 | elseif($bool_cast === self::BOOLEANS_AS_STRING){ |
||
| 65 | $p[$key] = $value ? 'true' : 'false'; |
||
| 66 | } |
||
| 67 | elseif($bool_cast === self::BOOLEANS_AS_INT_STRING){ |
||
| 68 | $p[$key] = (string)(int)$value; |
||
| 69 | } |
||
| 70 | |||
| 71 | } |
||
| 72 | elseif(is_iterable($value)){ |
||
| 73 | $p[$key] = call_user_func_array(__METHOD__, [$value, $bool_cast, $remove_empty]); |
||
| 74 | } |
||
| 75 | elseif($remove_empty === true && ($value === null || (!is_numeric($value) && empty($value)))){ |
||
| 76 | continue; |
||
| 77 | } |
||
| 78 | else{ |
||
| 79 | $p[$key] = $value; |
||
| 80 | } |
||
| 81 | } |
||
| 82 | |||
| 83 | return $p; |
||
| 84 | } |
||
| 164 |
Loading history...