Postgres::onConflictUpdate() - Code Metrics - Inspection of ":octocat:" - chillerlan/php-database - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 97a528...895061 )

by smiley

created 2018-01-29 19:14 UTC

Postgres::onConflictUpdate() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
c	0
b	0
f	0
rs	9.6666
cc	2
eloc	5
nc	2
nop	1

<?php
/**
 * Class Postgres
 *
 * @filesource   Postgres.php
 * @created      11.01.2018
 * @package      chillerlan\Database\Dialects
 * @author       Smiley <[email protected]>
 * @copyright    2018 Smiley
 * @license      MIT
 */

namespace chillerlan\Database\Dialects;

use chillerlan\Database\Query\QueryException;

class Postgres extends DialectAbstract{

	protected $quotes = ['"', '"'];

	/** @inheritdoc */
	public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby, array $orderby):array{
		$sql = ['SELECT'];

		if($distinct){
			$sql[] = 'DISTINCT';
		}

		!empty($cols)
			? $sql[] = implode(', ', $cols)
			: $sql[] = '*';

		$sql[] = 'FROM';
		$sql[] = implode(', ', $from);
		$sql[] = $where;

		if(!empty($groupby)){
			$sql[] = 'GROUP BY';
			$sql[] = implode(', ', $groupby);
		}

		if(!empty($orderby)){
			$sql[] = 'ORDER BY';
			$sql[] = implode(', ', $orderby);
		}

		if($offset !== null){
			$sql[] = 'OFFSET ?';
		}

		if($limit !== null){
			$sql[] = 'LIMIT ?';
		}

		return $sql;
	}

	/**
	 * @link https://www.postgresql.org/docs/9.5/static/sql-insert.html#SQL-ON-CONFLICT
	 *
	 * @inheritdoc
	 */
	public function insert(string $table, array $fields, string $onConflict = null, string $conflictTarget = null):array{
		$sql = parent::insert($table, $fields);

		if(in_array($onConflict, ['IGNORE', 'REPLACE'], true)){

			if(empty($conflictTarget)){
				throw new QueryException('postgres insert on conflict: no conflict target given');
			}

			$sql[] =  'ON CONFLICT ('.$this->quote($conflictTarget).') DO';

			switch($onConflict){
				case 'IGNORE':
					$sql[] = 'NOTHING';
					break;
				case 'REPLACE':
					$sql[] = $this->onConflictUpdate($fields);
					break;
			}

		}

		return $sql;
	}

	/**
	 * @param array $fields
	 *
	 * @return string
	 */
	protected function onConflictUpdate(array $fields):string {
		$onConflictUpdate = [];

		foreach($fields as $f){
			$onConflictUpdate[] = $this->quote($f).' = EXCLUDED.'.$this->quote($f);
		}

		return 'UPDATE SET '.implode(', ', $onConflictUpdate);
	}

	/** @inheritdoc */
	public function createDatabase(string $dbname, bool $ifNotExists = null, string $collate = null):array{
		$sql = ['CREATE DATABASE'];
		$sql[] = $this->quote($dbname);

		if($collate){
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$charset = explode(',', $collate, 3);

			$count = count($charset);

			if($count > 0){
				$sql[] = 'ENCODING \''.strtoupper($charset[0]).'\'';
			}

			if($count > 1){
				$sql[] = 'LC_COLLATE=\''.$charset[1].'\'';
			}

			if($count > 2){
				$sql[] = 'LC_CTYPE=\''.$charset[2].'\'';
			}

		}

		return $sql;
	}

	/** @inheritdoc */
	public function fieldspec(string $name, string $type, $length = null, string $attribute = null, string $collation = null, bool $isNull = null, string $defaultType = null, $defaultValue = null, string $extra = null):string{
		$name = trim($name);
		$type = strtoupper(trim($type));

		$field = [$this->quote($name)];

		$type_translation = [
			'TINYINT'    => 'SMALLINT',
			'MEDIUMINT'  => 'INT',
			'DOUBLE'     => 'DOUBLE PRECISION',
			'TINYTEXT'   => 'VARCHAR(255)',
			'DATETIME'   => 'TIMESTAMP',
			'IMAGE'      => 'BLOB',
			'MEDIUMTEXT' => 'TEXT',
			'LONGTEXT'   => 'TEXT',
		][$type] ?? $type;

		if((is_int($length) || is_string($length) && count(explode(',', $length)) === 2)

		   && in_array($type, ['BIT', 'VARBIT', 'CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC', 'TIME', 'TIMESTAMP', 'INTERVAL'], true)){
			$field[] = $type_translation.'('.$length.')';
		}
		else{
			$field[] = $type_translation;
		}

		if($collation && in_array($type, ['TINYTEXT', 'TEXT', 'MEDIUMTEXT', 'LONGTEXT', 'VARCHAR', 'CHAR'], true)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		   && !in_array(strtolower($collation), ['utf8'], true)){
			$field[] = 'COLLATE '.$collation;
		}

		if($isNull !== true){
			$field[] = 'NOT NULL';
		}

		if($attribute){
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$field[] = strtoupper($attribute);
		}

		$defaultType = strtoupper($defaultType);

		if($defaultType === 'USER_DEFINED'){

			switch(true){
				case $type === 'TIMESTAMP' && intval($defaultValue) === 0:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
					$field[] = 'DEFAULT 0';
					break;
				case $type === 'BIT' || $type === 'VARBIT':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
					$field[] = 'DEFAULT b\''.preg_replace('/[^01]/', '0', $defaultValue).'\'';
					break;
				case $type === 'BOOLEAN':
					$field[] = 'DEFAULT '.preg_match('/^1|T|TRUE|YES$/i', $defaultValue) ? 'TRUE' : 'FALSE';
					break;
				case strtoupper($defaultValue) === 'NULL' && $isNull === true:

					$field[] = 'DEFAULT NULL';
					break;
				default:
					$field[] = 'DEFAULT \''.$defaultValue.'\'';
			}

		}
		elseif($defaultType === 'CURRENT_TIMESTAMP'){
			$field[] = 'DEFAULT CURRENT_TIMESTAMP';
		}
		elseif($defaultType === 'NULL' && $isNull === true){
			$field[] = 'DEFAULT NULL';
		}

		if($extra){
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$field[] = $extra;
		}

		return implode(' ', $field);
	}

	/** @inheritdoc */
	public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array{
		$sql[] = 'CREATE';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

		if($temp){
			$sql[] = 'TEMPORARY';
		}

		$sql[] = 'TABLE';

		if($ifNotExists){
			$sql[] = 'IF NOT EXISTS';
		}

		$n = explode('.', $table);

		$sql[] = $this->quote($n[count($n) - 1]);

		if(!empty($cols)){

			$sql[] = ' (';
			$sql[] = implode(', ', $cols);

			if($primaryKey){
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
				$sql[] = ','.'PRIMARY KEY ('.$this->quote($primaryKey).')';
			}

			$sql[] = ')';
		}

		return $sql;
	}

	/** @inheritdoc */
	public function showDatabases():array{
		/** @noinspection SqlResolve */
		return ['SELECT datname AS "Database" FROM pg_database'];
	}

	/** @inheritdoc */
	public function showTables(string $database = null, string $pattern = null, string $where = null):array{
		/** @noinspection SqlResolve */
		return ['SELECT tablename FROM pg_catalog.pg_tables WHERE schemaname != \'pg_catalog\'AND schemaname != \'information_schema\' '];
	}

	/**
	 * @link https://stackoverflow.com/a/16154183
	 *
	 * @param string $table
	 *
	 * @return array
	 */
	public function showCreateTable(string $table):array{

		/** @noinspection SqlResolve */
		$def = $this->db->prepared('SELECT
				a.attnum AS "id",
				a.attname AS "name",
				pg_catalog.format_type(a.atttypid, a.atttypmod) AS "type",
				CASE WHEN a.attnotnull = TRUE
					THEN \'NOT NULL\'
				ELSE \'\' END AS "isnull",
				CASE WHEN (
					SELECT substring(pg_catalog.pg_get_expr(d.adbin, d.adrelid) FOR 128)
					FROM pg_catalog.pg_attrdef d
					WHERE
						d.adrelid = a.attrelid
						AND d.adnum = a.attnum
						AND a.atthasdef
				) IS NOT NULL
					THEN \'DEFAULT \' || (
						SELECT substring(pg_catalog.pg_get_expr(d.adbin, d.adrelid) FOR 128)
						FROM pg_catalog.pg_attrdef d
						WHERE
							d.adrelid = a.attrelid
							AND d.adnum = a.attnum
							AND a.atthasdef
					)
				ELSE \'\' END AS "default",
				(
					SELECT collation_name
					FROM information_schema.columns
					WHERE
						columns.table_name = b.relname
						AND columns.column_name = a.attname
				) AS "collation",
				(
					SELECT c.relname
					FROM pg_catalog.pg_class AS c, pg_attribute AS at, pg_catalog.pg_index AS i, pg_catalog.pg_class c2
					WHERE
						c.relkind = \'i\'
						AND at.attrelid = c.oid
						AND i.indexrelid = c.oid
						AND i.indrelid = c2.oid
						AND c2.relname = b.relname
						AND at.attnum = a.attnum
				) AS "index"
			FROM
				pg_catalog.pg_attribute AS a
				INNER JOIN
				(
					SELECT
						c.oid,
						n.nspname,
						c.relname
					FROM pg_catalog.pg_class AS c, pg_catalog.pg_namespace AS n
					WHERE
						pg_catalog.pg_table_is_visible(c.oid)
						AND n.oid = c.relnamespace
						AND c.relname = ?
					ORDER BY 2, 3) b
					ON a.attrelid = b.oid
				INNER JOIN
				(
					SELECT a.attrelid
					FROM pg_catalog.pg_attribute a
					WHERE
						a.attnum > 0
						AND NOT a.attisdropped
					GROUP BY a.attrelid
				) AS e
					ON a.attrelid = e.attrelid
			WHERE a.attnum > 0
			      AND NOT a.attisdropped
			ORDER BY a.attnum', [$table]);

		foreach($def as $field){
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
			// @todo primary key/indices
			$fields[] = $this->fieldspec(trim($field->name), trim($field->type), null, null, null, $field->isnull !== 'NOT NULL', null, null, trim($field->default));
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		}

		$create = sprintf(/** @lang text */'CREATE TABLE %1$s (%2$s)', $this->quote($table), PHP_EOL.implode(','.PHP_EOL, $fields).PHP_EOL);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

		$this->db->prepared('CREATE TEMPORARY TABLE IF NOT EXISTS TEMP$SQL_CREATE ("name" TEXT, "create" TEXT) ON COMMIT PRESERVE ROWS');
		$this->db->prepared('TRUNCATE TEMP$SQL_CREATE');
		$this->db->prepared('INSERT INTO TEMP$SQL_CREATE ("name", "create") VALUES (?, ?)', [$table, $create]);

		return ['SELECT "name" AS "Table", "create" AS "Create Table" FROM TEMP$SQL_CREATE'];
	}

}


1		<?php
2		/**
3		* Class Postgres
4		*
5		* @filesource Postgres.php
6		* @created 11.01.2018
7		* @package chillerlan\Database\Dialects
8		* @author Smiley <[email protected]>
9		* @copyright 2018 Smiley
10		* @license MIT
11		*/
12
13		namespace chillerlan\Database\Dialects;
14
15		use chillerlan\Database\Query\QueryException;
16
17		class Postgres extends DialectAbstract{
18
19		protected $quotes = ['"', '"'];
20
21		/** @inheritdoc */
22		public function select(array $cols, array $from, string $where = null, $limit = null, $offset = null, bool $distinct = null, array $groupby, array $orderby):array{
23		$sql = ['SELECT'];
24
25		if($distinct){
26		$sql[] = 'DISTINCT';
27		}
28
29		!empty($cols)
30		? $sql[] = implode(', ', $cols)
31		: $sql[] = '*';
32
33		$sql[] = 'FROM';
34		$sql[] = implode(', ', $from);
35		$sql[] = $where;
36
37		if(!empty($groupby)){
38		$sql[] = 'GROUP BY';
39		$sql[] = implode(', ', $groupby);
40		}
41
42		if(!empty($orderby)){
43		$sql[] = 'ORDER BY';
44		$sql[] = implode(', ', $orderby);
45		}
46
47		if($offset !== null){
48		$sql[] = 'OFFSET ?';
49		}
50
51		if($limit !== null){
52		$sql[] = 'LIMIT ?';
53		}
54
55		return $sql;
56		}
57
58		/**
59		* @link https://www.postgresql.org/docs/9.5/static/sql-insert.html#SQL-ON-CONFLICT
60		*
61		* @inheritdoc
62		*/
63		public function insert(string $table, array $fields, string $onConflict = null, string $conflictTarget = null):array{
64		$sql = parent::insert($table, $fields);
65
66		if(in_array($onConflict, ['IGNORE', 'REPLACE'], true)){
67
68		if(empty($conflictTarget)){
69		throw new QueryException('postgres insert on conflict: no conflict target given');
70		}
71
72		$sql[] = 'ON CONFLICT ('.$this->quote($conflictTarget).') DO';
73
74		switch($onConflict){
75		case 'IGNORE':
76		$sql[] = 'NOTHING';
77		break;
78		case 'REPLACE':
79		$sql[] = $this->onConflictUpdate($fields);
80		break;
81		}
82
83		}
84
85		return $sql;
86		}
87
88		/**
89		* @param array $fields
90		*
91		* @return string
92		*/
93		protected function onConflictUpdate(array $fields):string {
94		$onConflictUpdate = [];
95
96		foreach($fields as $f){
97		$onConflictUpdate[] = $this->quote($f).' = EXCLUDED.'.$this->quote($f);
98		}
99
100		return 'UPDATE SET '.implode(', ', $onConflictUpdate);
101		}
102
103		/** @inheritdoc */
104		public function createDatabase(string $dbname, bool $ifNotExists = null, string $collate = null):array{
105		$sql = ['CREATE DATABASE'];
106		$sql[] = $this->quote($dbname);
107
108		if($collate){
		0 ignored issues – show Bug Best Practice introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report The expression `$collate` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
109		$charset = explode(',', $collate, 3);
110
111		$count = count($charset);
112
113		if($count > 0){
114		$sql[] = 'ENCODING \''.strtoupper($charset[0]).'\'';
115		}
116
117		if($count > 1){
118		$sql[] = 'LC_COLLATE=\''.$charset[1].'\'';
119		}
120
121		if($count > 2){
122		$sql[] = 'LC_CTYPE=\''.$charset[2].'\'';
123		}
124
125		}
126
127		return $sql;
128		}
129
130		/** @inheritdoc */
131		public function fieldspec(string $name, string $type, $length = null, string $attribute = null, string $collation = null, bool $isNull = null, string $defaultType = null, $defaultValue = null, string $extra = null):string{
132		$name = trim($name);
133		$type = strtoupper(trim($type));
134
135		$field = [$this->quote($name)];
136
137		$type_translation = [
138		'TINYINT' => 'SMALLINT',
139		'MEDIUMINT' => 'INT',
140		'DOUBLE' => 'DOUBLE PRECISION',
141		'TINYTEXT' => 'VARCHAR(255)',
142		'DATETIME' => 'TIMESTAMP',
143		'IMAGE' => 'BLOB',
144		'MEDIUMTEXT' => 'TEXT',
145		'LONGTEXT' => 'TEXT',
146		][$type] ?? $type;
147
148	View Code Duplication	if((is_int($length) \|\| is_string($length) && count(explode(',', $length)) === 2)
		0 ignored issues – show Duplication introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
149		&& in_array($type, ['BIT', 'VARBIT', 'CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC', 'TIME', 'TIMESTAMP', 'INTERVAL'], true)){
150		$field[] = $type_translation.'('.$length.')';
151		}
152		else{
153		$field[] = $type_translation;
154		}
155
156		if($collation && in_array($type, ['TINYTEXT', 'TEXT', 'MEDIUMTEXT', 'LONGTEXT', 'VARCHAR', 'CHAR'], true)
		0 ignored issues – show Bug Best Practice introduced 2017-06-16 01:20 UTC by Report Bug Copy Issue Report The expression `$collation` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
157		&& !in_array(strtolower($collation), ['utf8'], true)){
158		$field[] = 'COLLATE '.$collation;
159		}
160
161		if($isNull !== true){
162		$field[] = 'NOT NULL';
163		}
164
165		if($attribute){
		0 ignored issues – show Bug Best Practice introduced 2017-06-16 01:20 UTC by Report Bug Copy Issue Report The expression `$attribute` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
166		$field[] = strtoupper($attribute);
167		}
168
169		$defaultType = strtoupper($defaultType);
170
171		if($defaultType === 'USER_DEFINED'){
172
173		switch(true){
174		case $type === 'TIMESTAMP' && intval($defaultValue) === 0:
		0 ignored issues – show Coding Style introduced 2017-06-16 01:20 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
175		$field[] = 'DEFAULT 0';
176		break;
177		case $type === 'BIT' \|\| $type === 'VARBIT':
		0 ignored issues – show Coding Style introduced 2017-06-16 01:20 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
178		$field[] = 'DEFAULT b\''.preg_replace('/[^01]/', '0', $defaultValue).'\'';
179		break;
180		case $type === 'BOOLEAN':
181		$field[] = 'DEFAULT '.preg_match('/^1\|T\|TRUE\|YES$/i', $defaultValue) ? 'TRUE' : 'FALSE';
182		break;
183	View Code Duplication	case strtoupper($defaultValue) === 'NULL' && $isNull === true:
		0 ignored issues – show Duplication introduced 2017-06-16 01:20 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
184		$field[] = 'DEFAULT NULL';
185		break;
186		default:
187		$field[] = 'DEFAULT \''.$defaultValue.'\'';
188		}
189
190		}
191		elseif($defaultType === 'CURRENT_TIMESTAMP'){
192		$field[] = 'DEFAULT CURRENT_TIMESTAMP';
193		}
194		elseif($defaultType === 'NULL' && $isNull === true){
195		$field[] = 'DEFAULT NULL';
196		}
197
198		if($extra){
		0 ignored issues – show Bug Best Practice introduced 2017-06-14 02:30 UTC by Report Bug Copy Issue Report The expression `$extra` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
199		$field[] = $extra;
200		}
201
202		return implode(' ', $field);
203		}
204
205		/** @inheritdoc */
206		public function createTable(string $table, array $cols, string $primaryKey = null, bool $ifNotExists, bool $temp, string $dir = null):array{
207		$sql[] = 'CREATE';
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report `$sql` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$sql = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
208
209		if($temp){
210		$sql[] = 'TEMPORARY';
211		}
212
213		$sql[] = 'TABLE';
214
215		if($ifNotExists){
216		$sql[] = 'IF NOT EXISTS';
217		}
218
219		$n = explode('.', $table);
220
221		$sql[] = $this->quote($n[count($n) - 1]);
222
223	View Code Duplication	if(!empty($cols)){
		0 ignored issues – show Duplication introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
224		$sql[] = ' (';
225		$sql[] = implode(', ', $cols);
226
227		if($primaryKey){
		0 ignored issues – show Bug Best Practice introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report The expression `$primaryKey` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
228		$sql[] = ','.'PRIMARY KEY ('.$this->quote($primaryKey).')';
229		}
230
231		$sql[] = ')';
232		}
233
234		return $sql;
235		}
236
237		/** @inheritdoc */
238		public function showDatabases():array{
239		/** @noinspection SqlResolve */
240		return ['SELECT datname AS "Database" FROM pg_database'];
241		}
242
243		/** @inheritdoc */
244		public function showTables(string $database = null, string $pattern = null, string $where = null):array{
245		/** @noinspection SqlResolve */
246		return ['SELECT tablename FROM pg_catalog.pg_tables WHERE schemaname != \'pg_catalog\'AND schemaname != \'information_schema\' '];
247		}
248
249		/**
250		* @link https://stackoverflow.com/a/16154183
251		*
252		* @param string $table
253		*
254		* @return array
255		*/
256		public function showCreateTable(string $table):array{
257
258		/** @noinspection SqlResolve */
259		$def = $this->db->prepared('SELECT
260		a.attnum AS "id",
261		a.attname AS "name",
262		pg_catalog.format_type(a.atttypid, a.atttypmod) AS "type",
263		CASE WHEN a.attnotnull = TRUE
264		THEN \'NOT NULL\'
265		ELSE \'\' END AS "isnull",
266		CASE WHEN (
267		SELECT substring(pg_catalog.pg_get_expr(d.adbin, d.adrelid) FOR 128)
268		FROM pg_catalog.pg_attrdef d
269		WHERE
270		d.adrelid = a.attrelid
271		AND d.adnum = a.attnum
272		AND a.atthasdef
273		) IS NOT NULL
274		THEN \'DEFAULT \' \|\| (
275		SELECT substring(pg_catalog.pg_get_expr(d.adbin, d.adrelid) FOR 128)
276		FROM pg_catalog.pg_attrdef d
277		WHERE
278		d.adrelid = a.attrelid
279		AND d.adnum = a.attnum
280		AND a.atthasdef
281		)
282		ELSE \'\' END AS "default",
283		(
284		SELECT collation_name
285		FROM information_schema.columns
286		WHERE
287		columns.table_name = b.relname
288		AND columns.column_name = a.attname
289		) AS "collation",
290		(
291		SELECT c.relname
292		FROM pg_catalog.pg_class AS c, pg_attribute AS at, pg_catalog.pg_index AS i, pg_catalog.pg_class c2
293		WHERE
294		c.relkind = \'i\'
295		AND at.attrelid = c.oid
296		AND i.indexrelid = c.oid
297		AND i.indrelid = c2.oid
298		AND c2.relname = b.relname
299		AND at.attnum = a.attnum
300		) AS "index"
301		FROM
302		pg_catalog.pg_attribute AS a
303		INNER JOIN
304		(
305		SELECT
306		c.oid,
307		n.nspname,
308		c.relname
309		FROM pg_catalog.pg_class AS c, pg_catalog.pg_namespace AS n
310		WHERE
311		pg_catalog.pg_table_is_visible(c.oid)
312		AND n.oid = c.relnamespace
313		AND c.relname = ?
314		ORDER BY 2, 3) b
315		ON a.attrelid = b.oid
316		INNER JOIN
317		(
318		SELECT a.attrelid
319		FROM pg_catalog.pg_attribute a
320		WHERE
321		a.attnum > 0
322		AND NOT a.attisdropped
323		GROUP BY a.attrelid
324		) AS e
325		ON a.attrelid = e.attrelid
326		WHERE a.attnum > 0
327		AND NOT a.attisdropped
328		ORDER BY a.attnum', [$table]);
329
330		foreach($def as $field){
		0 ignored issues – show Bug introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report The expression `$def` of type `object<chillerlan\Database\Result>\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
331		// @todo primary key/indices
332		$fields[] = $this->fieldspec(trim($field->name), trim($field->type), null, null, null, $field->isnull !== 'NOT NULL', null, null, trim($field->default));
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report `$fields` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$fields = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
333		}
334
335		$create = sprintf(/** @lang text */'CREATE TABLE %1$s (%2$s)', $this->quote($table), PHP_EOL.implode(','.PHP_EOL, $fields).PHP_EOL);
		0 ignored issues – show Bug introduced 2018-01-23 03:49 UTC by Report Bug Copy Issue Report The variable `$fields` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
336
337		$this->db->prepared('CREATE TEMPORARY TABLE IF NOT EXISTS TEMP$SQL_CREATE ("name" TEXT, "create" TEXT) ON COMMIT PRESERVE ROWS');
338		$this->db->prepared('TRUNCATE TEMP$SQL_CREATE');
339		$this->db->prepared('INSERT INTO TEMP$SQL_CREATE ("name", "create") VALUES (?, ?)', [$table, $create]);
340
341		return ['SELECT "name" AS "Table", "create" AS "Create Table" FROM TEMP$SQL_CREATE'];
342		}
343
344		}
345

chillerlan / php-database

Push — master ( 97a528...895061 )

Postgres::onConflictUpdate() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like