Completed
Push — master ( 466d49...06d08c )
by smiley
05:19
created
src/Query/Dialects/SQLite/CreateTable.php 3 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@
 block discarded – undo
12 12
 
13 13
 namespace chillerlan\Database\Query\Dialects\SQLite;
14 14
 
15
-use chillerlan\Database\Query\CreateTableInterface;
16 15
 use chillerlan\Database\Query\CreateTableAbstract;
16
+use chillerlan\Database\Query\CreateTableInterface;
17 17
 use chillerlan\Database\Query\QueryException;
18 18
 
19 19
 /**
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
 			if($this->primaryKey){
53 53
 				$sql .=','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey)
54
-				       .(in_array($this->dir, ['ASC', 'DESC']) ? $this->dir : '').')';
54
+					   .(in_array($this->dir, ['ASC', 'DESC']) ? $this->dir : '').')';
55 55
 			}
56 56
 
57 57
 			$sql .= PHP_EOL.')';
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
 
89 89
 		if(is_int($length)&& in_array($type, ['CHAR', 'NCHAR','VARCHAR', 'NVARCHAR', 'CHARACTER'])
90
-		    || is_string($length) && count(explode(',', $length)) === 2 && $type === 'DECIMAL'){
90
+			|| is_string($length) && count(explode(',', $length)) === 2 && $type === 'DECIMAL'){
91 91
 			$field[] = $type_translation.'('. $length . ')';
92 92
 		}
93 93
 		else{
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,13 +44,13 @@  discard block
 block discarded – undo
44 44
 
45 45
 		$n = explode('.', $this->name);
46 46
 
47
-		$sql .= $this->quote($n[count($n)-1]);
47
+		$sql .= $this->quote($n[count($n) - 1]);
48 48
 
49 49
 		if(!empty($this->cols)){
50 50
 			$sql .= ' ('.PHP_EOL."\t".implode(','.PHP_EOL."\t", $this->cols);
51 51
 
52 52
 			if($this->primaryKey){
53
-				$sql .=','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey)
53
+				$sql .= ','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey)
54 54
 				       .(in_array($this->dir, ['ASC', 'DESC']) ? $this->dir : '').')';
55 55
 			}
56 56
 
@@ -86,9 +86,9 @@  discard block
 block discarded – undo
86 86
 
87 87
 
88 88
 
89
-		if(is_int($length)&& in_array($type, ['CHAR', 'NCHAR','VARCHAR', 'NVARCHAR', 'CHARACTER'])
89
+		if(is_int($length) && in_array($type, ['CHAR', 'NCHAR', 'VARCHAR', 'NVARCHAR', 'CHARACTER'])
90 90
 		    || is_string($length) && count(explode(',', $length)) === 2 && $type === 'DECIMAL'){
91
-			$field[] = $type_translation.'('. $length . ')';
91
+			$field[] = $type_translation.'('.$length.')';
92 92
 		}
93 93
 		else{
94 94
 			$field[] = $type_translation;
Please login to merge, or discard this patch.
src/Query/SelectAbstract.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 
50 50
 	/**
51 51
 	 * @param      $expr1
52
-	 * @param null $expr2
52
+	 * @param string|null $expr2
53 53
 	 * @param null $func
54 54
 	 *
55 55
 	 * @return void
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 			if(is_string($k)){
119 119
 				is_array($ref)
120 120
 					? $this->addColumn($ref[0], $k, $ref[1] ?? null)
121
-					: $this->addColumn($ref ,$k);
121
+					: $this->addColumn($ref, $k);
122 122
 			}
123 123
 			else{
124 124
 				is_array($ref)
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 		$from = $this->quote($table);
141 141
 
142 142
 		if($ref){
143
-			$from = sprintf('%s AS %s', $this->quote($ref), $this->quote($table));// @todo: index hint
143
+			$from = sprintf('%s AS %s', $this->quote($ref), $this->quote($table)); // @todo: index hint
144 144
 		}
145 145
 
146 146
 		$this->from[$ref ?? $table] = $from;
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
 					$dir = strtoupper($expression[0]);
212 212
 
213 213
 					if(in_array($dir, ['ASC', 'DESC'])){
214
-						$this->orderby[] =  isset($expression[1]) ? strtoupper($expression[1]).'('.$this->quote($alias).') '.$dir : $dir;
214
+						$this->orderby[] = isset($expression[1]) ? strtoupper($expression[1]).'('.$this->quote($alias).') '.$dir : $dir;
215 215
 					}
216 216
 
217 217
 				}
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 					$dir = strtoupper($expression);
220 220
 
221 221
 					if(in_array($dir, ['ASC', 'DESC'])){
222
-						$this->orderby[] =  $this->quote($alias).' '.$dir;
222
+						$this->orderby[] = $this->quote($alias).' '.$dir;
223 223
 					}
224 224
 
225 225
 				}
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 		$sql  = 'SELECT ';
266 266
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
267 267
 		$sql .= 'COUNT(*) AS  '.$this->quote('count');
268
-		$sql .= 'FROM '.implode($glue , $this->from);
268
+		$sql .= 'FROM '.implode($glue, $this->from);
269 269
 		$sql .= $this->_getWhere();
270 270
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
271 271
 
Please login to merge, or discard this patch.
src/Query/Dialects/MySQL/Select.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,8 +36,8 @@
 block discarded – undo
36 36
 
37 37
 		$sql  = 'SELECT ';
38 38
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
39
-		$sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
40
-		$sql .= 'FROM '.implode($glue , $this->from);
39
+		$sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
40
+		$sql .= 'FROM '.implode($glue, $this->from);
41 41
 		$sql .= $this->_getWhere();
42 42
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
43 43
 		$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';
Please login to merge, or discard this patch.
src/Query/Dialects/Postgres/CreateTable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,13 +33,13 @@  discard block
 block discarded – undo
33 33
 
34 34
 		$n = explode('.', $this->name);
35 35
 
36
-		$sql .= $this->quote($n[count($n)-1]);
36
+		$sql .= $this->quote($n[count($n) - 1]);
37 37
 
38 38
 		if(!empty($this->cols)){
39 39
 			$sql .= ' ('.PHP_EOL."\t".implode(','.PHP_EOL."\t", $this->cols);
40 40
 
41 41
 			if($this->primaryKey){
42
-				$sql .=','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey).')';
42
+				$sql .= ','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey).')';
43 43
 			}
44 44
 
45 45
 			$sql .= PHP_EOL.')';
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
 		if((is_int($length) || is_string($length) && count(explode(',', $length)) === 2)
85 85
 		   && in_array($type, ['BIT', 'VARBIT', 'CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC', 'TIME', 'TIMESTAMP', 'INTERVAL'])){
86
-			$field[] = $type_translation.'('. $length . ')';
86
+			$field[] = $type_translation.'('.$length.')';
87 87
 		}
88 88
 		else{
89 89
 			$field[] = $type_translation;
Please login to merge, or discard this patch.
src/Query/Dialects/Firebird/CreateTable.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
 		$n = explode('.', $this->name);
34 34
 
35
-		$sql .= $this->quote($n[count($n)-1]);
35
+		$sql .= $this->quote($n[count($n) - 1]);
36 36
 
37 37
 		$cols = [];
38 38
 
@@ -98,14 +98,14 @@  discard block
 block discarded – undo
98 98
 			$field[] = $type_translation;
99 99
 		}
100 100
 		else if(in_array($type, ['CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC'])){
101
-			$field[] = $type.'('. $length . ')';
101
+			$field[] = $type.'('.$length.')';
102 102
 		}
103 103
 		else{
104 104
 			$field[] = $type;
105 105
 		}
106 106
 
107 107
 
108
-		if($isNull ===  false && !in_array($type, ['DATE', 'TIME', 'TIMESTAMP'])){
108
+		if($isNull === false && !in_array($type, ['DATE', 'TIME', 'TIMESTAMP'])){
109 109
 			$field[] = 'NOT NULL';
110 110
 		}
111 111
 
Please login to merge, or discard this patch.
src/Query/Dialects/Postgres/Select.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,8 +36,8 @@
 block discarded – undo
36 36
 
37 37
 		$sql  = 'SELECT ';
38 38
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
39
-		$sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
40
-		$sql .= 'FROM '.implode($glue , $this->from);
39
+		$sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
40
+		$sql .= 'FROM '.implode($glue, $this->from);
41 41
 		$sql .= $this->_getWhere();
42 42
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
43 43
 		$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';
Please login to merge, or discard this patch.
src/Query/Dialects/SQLite/Select.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,8 +36,8 @@
 block discarded – undo
36 36
 
37 37
 		$sql  = 'SELECT ';
38 38
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
39
-		$sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
40
-		$sql .= 'FROM '.implode($glue , $this->from);
39
+		$sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
40
+		$sql .= 'FROM '.implode($glue, $this->from);
41 41
 		$sql .= $this->_getWhere();
42 42
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
43 43
 		$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';
Please login to merge, or discard this patch.
src/DBQuery.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,11 +14,11 @@
 block discarded – undo
14 14
 
15 15
 use chillerlan\Database\Drivers\DBDriverInterface;
16 16
 use chillerlan\Database\Query\AlterInterface;
17
+use chillerlan\Database\Query\CreateDatabaseInterface;
17 18
 use chillerlan\Database\Query\CreateInterface;
19
+use chillerlan\Database\Query\CreateTableInterface;
18 20
 use chillerlan\Database\Query\DropInterface;
19 21
 use chillerlan\Database\Query\StatementAbstract;
20
-use chillerlan\Database\Query\CreateDatabaseInterface;
21
-use chillerlan\Database\Query\CreateTableInterface;
22 22
 
23 23
 /**
24 24
  * @property \chillerlan\Database\Query\SelectInterface $select
Please login to merge, or discard this patch.
tests/Query/QueryTestAbstract.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -113,9 +113,9 @@  discard block
 block discarded – undo
113 113
 		$insert
114 114
 			->into(self::TEST_TABLENAME)
115 115
 			->values([
116
-				['id' => 1, 'hash' => md5(1), 'data' => 'foo', 'value' => 123.456,    'active' => 0],
116
+				['id' => 1, 'hash' => md5(1), 'data' => 'foo', 'value' => 123.456, 'active' => 0],
117 117
 				['id' => 2, 'hash' => md5(2), 'data' => 'foo', 'value' => 123.456789, 'active' => 1],
118
-				['id' => 3, 'hash' => md5(3), 'data' => 'foo', 'value' => 123.456,    'active' => 0],
118
+				['id' => 3, 'hash' => md5(3), 'data' => 'foo', 'value' => 123.456, 'active' => 0],
119 119
 			])
120 120
 		;
121 121
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 		$select = $this->statement->select;
172 172
 		$select
173 173
 			->from([self::TEST_TABLENAME])
174
-			->where('id', [1,2,3], 'in')
174
+			->where('id', [1, 2, 3], 'in')
175 175
 			->orderBy(['hash' => ['desc', 'lower']]);
176 176
 #		print_r(PHP_EOL.$select->sql().PHP_EOL);
177 177
 		$result = $select->execute();
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 #		print_r(PHP_EOL.$update->sql().PHP_EOL);
214 214
 		$this->assertTrue($update->execute());
215 215
 
216
-		$r = $this->statement->select->from([self::TEST_TABLENAME])->where('id' ,1)->execute();
216
+		$r = $this->statement->select->from([self::TEST_TABLENAME])->where('id', 1)->execute();
217 217
 
218 218
 		$this->assertSame('bar', $r[0]->data);
219 219
 		$this->assertSame(42.42, (float)$r[0]->value);
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 		$this->assertTrue($delete->execute());
248 248
 
249 249
 		$r = $this->statement->select->from([self::TEST_TABLENAME])->execute();
250
-		$this->assertCount(3,  $r);
250
+		$this->assertCount(3, $r);
251 251
 	}
252 252
 
253 253
 	/**
Please login to merge, or discard this patch.