chillerlan\Database\Query\Dialects\Postgres\PostgresWhereTrait

Complexity

Total Complexity

15

Size/Duplication

Total Lines	79
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	_addWhere()	74	74	15

<?php
/**
 *
 * @filesource   PostgresWhereTrait.php
 * @created      12.06.2017
 * @package      chillerlan\Database\Query\Dialects\Postgres
 * @author       Smiley <smiley@chillerlan.net>
 * @copyright    2017 Smiley
 * @license      MIT
 */

namespace chillerlan\Database\Query\Dialects\Postgres;

use chillerlan\Database\Query\StatementInterface;
use chillerlan\Database\Query\Traits\WhereTrait;

/**
 * Trait PostgresWhereTrait
 */
trait PostgresWhereTrait{

This class seems to be duplicated in your project.

	use WhereTrait;

	protected function _addWhere($val1, $val2 = null, $operator = null, $bind = true, $join = 'AND'){
		$operator = strtoupper(trim($operator));
		$join = strtoupper(trim($join));

		$operators = [
			'=', '>=', '>', '<=', '<', '<>', '!=',
			'|', '&', '<<', '>>', '+', '-', '*', '/', '%', '^', '<=>', '~', '!', 'DIV', 'MOD',
			'IS', 'IS NOT', 'IN', 'NOT IN', 'LIKE', 'NOT LIKE', 'REGEXP', 'NOT REGEXP', 'BETWEEN', 'NOT BETWEEN', 'EXISTS'
		];

		if(in_array($operator, $operators, true)){
			$where = [$this->quote($val1)];

It seems like quote() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			$values = [];

			if(in_array($operator, ['IN', 'NOT IN'], true)){

				if(is_array($val2)){
					if($bind){
						$where[] = 'IN('.implode(',', array_fill(0, count($val2), '?')).')';
						$values = array_merge($values, $val2);
					}
					else{
						$where[] = 'IN('.implode(',', $val2).')'; // @todo: quote
					}
				}
				else if($val2 instanceof StatementInterface){
					$where[] = 'IN('.$val2->sql().')';
					$values = array_merge($values, $val2->bindValues());
				}

			}
			else if(in_array($operator, ['BETWEEN', 'NOT BETWEEN'], true)){

This if statement is empty and can be removed.

			}
			else{
				$where[] = $operator;

				if(is_null($val2)){
					$where[] = 'NULL';
				}
				else if(is_bool($val2)){
					$where[] = $val2 ? 'TRUE' : 'FALSE';
				}
				else if(in_array(strtolower($val2), ['null', 'false', 'true', 'unknown'])){
					$where[] = strtoupper($val2);
				}
				else if($val2 instanceof StatementInterface){
					$where[] = '('.$val2->sql().')';
					$values = array_merge($values, $val2->bindValues());
				}
				else{
					if($bind){
						$where[] = '?';
						$values[] = $val2;
					}
					else{
						if(!empty($val2)){
							$where[] = $this->quote($val2);

It seems like quote() must be provided by classes using this trait. How about adding it as abstract method to this trait?

						}
					}
				}

			}

			$this->bindValues = array_merge($this->bindValues, $values);

The property bindValues does not exist. Did you maybe forget to declare it?

			$this->where[] = [
				'join' => in_array($join, ['AND', 'OR', 'XOR']) ? $join : 'AND',
				'stmt' => implode(' ', $where),
			];

		}

		return $this;
	}

}