Inspection of ":octocat:" - chillerlan/php-database - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d508c6...ead087 )

by smiley

created 2017-06-16 01:17 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -83,7 +83,7 @@  discard block
 block discarded – undo
 			if(is_string($k)){
 				is_array($ref)
 					? $this->addColumn($ref[0], $k, $ref[1] ?? null)
-					: $this->addColumn($ref ,$k);
+					: $this->addColumn($ref, $k);
 			}
 			else{
 				is_array($ref)
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
 		$from = $this->quote($table);
 
 		if($ref){
-			$from = sprintf('%s AS %s', $this->quote($ref), $this->quote($table));// @todo: index hint
+			$from = sprintf('%s AS %s', $this->quote($ref), $this->quote($table)); // @todo: index hint
 		}
 
 		$this->from[$ref ?? $table] = $from;

Please login to merge, or discard this patch.

src/Query/InsertAbstract.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@
 block discarded – undo
 
 		$sql = 'INSERT ';
 		$sql .= 'INTO '.$this->quote($this->table);
-		$sql .=  ' ('.$this->quotes[0].implode($this->quotes[1].', '.$this->quotes[0], $fields).$this->quotes[1].')';
+		$sql .= ' ('.$this->quotes[0].implode($this->quotes[1].', '.$this->quotes[0], $fields).$this->quotes[1].')';
 		$sql .= ' VALUES ('.implode(',', array_fill(0, count($fields), '?')).')';
 
 		return $sql;

Please login to merge, or discard this patch.

src/Query/Dialects/MySQL/Select.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,8 +36,8 @@
 block discarded – undo
 
 		$sql  = 'SELECT ';
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
-		$sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
-		$sql .= 'FROM '.implode($glue , $this->from);
+		$sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
+		$sql .= 'FROM '.implode($glue, $this->from);
 		$sql .= $this->_getWhere();
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
 		$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';

Please login to merge, or discard this patch.

src/Query/Dialects/Postgres/Select.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,8 +36,8 @@
 block discarded – undo
 
 		$sql  = 'SELECT ';
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
-		$sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
-		$sql .= 'FROM '.implode($glue , $this->from);
+		$sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
+		$sql .= 'FROM '.implode($glue, $this->from);
 		$sql .= $this->_getWhere();
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
 		$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';

Please login to merge, or discard this patch.

src/Query/Dialects/Postgres/CreateTable.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,13 +33,13 @@  discard block
 block discarded – undo
 
 		$n = explode('.', $this->name);
 
-		$sql .= $this->quote($n[count($n)-1]);
+		$sql .= $this->quote($n[count($n) - 1]);
 
 		if(!empty($this->cols)){
 			$sql .= ' ('.PHP_EOL."\t".implode(','.PHP_EOL."\t", $this->cols);
 
 			if($this->primaryKey){
-				$sql .=','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey).')';
+				$sql .= ','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey).')';
 			}
 
 			$sql .= PHP_EOL.')';
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
 
 		if((is_int($length) || is_string($length) && count(explode(',', $length)) === 2)
 		   && in_array($type, ['BIT', 'VARBIT', 'CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC', 'TIME', 'TIMESTAMP', 'INTERVAL'])){
-			$field[] = $type_translation.'('. $length . ')';
+			$field[] = $type_translation.'('.$length.')';
 		}
 		else{
 			$field[] = $type_translation;

Please login to merge, or discard this patch.

src/Query/Dialects/Firebird/Select.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -43,8 +43,8 @@
 block discarded – undo
 		$sql  = 'SELECT ';
 		$sql .= $this->limit ? 'FIRST ? SKIP ? ' : '';
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
-		$sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
-		$sql .= !empty($this->from) ? 'FROM '.implode($glue , $this->from) : '';
+		$sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
+		$sql .= !empty($this->from) ? 'FROM '.implode($glue, $this->from) : '';
 		$sql .= $this->_getWhere();
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
 		$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';

Please login to merge, or discard this patch.

src/Query/Dialects/Firebird/CreateTable.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@  discard block
 block discarded – undo
 
 		$n = explode('.', $this->name);
 
-		$sql .= $this->quote($n[count($n)-1]);
+		$sql .= $this->quote($n[count($n) - 1]);
 
 		$cols = [];
 
@@ -98,14 +98,14 @@  discard block
 block discarded – undo
 			$field[] = $type_translation;
 		}
 		else if(in_array($type, ['CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC'])){
-			$field[] = $type.'('. $length . ')';
+			$field[] = $type.'('.$length.')';
 		}
 		else{
 			$field[] = $type;
 		}
 
 
-		if($isNull ===  false && !in_array($type, ['DATE', 'TIME', 'TIMESTAMP'])){
+		if($isNull === false && !in_array($type, ['DATE', 'TIME', 'TIMESTAMP'])){
 			$field[] = 'NOT NULL';
 		}
 

Please login to merge, or discard this patch.

src/Query/Dialects/SQLite/Select.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -37,8 +37,8 @@
 block discarded – undo
 
 		$sql  = 'SELECT ';
 		$sql .= $this->distinct ? 'DISTINCT ' : '';
-		$sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
-		$sql .= 'FROM '.implode($glue , $this->from);
+		$sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
+		$sql .= 'FROM '.implode($glue, $this->from);
 		$sql .= $this->_getWhere();
 		$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
 		$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';

Please login to merge, or discard this patch.

src/Query/Dialects/SQLite/CreateTable.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -44,13 +44,13 @@  discard block
 block discarded – undo
 
 		$n = explode('.', $this->name);
 
-		$sql .= $this->quote($n[count($n)-1]);
+		$sql .= $this->quote($n[count($n) - 1]);
 
 		if(!empty($this->cols)){
 			$sql .= ' ('.PHP_EOL."\t".implode(','.PHP_EOL."\t", $this->cols);
 
 			if($this->primaryKey){
-				$sql .=','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey)
+				$sql .= ','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey)
 				       .(in_array($this->dir, ['ASC', 'DESC']) ? $this->dir : '').')';
 			}
 
@@ -86,9 +86,9 @@  discard block
 block discarded – undo
 
 
 
-		if(is_int($length)&& in_array($type, ['CHAR', 'NCHAR','VARCHAR', 'NVARCHAR', 'CHARACTER'])
+		if(is_int($length) && in_array($type, ['CHAR', 'NCHAR', 'VARCHAR', 'NVARCHAR', 'CHARACTER'])
 		    || is_string($length) && count(explode(',', $length)) === 2 && $type === 'DECIMAL'){
-			$field[] = $type_translation.'('. $length . ')';
+			$field[] = $type_translation.'('.$length.')';
 		}
 		else{
 			$field[] = $type_translation;

Please login to merge, or discard this patch.

		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32
33	33	$n = explode('.', $this->name);
34	34
35		- $sql .= $this->quote($n[count($n)-1]);
	35	+ $sql .= $this->quote($n[count($n) - 1]);
36	36
37	37	$cols = [];
38	38
		@@ -98,14 +98,14 @@ discard block
		block discarded – undo
98	98	$field[] = $type_translation;
99	99	}
100	100	else if(in_array($type, ['CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC'])){
101		- $field[] = $type.'('. $length . ')';
	101	+ $field[] = $type.'('.$length.')';
102	102	}
103	103	else{
104	104	$field[] = $type;
105	105	}
106	106
107	107
108		- if($isNull === false && !in_array($type, ['DATE', 'TIME', 'TIMESTAMP'])){
	108	+ if($isNull === false && !in_array($type, ['DATE', 'TIME', 'TIMESTAMP'])){
109	109	$field[] = 'NOT NULL';
110	110	}
111	111

		@@ -44,13 +44,13 @@ discard block
		block discarded – undo
44	44
45	45	$n = explode('.', $this->name);
46	46
47		- $sql .= $this->quote($n[count($n)-1]);
	47	+ $sql .= $this->quote($n[count($n) - 1]);
48	48
49	49	if(!empty($this->cols)){
50	50	$sql .= ' ('.PHP_EOL."\t".implode(','.PHP_EOL."\t", $this->cols);
51	51
52	52	if($this->primaryKey){
53		- $sql .=','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey)
	53	+ $sql .= ','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey)
54	54	.(in_array($this->dir, ['ASC', 'DESC']) ? $this->dir : '').')';
55	55	}
56	56
		@@ -86,9 +86,9 @@ discard block
		block discarded – undo
86	86
87	87
88	88
89		- if(is_int($length)&& in_array($type, ['CHAR', 'NCHAR','VARCHAR', 'NVARCHAR', 'CHARACTER'])
	89	+ if(is_int($length) && in_array($type, ['CHAR', 'NCHAR', 'VARCHAR', 'NVARCHAR', 'CHARACTER'])
90	90	\|\| is_string($length) && count(explode(',', $length)) === 2 && $type === 'DECIMAL'){
91		- $field[] = $type_translation.'('. $length . ')';
	91	+ $field[] = $type_translation.'('.$length.')';
92	92	}
93	93	else{
94	94	$field[] = $type_translation;

		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	if(is_string($k)){
84	84	is_array($ref)
85	85	? $this->addColumn($ref[0], $k, $ref[1] ?? null)
86		- : $this->addColumn($ref ,$k);
	86	+ : $this->addColumn($ref, $k);
87	87	}
88	88	else{
89	89	is_array($ref)
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	$from = $this->quote($table);
106	106
107	107	if($ref){
108		- $from = sprintf('%s AS %s', $this->quote($ref), $this->quote($table));// @todo: index hint
	108	+ $from = sprintf('%s AS %s', $this->quote($ref), $this->quote($table)); // @todo: index hint
109	109	}
110	110
111	111	$this->from[$ref ?? $table] = $from;

		@@ -31,7 +31,7 @@
		block discarded – undo
31	31
32	32	$sql = 'INSERT ';
33	33	$sql .= 'INTO '.$this->quote($this->table);
34		- $sql .= ' ('.$this->quotes[0].implode($this->quotes[1].', '.$this->quotes[0], $fields).$this->quotes[1].')';
	34	+ $sql .= ' ('.$this->quotes[0].implode($this->quotes[1].', '.$this->quotes[0], $fields).$this->quotes[1].')';
35	35	$sql .= ' VALUES ('.implode(',', array_fill(0, count($fields), '?')).')';
36	36
37	37	return $sql;

		@@ -36,8 +36,8 @@
		block discarded – undo
36	36
37	37	$sql = 'SELECT ';
38	38	$sql .= $this->distinct ? 'DISTINCT ' : '';
39		- $sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
40		- $sql .= 'FROM '.implode($glue , $this->from);
	39	+ $sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
	40	+ $sql .= 'FROM '.implode($glue, $this->from);
41	41	$sql .= $this->_getWhere();
42	42	$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
43	43	$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';

		@@ -33,13 +33,13 @@ discard block
		block discarded – undo
33	33
34	34	$n = explode('.', $this->name);
35	35
36		- $sql .= $this->quote($n[count($n)-1]);
	36	+ $sql .= $this->quote($n[count($n) - 1]);
37	37
38	38	if(!empty($this->cols)){
39	39	$sql .= ' ('.PHP_EOL."\t".implode(','.PHP_EOL."\t", $this->cols);
40	40
41	41	if($this->primaryKey){
42		- $sql .=','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey).')';
	42	+ $sql .= ','.PHP_EOL."\t".'PRIMARY KEY ('.$this->quote($this->primaryKey).')';
43	43	}
44	44
45	45	$sql .= PHP_EOL.')';
		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83
84	84	if((is_int($length) \|\| is_string($length) && count(explode(',', $length)) === 2)
85	85	&& in_array($type, ['BIT', 'VARBIT', 'CHAR', 'VARCHAR', 'DECIMAL', 'NUMERIC', 'TIME', 'TIMESTAMP', 'INTERVAL'])){
86		- $field[] = $type_translation.'('. $length . ')';
	86	+ $field[] = $type_translation.'('.$length.')';
87	87	}
88	88	else{
89	89	$field[] = $type_translation;

		@@ -43,8 +43,8 @@
		block discarded – undo
43	43	$sql = 'SELECT ';
44	44	$sql .= $this->limit ? 'FIRST ? SKIP ? ' : '';
45	45	$sql .= $this->distinct ? 'DISTINCT ' : '';
46		- $sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
47		- $sql .= !empty($this->from) ? 'FROM '.implode($glue , $this->from) : '';
	46	+ $sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
	47	+ $sql .= !empty($this->from) ? 'FROM '.implode($glue, $this->from) : '';
48	48	$sql .= $this->_getWhere();
49	49	$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
50	50	$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';

		@@ -37,8 +37,8 @@
		block discarded – undo
37	37
38	38	$sql = 'SELECT ';
39	39	$sql .= $this->distinct ? 'DISTINCT ' : '';
40		- $sql .= !empty($this->cols) ? implode($glue , $this->cols).PHP_EOL : '* ';
41		- $sql .= 'FROM '.implode($glue , $this->from);
	40	+ $sql .= !empty($this->cols) ? implode($glue, $this->cols).PHP_EOL : '* ';
	41	+ $sql .= 'FROM '.implode($glue, $this->from);
42	42	$sql .= $this->_getWhere();
43	43	$sql .= !empty($this->groupby) ? PHP_EOL.'GROUP BY '.implode($glue, $this->groupby) : '';
44	44	$sql .= !empty($this->orderby) ? PHP_EOL.'ORDER BY '.implode($glue, $this->orderby) : '';

chillerlan / php-database

Push — master ( d508c6...ead087 )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch