chillerlan\Database\Query\StatementAbstract

Complexity

Total Complexity

13

Size/Duplication

Total Lines	122
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	sql()	0	3	1
A	bindValues()	0	16	4
A	quote()	0	6	1
A	getStatementClass()	0	5	1
B	execute()	0	9	5

<?php
/**
 * Class StatementAbstract
 *
 * @filesource   StatementAbstract.php
 * @created      03.06.2017
 * @package      chillerlan\Database\Query
 * @author       Smiley <smiley@chillerlan.net>
 * @copyright    2017 Smiley
 * @license      MIT
 */

namespace chillerlan\Database\Query;

use chillerlan\Database\Drivers\DBDriverInterface;

abstract class StatementAbstract implements StatementInterface{

	/**
	 * @var \chillerlan\Database\Drivers\DBDriverInterface
	 */
	protected $DBDriver;

	/**
	 * @var string
	 */
	protected $dialect;

	/**
	 * @var \string[]
	 */
	protected $quotes;

	/**
	 * @var int
	 */
	protected $limit;

	/**
	 * @var int
	 */
	protected $offset;

	/**
	 * @var array
	 */
	protected $bindValues = [];

	/**
	 * @var bool
	 */
	protected $offsetlimit_bound = false;

	/**
	 * @var bool
	 */
	protected $multi = false;

	/**
	 * StatementAbstract constructor.
	 *
	 * @param \chillerlan\Database\Drivers\DBDriverInterface $DBDriver
	 * @param string                                         $dialect
	 */
	public function __construct(DBDriverInterface $DBDriver, string $dialect){
		$this->DBDriver = $DBDriver;
		$this->dialect  = $dialect;
		$this->quotes   = $this->DBDriver->quotes;

Accessing quotes on the interface chillerlan\Database\Drivers\DBDriverInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

	}

	/**
	 * @return string
	 */
	public function sql():string {
		return '--NOT IMPLEMENTED';
	}

	/**
	 * @return array
	 */
	public function bindValues():array{

		if(!$this->offsetlimit_bound){
			if($this->offset){
				$this->bindValues[] = $this->offset;
			}

			if($this->limit){
				$this->bindValues[] = $this->limit;
			}

			$this->offsetlimit_bound = true;
		}

		return $this->bindValues;
	}

	/**
	 * @param string|null   $index
	 * @param array|null    $values
	 * @param callable|null $callback
	 *
	 * @return bool|\chillerlan\Database\DBResult
	 */
	public function execute(string $index = null, array $values = null, $callback = null){

		return $this->multi || !is_null($values)
			? is_callable($callback)
				? $this->DBDriver->multi_callback($this->sql(), $values, $callback)

It seems like $values defined by parameter $values on line 105 can also be of type null; however, chillerlan\Database\Drivers\DBDriverInterface::multi_callback() does only seem to accept array, maybe add an additional type check?

				: $this->DBDriver->multi($this->sql(), !empty($values) ? $values : $this->bindValues())
			: $this->DBDriver->prepared($this->sql(), $this->bindValues(), $index);

	}

	/**
	 * @param string $str
	 * @todo ...
	 * @return string
	 */
	protected function quote(string $str):string{
		$x = explode('.', $str);

		$str = $this->quotes[0].implode($this->quotes[1].'.'.$this->quotes[0], $x).$this->quotes[1];
		return $str;
	}

	/**
	 * @param string $name
	 *
	 * @return mixed

Consider making the return type a bit more specific; maybe use object.

	 */
	protected function getStatementClass(string $name){
		$class = $this->dialect.'\\'.$name;

		return new $class($this->DBDriver, $this->dialect);
	}

}