anonymous//src/DBQuery.php$0 - Code Metrics - Inspection of ":octocat:" - chillerlan/php-database - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8089c4...ec27e4 )

by smiley

created 2017-06-13 00:54 UTC

anonymous//src/DBQuery.php$0 A

↳ Parent: DBQuery::__get()

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

Importance

Changes

Metric	Value
wmc	5
cbo	1
dl	0
loc	22
rs	10
c	0
b	0
f	0

<?php
/**
 * Class DBQuery
 *
 * @filesource   DBQuery.php
 * @created      03.06.2017
 * @package      chillerlan\Database
 * @author       Smiley <[email protected]>
 * @copyright    2017 Smiley
 * @license      MIT
 */

namespace chillerlan\Database;

use chillerlan\Database\Drivers\DBDriverInterface;
use chillerlan\Database\Query\CreateInterface;
use chillerlan\Database\Query\StatementAbstract;
use chillerlan\Database\Query\CreateDatabaseInterface;
use chillerlan\Database\Query\CreateTableInterface;
/**
 * @property \chillerlan\Database\Query\SelectInterface $select
 * @property \chillerlan\Database\Query\InsertInterface $insert
 * @property \chillerlan\Database\Query\UpdateInterface $update
 * @property \chillerlan\Database\Query\DeleteInterface $delete
 * @property \chillerlan\Database\Query\CreateInterface $create
 */
class DBQuery{

	const DIALECTS = [
		'mysql'    => 'MySQL',
		'pgsql'    => 'Postgres',
		'sqlite'   => 'SQLite',
		'firebird' => 'Firebird',
	];

	/**
	 * @var \chillerlan\Database\Drivers\DBDriverInterface
	 */
	protected $DBDriver;

	/**
	 * @var string
	 */
	protected $dialect;

	/**
	 * DBQuery constructor.
	 *
	 * @param \chillerlan\Database\Drivers\DBDriverInterface $DBDriver
	 */
	public function __construct(DBDriverInterface $DBDriver){
		$this->DBDriver = $DBDriver;

		$this->dialect = __NAMESPACE__.'\\Query\\Dialects\\'.self::DIALECTS[$this->DBDriver->dialect];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
	}

	/**
	 * @param string $name
	 *
	 * @return \chillerlan\Database\Query\StatementInterface|null

	 */
	public function __get(string $name){
		$name = strtolower($name);

		if(in_array($name, ['select', 'insert', 'update', 'delete'])){
			$class = $this->dialect.'\\'.ucfirst($name);
			return new $class($this->DBDriver, $this->dialect);
		}
		elseif($name === 'create'){

			return new class($this->DBDriver, $this->dialect) extends StatementAbstract implements CreateInterface{

				public function database(string $dbname = null):CreateDatabaseInterface{
					return $this->getStatementClass('CreateDatabase')->name($dbname);
				}

				public function table(string $tablename = null):CreateTableInterface{
					return $this->getStatementClass('CreateTable')->name($tablename);
				}

				public function index():CreateInterface{
					// TODO: Implement index() method.
				}

				public function view():CreateInterface{
					// TODO: Implement view() method.
				}

				public function trigger():CreateInterface{
					// TODO: Implement trigger() method.
				}
			};

		}

		return null;
	}

}


1			<?php
2			/**
3			* Class DBQuery
4			*
5			* @filesource DBQuery.php
6			* @created 03.06.2017
7			* @package chillerlan\Database
8			* @author Smiley <[email protected]>
9			* @copyright 2017 Smiley
10			* @license MIT
11			*/
12
13			namespace chillerlan\Database;
14
15			use chillerlan\Database\Drivers\DBDriverInterface;
16			use chillerlan\Database\Query\CreateInterface;
17			use chillerlan\Database\Query\StatementAbstract;
18			use chillerlan\Database\Query\CreateDatabaseInterface;
19			use chillerlan\Database\Query\CreateTableInterface;
20			/**
21			* @property \chillerlan\Database\Query\SelectInterface $select
22			* @property \chillerlan\Database\Query\InsertInterface $insert
23			* @property \chillerlan\Database\Query\UpdateInterface $update
24			* @property \chillerlan\Database\Query\DeleteInterface $delete
25			* @property \chillerlan\Database\Query\CreateInterface $create
26			*/
27			class DBQuery{
28
29			const DIALECTS = [
30			'mysql' => 'MySQL',
31			'pgsql' => 'Postgres',
32			'sqlite' => 'SQLite',
33			'firebird' => 'Firebird',
34			];
35
36			/**
37			* @var \chillerlan\Database\Drivers\DBDriverInterface
38			*/
39			protected $DBDriver;
40
41			/**
42			* @var string
43			*/
44			protected $dialect;
45
46			/**
47			* DBQuery constructor.
48			*
49			* @param \chillerlan\Database\Drivers\DBDriverInterface $DBDriver
50			*/
51			public function __construct(DBDriverInterface $DBDriver){
52			$this->DBDriver = $DBDriver;
53
54			$this->dialect = __NAMESPACE__.'\\Query\\Dialects\\'.self::DIALECTS[$this->DBDriver->dialect];
			0 ignored issues – show Bug introduced 2017-06-06 00:33 UTC by Report Bug Copy Issue Report Accessing `dialect` on the interface `chillerlan\Database\Drivers\DBDriverInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
55			}
56
57			/**
58			* @param string $name
59			*
60			* @return \chillerlan\Database\Query\StatementInterface\|null
			0 ignored issues – show Documentation introduced 2017-06-06 00:33 UTC by Report Bug Copy Issue Report Should the return type not be `object\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
61			*/
62			public function __get(string $name){
63			$name = strtolower($name);
64
65			if(in_array($name, ['select', 'insert', 'update', 'delete'])){
66			$class = $this->dialect.'\\'.ucfirst($name);
67			return new $class($this->DBDriver, $this->dialect);
68			}
69			elseif($name === 'create'){
70
71			return new class($this->DBDriver, $this->dialect) extends StatementAbstract implements CreateInterface{
72
73			public function database(string $dbname = null):CreateDatabaseInterface{
74			return $this->getStatementClass('CreateDatabase')->name($dbname);
75			}
76
77			public function table(string $tablename = null):CreateTableInterface{
78			return $this->getStatementClass('CreateTable')->name($tablename);
79			}
80
81			public function index():CreateInterface{
82			// TODO: Implement index() method.
83			}
84
85			public function view():CreateInterface{
86			// TODO: Implement view() method.
87			}
88
89			public function trigger():CreateInterface{
90			// TODO: Implement trigger() method.
91			}
92			};
93
94			}
95
96			return null;
97			}
98
99			}
100

chillerlan / php-database

Push — master ( 8089c4...ec27e4 )

anonymous//src/DBQuery.php$0 A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like