chillerlan\Database\Query\StatementAbstract

Complexity

Total Complexity

8

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	sql()	0	3	1
A	bindValues()	0	12	3
A	execute()	0	3	1
A	quote()	0	5	1
A	getStatementClass()	0	5	1

<?php
/**
 * Class StatementAbstract
 *
 * @filesource   StatementAbstract.php
 * @created      03.06.2017
 * @package      chillerlan\Database\Query
 * @author       Smiley <smiley@chillerlan.net>
 * @copyright    2017 Smiley
 * @license      MIT
 */

namespace chillerlan\Database\Query;

use chillerlan\Database\Drivers\DBDriverInterface;

abstract class StatementAbstract implements StatementInterface{

	protected $DBDriver;
	protected $dialect;
	protected $quotes;
	protected $limit;
	protected $offset;
	protected $bindValues = [];

	public function __construct(DBDriverInterface $DBDriver, string $dialect){
		$this->DBDriver = $DBDriver;
		$this->dialect  = $dialect;
		$this->quotes   = $this->DBDriver->quotes;

Accessing quotes on the interface chillerlan\Database\Drivers\DBDriverInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

	}

	public function sql():string {
		return 'NOT IMPLEMENTED';
	}

	public function bindValues():array{

		if($this->offset){
			$this->bindValues[] = $this->offset;
		}

		if($this->limit){
			$this->bindValues[] = $this->limit;
		}

		return $this->bindValues;
	}

	public function execute(){

	}

	public function quote(string $str):string{
		// @todo ...

54% of this comment could be valid code. Did you maybe forget this after debugging?

#		$str = $this->quotes[0].$str.$this->quotes[1];
		return $str;
	}

	protected function getStatementClass(string $name){
		$class = $this->dialect.'\\'.$name;
		return new $class($this->DBDriver, $this->dialect);

	}

}