chillerlan\Database\DBQuery

Complexity

Total Complexity

3

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	__get()	0	10	2

<?php
/**
 * Class DBQuery
 *
 * @filesource   DBQuery.php
 * @created      03.06.2017
 * @package      chillerlan\Database
 * @author       Smiley <smiley@chillerlan.net>
 * @copyright    2017 Smiley
 * @license      MIT
 */

namespace chillerlan\Database;

use chillerlan\Database\Drivers\DBDriverInterface;

/**
 * @property \chillerlan\Database\Query\SelectInterface $select
 * @property \chillerlan\Database\Query\InsertInterface $insert
 * @property \chillerlan\Database\Query\UpdateInterface $update
 * @property \chillerlan\Database\Query\DeleteInterface $delete
 * @property \chillerlan\Database\Query\CreateInterface $create
 */
class DBQuery{

	const DIALECTS = [
		'mysql'    => 'MySQL',
		'pgsql'    => 'Postgres',
		'sqlite'   => 'SQLite',
		'firebird' => 'Firebird',
	];

	/**
	 * @var \chillerlan\Database\Drivers\DBDriverInterface
	 */
	protected $DBDriver;

	/**
	 * @var string
	 */
	protected $dialect;

	/**
	 * DBQuery constructor.
	 *
	 * @param \chillerlan\Database\Drivers\DBDriverInterface $DBDriver
	 */
	public function __construct(DBDriverInterface $DBDriver){
		$this->DBDriver = $DBDriver;

		$this->dialect = __NAMESPACE__.'\\Query\\Dialects\\'.self::DIALECTS[$this->DBDriver->dialect];

Accessing dialect on the interface chillerlan\Database\Drivers\DBDriverInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

	}

	/**
	 * @param string $name
	 *
	 * @return \chillerlan\Database\Query\StatementInterface|null

Should the return type not be object|null?

	 */
	public function __get(string $name){
		$name = strtolower($name);

		if(in_array($name, ['select', 'insert', 'update', 'delete', 'create'])){
			$class = $this->dialect.'\\'.ucfirst($name);
			return new $class($this->DBDriver, $this->dialect);
		}

		return null;
	}

}