chillerlan\Database\Query\OnConflictTrait::name()

Complexity

Conditions	4
Paths	5

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

<?php
	public function name(string $name, string $on_conflict = null, string $conflict_target = null):Statement{
		$this->name      = trim($name);
		$on_conflict     = trim(strtoupper($on_conflict));

It seems like $on_conflict can also be of type null; however, parameter $string of strtoupper() does only seem to accept string, maybe add an additional type check?

		$conflict_target = trim(strtoupper($conflict_target));

		if(empty($this->name)){
			throw new QueryException('no name specified');
		}

		if(!empty($on_conflict)){
			$this->on_conflict = $on_conflict;
		}

		if(!empty($conflict_target)){
			$this->conflict_target = $conflict_target;
		}

		return $this;
	}