MultiResponseHandlerTest::handleResponse() - Code Metrics - Inspection of ":octocat:" - chillerlan/php-curl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bc3bf5...3f770a )

by smiley

created 2016-02-22 23:45 UTC

MultiResponseHandlerTest::handleResponse() A

↳ Parent: MultiResponseHandlerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	1
eloc	10
nc	1
nop	1

<?php
/**
 * Class MultiResponseHandlerTest
 *
 * @filesource   MultiResponseHandlerTest.php
 * @created      15.02.2016
 * @package      chillerlan\TinyCurl
 * @author       Smiley <[email protected]>
 * @copyright    2016 Smiley
 * @license      MIT
 */

namespace chillerlan\TinyCurlTest;

use chillerlan\TinyCurl\MultiRequest;
use chillerlan\TinyCurl\Response\MultiResponseHandlerInterface;
use chillerlan\TinyCurl\Response\ResponseInterface;
use stdClass;

/**
 *
 */
class MultiResponseHandlerTest implements MultiResponseHandlerInterface{

	/**
	 * @var \chillerlan\TinyCurl\MultiRequest
	 */
	protected $request;

	public function __construct(MultiRequest $request){
		$this->request = $request;
	}

	/**
	 * @param \chillerlan\TinyCurl\Response\ResponseInterface $response
	 *
	 * @return mixed
	 */
	public function handleResponse(ResponseInterface $response){
		$data = new stdClass;
		$data->errorcode             = $response->error->code;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$data->statuscode            = $response->info->http_code;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$data->content_length_header = $response->headers->{'content-length'};
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$data->content_length_body   = $response->body->length;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$data->content_type          = $response->body->content_type;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$data->ids                   = array_column($response->json, 'id');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

		sort($data->ids);

		$this->request->addResponse($data);
	}

}


Push — master ( bc3bf5...3f770a )

MultiResponseHandlerTest::handleResponse() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Class MultiResponseHandlerTest
4			*
5			* @filesource MultiResponseHandlerTest.php
6			* @created 15.02.2016
7			* @package chillerlan\TinyCurl
8			* @author Smiley <[email protected]>
9			* @copyright 2016 Smiley
10			* @license MIT
11			*/
12
13			namespace chillerlan\TinyCurlTest;
14
15			use chillerlan\TinyCurl\MultiRequest;
16			use chillerlan\TinyCurl\Response\MultiResponseHandlerInterface;
17			use chillerlan\TinyCurl\Response\ResponseInterface;
18			use stdClass;
19
20			/**
21			*
22			*/
23			class MultiResponseHandlerTest implements MultiResponseHandlerInterface{
24
25			/**
26			* @var \chillerlan\TinyCurl\MultiRequest
27			*/
28			protected $request;
29
30			public function __construct(MultiRequest $request){
31			$this->request = $request;
32			}
33
34			/**
35			* @param \chillerlan\TinyCurl\Response\ResponseInterface $response
36			*
37			* @return mixed
38			*/
39			public function handleResponse(ResponseInterface $response){
40			$data = new stdClass;
41			$data->errorcode = $response->error->code;
			0 ignored issues – show Bug introduced 2016-02-22 23:48 UTC by Report Bug Copy Issue Report Accessing `error` on the interface `chillerlan\TinyCurl\Response\ResponseInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
42			$data->statuscode = $response->info->http_code;
			0 ignored issues – show Bug introduced 2016-02-22 23:48 UTC by Report Bug Copy Issue Report Accessing `info` on the interface `chillerlan\TinyCurl\Response\ResponseInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
43			$data->content_length_header = $response->headers->{'content-length'};
			0 ignored issues – show Bug introduced 2016-02-22 23:48 UTC by Report Bug Copy Issue Report Accessing `headers` on the interface `chillerlan\TinyCurl\Response\ResponseInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
44			$data->content_length_body = $response->body->length;
			0 ignored issues – show Bug introduced 2016-02-22 23:48 UTC by Report Bug Copy Issue Report Accessing `body` on the interface `chillerlan\TinyCurl\Response\ResponseInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45			$data->content_type = $response->body->content_type;
			0 ignored issues – show Bug introduced 2016-02-22 23:48 UTC by Report Bug Copy Issue Report Accessing `body` on the interface `chillerlan\TinyCurl\Response\ResponseInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
46			$data->ids = array_column($response->json, 'id');
			0 ignored issues – show Bug introduced 2016-02-22 23:48 UTC by Report Bug Copy Issue Report Accessing `json` on the interface `chillerlan\TinyCurl\Response\ResponseInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
47
48			sort($data->ids);
49
50			$this->request->addResponse($data);
51			}
52
53			}
54

chillerlan / php-curl

Push — master ( bc3bf5...3f770a )

MultiResponseHandlerTest::handleResponse() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like