chihiro-adachi / ec-cube

src/Eccube/Command/PluginCommand.php

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube\Command;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Validator\Constraints as Assert;
use Eccube\Command\PluginCommand\PluginGenerator;
use Eccube\Command\PluginCommand\EntityFromDbGenerator;
use Eccube\Command\PluginCommand\EntityFromYamlGenerator;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Question\Question;

class PluginCommand extends \Knp\Command\Command

Missing class doc comment

{

    protected $app;


    protected function configure()
    {
        $modeDescription = 'mode(install/uninstall/enable/disable/update/reload/generate/entity)';
        $modeDescription .= PHP_EOL;
        $modeDescription .= 'install [/path_to_tar]  - install plugin from tar or zip';
        $modeDescription .= PHP_EOL;
        $modeDescription .= 'uninstall [plugin_code] - uninstall plugin ';
        $modeDescription .= PHP_EOL;
        $modeDescription .= 'enable [plugin_code]  --- enable plugin';
        $modeDescription .= PHP_EOL;
        $modeDescription .= 'disable [plugin_code] --- disableplugin';
        $modeDescription .= PHP_EOL;
        $modeDescription .= 'reload [plugin_code] ---- reload plugin';
        $modeDescription .= PHP_EOL;
        $modeDescription .= 'generate   -------------- create plugin skeleton ';
        $modeDescription .= PHP_EOL;
        $modeDescription .= 'entity   ---------------- create Entity,Rpository,Migration';
        $this
            ->setName('plugin:develop')
            ->addArgument('mode', InputArgument::REQUIRED, $modeDescription, null)
            ->addOption('path', null, InputOption::VALUE_OPTIONAL, 'path of tar or zip')
            ->addOption('code', null, InputOption::VALUE_OPTIONAL, 'plugin code')
            ->addOption('uninstall-force', null, InputOption::VALUE_OPTIONAL, 'if set true, remove directory')
            ->setDescription('plugin commandline installer.')
            ->setHelp(<<<EOF
The <info>%command.name%</info> plugin installer runner for developer;
EOF
        );

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 8.

    }

    protected function getPluginFromCode($pluginCode)
    {
        return $this->app['eccube.repository.plugin']->findOneBy(array('del_flg' => 0, 'code' => $pluginCode));
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->app = $this->getSilexApplication();
        $this->app->initialize();
        $this->app->boot();

        $mode = $input->getArgument('mode');

        //プラグイン作成
        if ($mode == 'generate') {
            $PluginGenerator = new PluginGenerator($this->app);
            $PluginGenerator->init($this->getHelper('question'), $input, $output);

$this->getHelper('question') of type object<Symfony\Component\Console\Helper\HelperInterface> is not a sub-type of object<Symfony\Component\Console\Helper\QuestionHelper>. It seems like you assume a concrete implementation of the interface Symfony\Component\Console\Helper\HelperInterface to be always present.

            $PluginGenerator->run();
            return;

Missing blank line before return statement

        }
        //プラグインEntity用作成
        if ($mode == 'entity') {
            $output->writeln('');
            $Question = new Question('<comment>[entity]How to generate entities from db schema or yaml? [d => db, y => yaml] : </comment>', '');
            $QuestionHelper = $this->getHelper('question');
            $value = $QuestionHelper->ask($input, $output, $Question);
            $value = substr(strtolower(trim($value)), 0, 1);
            if ($value == 'd') {
                $PluginEntityGenerator = new EntityFromDbGenerator($this->app);
                $PluginEntityGenerator->init($QuestionHelper, $input, $output);

$QuestionHelper of type object<Symfony\Component\Console\Helper\HelperInterface> is not a sub-type of object<Symfony\Component\Console\Helper\QuestionHelper>. It seems like you assume a concrete implementation of the interface Symfony\Component\Console\Helper\HelperInterface to be always present.

                $PluginEntityGenerator->run();
            } elseif ($value == 'y') {
                //TODO
                $PluginEntityGenerator = new EntityFromYamlGenerator($this->app);
                $PluginEntityGenerator->init($QuestionHelper, $input, $output);

$QuestionHelper of type object<Symfony\Component\Console\Helper\HelperInterface> is not a sub-type of object<Symfony\Component\Console\Helper\QuestionHelper>. It seems like you assume a concrete implementation of the interface Symfony\Component\Console\Helper\HelperInterface to be always present.

                $PluginEntityGenerator->run();
            } else {
                //入力値正しくない
                $output->writeln('Input value is incorrect, please choose [d] for database schema or [y] for yaml file.');
            }

            return;
        }
        $path = $input->getOption('path');
        $code = $input->getOption('code');
        $uninstallForce = $input->getOption('uninstall-force');
        $service = $this->app['eccube.service.plugin'];

        if ($mode == 'install') {
            // アーカイブからインストール
            if ($path) {
                if ($service->install($path)) {
                    $output->writeln('success');

                    return;
                }
            }
            // 設置済ファイルからインストール
            if ($code) {
                $pluginDir = $service->calcPluginDir($code);
                $service->checkPluginArchiveContent($pluginDir);
                $config = $service->readYml($pluginDir . '/config.yml');

Concat operator must not be surrounded by spaces

                $event = $service->readYml($pluginDir . '/event.yml');

Concat operator must not be surrounded by spaces

                $service->checkSamePlugin($config['code']);
                $service->registerPlugin($config, $event);

                $output->writeln('success');

                return;
            }

            $output->writeln('path or code is required.');

            return;
        }
        if ($mode == 'update') {
            if (empty($code)) {
                $output->writeln('code is required.');
                return;

Missing blank line before return statement

            }
            if (empty($path)) {
                $output->writeln('path is required.');
                return;

Missing blank line before return statement

            }
            $plugin = $this->getPluginFromCode($code);
            if ($service->update($plugin, $path)) {
                $output->writeln('success');
                return;

Missing blank line before return statement

            }
        }

        if ($mode == 'uninstall') {
            if (empty($code)) {
                $output->writeln('code is required.');
                return;

Missing blank line before return statement

            }

            $plugin = $this->getPluginFromCode($code);

            // ディレクトリも含め全て削除.
            if ($uninstallForce) {
                if ($service->uninstall($plugin)) {
                    $output->writeln('success');
                    return;

Missing blank line before return statement

                }

                return;
            }

            // ディレクトリは残し, プラグインを削除.
            $pluginDir = $service->calcPluginDir($code);
            $config = $service->readYml($pluginDir . '/config.yml');

Concat operator must not be surrounded by spaces

            $service->callPluginManagerMethod($config, 'disable');
            $service->callPluginManagerMethod($config, 'uninstall');
            $service->unregisterPlugin($plugin);

            $output->writeln('success');
            return;

Missing blank line before return statement

        }

        if (in_array($mode, array('enable', 'disable'), true)) {
            if (empty($code)) {
                $output->writeln('code is required.');
                return;

Missing blank line before return statement

            }

            $plugin = $this->getPluginFromCode($code);
            if ($service->$mode($plugin)) {
                $output->writeln('success');
                return;

Missing blank line before return statement

            }
        }

        $output->writeln(' mode is not correct, try help for more options');
        $output->writeln(' plugin:develop --help  ');
    }
    

Please trim any trailing whitespace

}