chihiro-adachi / ec-cube

src/Eccube/Service/CartService.php

Doc Comments +1 added lines, -1 removed lines

@@ -231,7 +231,7 @@
     }
 
     /**
-     * @param  \Eccube\Entity\ProductClass|integer $ProductClass
+     * @param  string $ProductClass
      * @param  integer $quantity
      * @return \Eccube\Service\CartService
      * @throws CartException

src/Eccube/Service/CsvExportService.php

Doc Comments -2 removed lines

@@ -328,7 +328,6 @@ 
 
     /**
      * @param $row
-     * @param null $callback
      */
     public function fputcsv($row)
     {
@@ -425,7 +424,6 @@ 
      * XXX self::setExportQueryBuilder() をコールする前に EntityManager を取得したいので、引数で渡している
      *
      * @param array $searchData セッションから取得した検索条件の配列
-     * @param EntityManager $em
      */
     protected function findDeserializeObjects(array &$searchData)
     {

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 
 use Eccube\Common\Constant;
 use Eccube\Util\EntityUtil;
-use Symfony\Component\Form\FormFactory;
 use Symfony\Component\HttpFoundation\Request;
 use Doctrine\Common\Collections\ArrayCollection;
 

Spacing +2 added lines, -2 removed lines

@@ -309,7 +309,7 @@ 
     {
         $config = $this->config;
 
-        return function ($value) use ($config) {
+        return function($value) use ($config) {
             return mb_convert_encoding(
                 (string) $value, $config['csv_export_encoding'], 'UTF-8'
             );
@@ -434,7 +434,7 @@ 
             if ($Conditions instanceof ArrayCollection) {
                 $Conditions = new ArrayCollection(
                     array_map(
-                        function ($Entity) use ($em) {
+                        function($Entity) use ($em) {
                             return $em->getRepository(get_class($Entity))->find($Entity->getId());
                         }, $Conditions->toArray()
                     )

src/Eccube/Service/CsvImportService.php

Unused Use Statements -2 removed lines

@@ -23,8 +23,6 @@
 
 namespace Eccube\Service;
 
-use Eccube\Application;
-
 
 /**
  * Copyright (C) 2012-2014 David de Boer <david@ddeboer.nl>

Spacing +5 added lines, -5 removed lines

@@ -117,9 +117,9 @@ 
 
         $this->file = $file;
         $this->file->setFlags(
-            \SplFileObject::READ_CSV |
-            \SplFileObject::SKIP_EMPTY |
-            \SplFileObject::READ_AHEAD |
+            \SplFileObject::READ_CSV|
+            \SplFileObject::SKIP_EMPTY|
+            \SplFileObject::READ_AHEAD|
             \SplFileObject::DROP_NEW_LINE
         );
         $this->file->setCsvControl(
@@ -362,7 +362,7 @@ 
             if ($count > 1) {
                 $incrementedHeaders[] = $header;
                 for ($i = 1; $i < $count; $i++) {
-                    $incrementedHeaders[] = $header . $i;
+                    $incrementedHeaders[] = $header.$i;
                 }
             } else {
                 $incrementedHeaders[] = $header;
@@ -413,7 +413,7 @@ 
     protected function convertEncodingRows($row) {
         if ('\\' === DIRECTORY_SEPARATOR && PHP_VERSION_ID >= 70000) {
             foreach ($row as &$col) {
-                $col = mb_convert_encoding($col , 'UTF-8', 'SJIS-win');
+                $col = mb_convert_encoding($col, 'UTF-8', 'SJIS-win');
             }
         }
         return $row;

src/Eccube/Service/ShoppingService.php

Doc Comments +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
      * 仮受注情報作成
      *
      * @param $Customer
-     * @param $preOrderId
+     * @param string $preOrderId
      * @return mixed
      * @throws \Doctrine\ORM\NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException

Spacing +1 added lines, -1 removed lines

@@ -932,7 +932,7 @@
 
         // 配送日数が設定されている
         if ($deliveryDateFlag) {
-            $period = new \DatePeriod (
+            $period = new \DatePeriod(
                 new \DateTime($minDate.' day'),
                 new \DateInterval('P1D'),
                 new \DateTime($minDate + $this->app['config']['deliv_date_end_max'].' day')

src/silex-doctrine-migrations/MigrationServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
         $app['db.migrations.table_name'] = null;
         $app['db.migrations.name'] = null;
 
-        $app['dispatcher']->addListener(ConsoleEvents::INIT, function (ConsoleEvent $event) use ($app) {
+        $app['dispatcher']->addListener(ConsoleEvents::INIT, function(ConsoleEvent $event) use ($app) {
             $application = $event->getApplication();
 
             $helpers = array('dialog' => new DialogHelper());

src/Eccube/Application/ApplicationTrait.php

Spacing +10 added lines, -10 removed lines

@@ -20,32 +20,32 @@ 
      */
     public function addSuccess($message, $namespace = 'front')
     {
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.success', $message);
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.success', $message);
     }
 
     public function addError($message, $namespace = 'front')
     {
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.error', $message);
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.error', $message);
     }
 
     public function addDanger($message, $namespace = 'front')
     {
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.danger', $message);
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.danger', $message);
     }
 
     public function addWarning($message, $namespace = 'front')
     {
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.warning', $message);
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.warning', $message);
     }
 
     public function addInfo($message, $namespace = 'front')
     {
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.info', $message);
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.info', $message);
     }
 
     public function addRequestError($message, $namespace = 'front')
     {
-        $this['session']->getFlashBag()->set('eccube.' . $namespace . '.request.error', $message);
+        $this['session']->getFlashBag()->set('eccube.'.$namespace.'.request.error', $message);
     }
 
     public function clearMessage()
@@ -64,7 +64,7 @@ 
         if (is_null($namespace)) {
             $this['session']->getFlashBag()->set('eccube.login.target.path', $targetPath);
         } else {
-            $this['session']->getFlashBag()->set('eccube.' . $namespace . '.login.target.path', $targetPath);
+            $this['session']->getFlashBag()->set('eccube.'.$namespace.'.login.target.path', $targetPath);
         }
     }
 
@@ -234,14 +234,14 @@ 
         $eventName = $view;
         if ($this->isAdminRequest()) {
             // 管理画面の場合、event名に「Admin/」を付ける
-            $eventName = 'Admin/' . $view;
+            $eventName = 'Admin/'.$view;
         }
-        $this['monolog']->debug('Template Event Name : ' . $eventName);
+        $this['monolog']->debug('Template Event Name : '.$eventName);
 
         $this['eccube.event.dispatcher']->dispatch($eventName, $event);
 
         if ($response instanceof StreamedResponse) {
-            $response->setCallback(function () use ($twig, $view, $parameters) {
+            $response->setCallback(function() use ($twig, $view, $parameters) {
                 $twig->display($view, $parameters);
             });
         } else {

src/Eccube/Resource/doctrine/migration/Version20150812132454.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         // this up() migration is auto-generated, please modify it to your needs
         $t = $schema->getTable(self::NAME);
 
-        if($t->hasColumn('option_delivery_fee')){
+        if ($t->hasColumn('option_delivery_fee')) {
             $t->dropColumn('option_delivery_fee');
         }
 

src/Eccube/Resource/doctrine/migration/Version20150722170707.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     public function up(Schema $schema)
     {
 
-        if($this->connection->getDatabasePlatform()->getName() == "mysql"){
+        if ($this->connection->getDatabasePlatform()->getName() == "mysql") {
             // this up() migration is auto-generated, please modify it to your needs
             $this->addSql("alter table  dtb_base_info                 collate utf8_general_ci ;");
             $this->addSql("alter table  dtb_block                     collate utf8_general_ci ;");

src/Eccube/Resource/doctrine/migration/Version20151023102323.php

Spacing +7 added lines, -7 removed lines

@@ -27,7 +27,7 @@ 
 
         $PageLayout = new PageLayout();
         $PageLayout->setDeviceType($DeviceType);
-        $PageLayout->setName( '商品購入/お届け先の追加');
+        $PageLayout->setName('商品購入/お届け先の追加');
         $PageLayout->setUrl('shopping_shipping_edit');
         $PageLayout->setFileName('Shopping/shipping_edit');
         $PageLayout->setEditFlg(2);
@@ -38,7 +38,7 @@ 
 
         $PageLayout = new PageLayout();
         $PageLayout->setDeviceType($DeviceType);
-        $PageLayout->setName( '商品購入/お届け先の複数指定(お届け先の追加)');
+        $PageLayout->setName('商品購入/お届け先の複数指定(お届け先の追加)');
         $PageLayout->setUrl('shopping_shipping_multiple_edit');
         $PageLayout->setFileName('Shopping/shipping_multiple_edit');
         $PageLayout->setEditFlg(2);
@@ -49,7 +49,7 @@ 
 
         $PageLayout = new PageLayout();
         $PageLayout->setDeviceType($DeviceType);
-        $PageLayout->setName( '商品購入/購入エラー');
+        $PageLayout->setName('商品購入/購入エラー');
         $PageLayout->setUrl('shopping_error');
         $PageLayout->setFileName('Shopping/shopping_error');
         $PageLayout->setEditFlg(2);
@@ -60,7 +60,7 @@ 
 
         $PageLayout = new PageLayout();
         $PageLayout->setDeviceType($DeviceType);
-        $PageLayout->setName( 'ご利用ガイド');
+        $PageLayout->setName('ご利用ガイド');
         $PageLayout->setUrl('help_guide');
         $PageLayout->setFileName('Help/guide');
         $PageLayout->setEditFlg(2);
@@ -70,7 +70,7 @@ 
 
         $PageLayout = new PageLayout();
         $PageLayout->setDeviceType($DeviceType);
-        $PageLayout->setName( 'パスワード再発行(入力ページ)');
+        $PageLayout->setName('パスワード再発行(入力ページ)');
         $PageLayout->setUrl('forgot');
         $PageLayout->setFileName('Forgot/index');
         $PageLayout->setEditFlg(2);
@@ -80,7 +80,7 @@ 
 
         $PageLayout = new PageLayout();
         $PageLayout->setDeviceType($DeviceType);
-        $PageLayout->setName( 'パスワード再発行(完了ページ)');
+        $PageLayout->setName('パスワード再発行(完了ページ)');
         $PageLayout->setUrl('forgot_complete');
         $PageLayout->setFileName('Forgot/complete');
         $PageLayout->setEditFlg(2);
@@ -91,7 +91,7 @@ 
 
         $PageLayout = new PageLayout();
         $PageLayout->setDeviceType($DeviceType);
-        $PageLayout->setName( 'パスワード変更((完了ページ)');
+        $PageLayout->setName('パスワード変更((完了ページ)');
         $PageLayout->setUrl('forgot_reset');
         $PageLayout->setFileName('Forgot/reset');
         $PageLayout->setEditFlg(2);