GJClasses\Money

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getConvRate()	0	15	3
A	getConvUrl()	0	4	1
A	convertAmount()	0	3	1

<?php
namespace GJClasses;

class Money
{
    public function convertAmount($amount, $from_currency, $to_currency)
    {
        return $this->getConvRate($from_currency, $to_currency) * $amount;
    }

    public function getConvRate($from_currency, $to_currency)
    {
        list($currency_slug, $full_url) = $this->getConvUrl($from_currency, $to_currency);
        $remote = new Remote();
        $result = $remote->getFileContents($full_url);
        $json_result = json_decode($result);

It seems like $result can also be of type false; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        $conversion_rate = $json_result->{$currency_slug}->val;

        if (!is_null($conversion_rate) && $conversion_rate != '') {

            return $conversion_rate;

        } else {

            return false;

        }
    }

    public function getConvUrl($from_currency, $to_currency)
    {
        $currency_slug = $from_currency . '_' . $to_currency;
        return array($currency_slug, 'https://free.currencyconverterapi.com/api/v5/convert?q=' . $currency_slug . '&compact=y');
    }
}