ExceptionTest::testCommonException() - Code Metrics - checkdomain/Comodo - Measure and Improve Code Quality continuously with Scrutinizer

ExceptionTest::testCommonException() A
last analyzed 2019-09-13 14:14 UTC

↳ Parent: ExceptionTest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	14
Ratio	100 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	14
loc	14
rs	9.7998
cc	2
nc	2
nop	0

<?php
namespace Checkdomain\Comodo\Tests;

use Checkdomain\Comodo\Model\Exception\AccountException;
use Checkdomain\Comodo\Model\Exception\ArgumentException;

/**
 * Class ExceptionTest
 */
class ExceptionTest extends AbstractTest
{
    /**
     * tests if the argument-exception object is correctly filled
     */
    public function testArgumentException()

    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => -2,
            'errorItem'    => 'field',
            'errorMessage' => 'InvalidRequest',
        ])));

        try {
            $util->autoApplySSL([]);
        } catch (ArgumentException $e) {
            $this->assertEquals('field', $e->getArgumentName());
        }
    }

    /**
     * tests, if the common exception fields are filled
     */
    public function testCommonException()

    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => -15,
            'errorMessage' => 'Invalid Request',
        ])));

        try {
            $util->autoApplySSL([]);
        } catch (AccountException $e) {
            $this->assertEquals($e->getMessage(), 'Invalid Request');
            $this->assertEquals(-15, $e->getCode());
        }
    }
}


1		<?php
2		namespace Checkdomain\Comodo\Tests;
3
4		use Checkdomain\Comodo\Model\Exception\AccountException;
5		use Checkdomain\Comodo\Model\Exception\ArgumentException;
6
7		/**
8		* Class ExceptionTest
9		*/
10		class ExceptionTest extends AbstractTest
11		{
12		/**
13		* tests if the argument-exception object is correctly filled
14		*/
15	View Code Duplication	public function testArgumentException()
		0 ignored issues – show Duplication introduced 2017-08-07 12:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		$util = $this->createUtil($this->createGuzzleClient(http_build_query([
		0 ignored issues – show Bug introduced 2016-11-30 16:51 UTC by Report Bug Copy Issue Report It seems like `$this->createGuzzleClien... => 'InvalidRequest')))` targeting `Checkdomain\Comodo\Tests...t::createGuzzleClient()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Checkdomain\Comodo\Tests...tractTest::createUtil()` does only seem to accept `null\|object<GuzzleHttp\Client>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
18		'errorCode' => -2,
19		'errorItem' => 'field',
20		'errorMessage' => 'InvalidRequest',
21		])));
22
23		try {
24		$util->autoApplySSL([]);
25		} catch (ArgumentException $e) {
26		$this->assertEquals('field', $e->getArgumentName());
27		}
28		}
29
30		/**
31		* tests, if the common exception fields are filled
32		*/
33	View Code Duplication	public function testCommonException()
		0 ignored issues – show Duplication introduced 2017-08-07 12:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$util = $this->createUtil($this->createGuzzleClient(http_build_query([
		0 ignored issues – show Bug introduced 2016-11-30 16:51 UTC by Report Bug Copy Issue Report It seems like `$this->createGuzzleClien...=> 'Invalid Request')))` targeting `Checkdomain\Comodo\Tests...t::createGuzzleClient()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Checkdomain\Comodo\Tests...tractTest::createUtil()` does only seem to accept `null\|object<GuzzleHttp\Client>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
36		'errorCode' => -15,
37		'errorMessage' => 'Invalid Request',
38		])));
39
40		try {
41		$util->autoApplySSL([]);
42		} catch (AccountException $e) {
43		$this->assertEquals($e->getMessage(), 'Invalid Request');
44		$this->assertEquals(-15, $e->getCode());
45		}
46		}
47		}
48

checkdomain / Comodo

GitHub Access Token became invalid

ExceptionTest::testCommonException() A last analyzed 2019-09-13 14:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ExceptionTest::testCommonException() A
last analyzed 2019-09-13 14:14 UTC