UtilTest - Code Metrics - checkdomain/Comodo - Measure and Improve Code Quality continuously with Scrutinizer

UtilTest A
last analyzed 2019-09-13 14:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	339
Duplicated Lines	13.57 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	19
lcom	1
cbo	8
dl	46
loc	339
rs	10
c	0
b	0
f	0

19 Methods

Rating	Name	Duplication	Size	Complexity
A	testAutoApplySSL()	0	27	1
A	testGetDCVEMailAddressList()	0	24	1
A	testResendDCVEMail()	0	9	1
A	testEnterDCVCode()	0	15	1
A	testAutoRevokeSSL()	0	6	1
A	testAutoReplaceSSL()	0	14	1
A	testAutoUpdateDcv()	0	14	1
A	testProvideEvDetails()	0	10	1
A	testGetMdcDomainDetails()	0	16	1
A	testCheckRequestString()	0	20	1
A	testRequestException()	9	9	1
A	testArgumentException()	10	10	1
A	testAccountException()	9	9	1
A	testCsrException()	9	9	1
A	testUnknownApiException()	9	9	1
A	testUnknownException()	0	6	1
A	testCollectSslStatus()	0	12	1
A	testUpdateUserEvClickThrough()	0	11	1
A	testCollectSslPeriod()	0	30	1

How to fix Duplicated Code

<?php
namespace Checkdomain\Comodo\Tests;

use Checkdomain\Comodo\Model\Result\AutoApplyResult;
use Checkdomain\Comodo\Model\Result\AutoReplaceResult;
use Checkdomain\Comodo\Model\Result\GetDCVEMailAddressListResult;
use Checkdomain\Comodo\Model\Result\GetMDCDomainDetailsResult;

class UtilTest extends AbstractTest
{
    /**
     * test for applying SSL
     */
    public function testAutoApplySSL()
    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'            => 1,
            'totalCost'            => 12.98,
            'orderNumber'          => '123456789',
            'certificateID'        => 'abc123456',
            'expectedDeliveryTime' => '123456'
        ])));

        $result = $util->autoApplySSL([
            'test'                => 'Y',
            'product'             => 287,
            'serverSoftware'      => 2,
            'csr'                 => ('-----BEGIN CERTIFICATE REQUEST-----base64-----END CERTIFICATE REQUEST-----'),
            'isCustomerValidated' => 'Y',
            'showCertificateID'   => 'Y',
            'days'                => 365,
        ]);

        $this->assertInstanceOf(AutoApplyResult::class, $result);
        $this->assertEquals('12.98', $result->getTotalCost());
        $this->assertEquals('123456', $result->getExpectedDeliveryTime());
        $this->assertEquals('abc123456', $result->getCertificateID());
        $this->assertEquals('123456789', $result->getOrderNumber());
        $this->assertFalse($result->getPaid());
    }

    /**
     * test for getting dvc mail addresses
     */
    public function testGetDCVEMailAddressList()
    {
        // simulated response Text
        $responseText = '0'.chr(10)
            .'domain_name	www.test-domain.org'.chr(10)
            .'whois_email	 [email protected]'.chr(10)
            .'level2_email	 [email protected]'.chr(10)
            .'level2_email	 [email protected]'.chr(10)
            .'level3_email	 [email protected]'.chr(10)
            .'level3_email	 [email protected]'.chr(10);

        $util = $this->createUtil($this->createGuzzleClient($responseText));


        $result = $util->getDCVEMailAddressList(['domainName' => 'www.test-domain.org']);

        $this->assertInstanceOf(GetDCVEMailAddressListResult::class, $result);
        $this->assertEquals(['[email protected]'], $result->getWhoisEmail());
        $this->assertEquals('www.test-domain.org', $result->getDomainName());
        $this->assertEquals(['[email protected]', '[email protected]'], $result->getLevel2Emails());
        $this->assertEquals(
            ['[email protected]', '[email protected]'],
            $result->getLevel3Emails()
        );
    }

    /**
     * test for resending dcv mail
     */
    public function testResendDCVEMail()
    {
        $util = $this->createUtil($this->createGuzzleClient('errorCode=0'));


        $this->assertTrue($util->resendDCVEMail([
            'orderNumber'     => '1234567',
            'dcvEmailAddress' => '[email protected]',
        ]));
    }

    /**
     * test for entering dcv code
     */
    public function testEnterDCVCode()
    {
        // simulated response Text
        $responseText = '<html><body><p>You have entered the correct Domain Control Validation code. '
            .'Your certificate will now be issued and emailed to you shortly. '
            .'Please close this window now.'
            .'</p></body></html>';

        $util = $this->createUtil($this->createGuzzleClient($responseText));


        $this->assertTrue($util->enterDcvCode([
            'orderNumber' => '1234567',
            'dcvCode'     => 'testtesttest',
        ]));
    }

    /**
     * test for revoke ssl
     */
    public function testAutoRevokeSSL()
    {
        $util = $this->createUtil($this->createGuzzleClient('errorCode=0'));


        $this->assertTrue($util->autoRevokeSSL(['orderNumber' => '1234567']));
    }

    /**
     * test for auto replacing ssl
     */
    public function testAutoReplaceSSL()
    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'            => 0,
            'expectedDeliveryTime' => 0,
            'certificateID'        => 'abc123456',
        ])));

        $result = $util->autoReplaceSSL(['orderNumber' => '1234567']);

        $this->assertInstanceOf(AutoReplaceResult::class, $result);
        $this->assertEquals('0', $result->getExpectedDeliveryTime());
        $this->assertEquals('abc123456', $result->getCertificateID());
    }

    /**
     * test for auto updating dcv method
     */
    public function testAutoUpdateDcv()
    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'            => 0,
            'expectedDeliveryTime' => 0,
            'certificateID'        => 'abc123456',
        ])));

        $this->assertTrue($util->autoUpdateDCV([
            'orderNumber'        => '1234567',
            'newDCVEmailAddress' => '[email protected]',
            'newMethod'          => 'EMAIL',
        ]));
    }

    /**
     * test for providing ev details
     */
    public function testProvideEvDetails()
    {
        $util = $this->createUtil($this->createGuzzleClient('errorCode=0'));


        $this->assertTrue($util->autoUpdateDCV([
            'orderNumber'     => '1234567',
            'certReqForename' => 'John',
            'certReqSurname'  => 'Test',
        ]));
    }

    /**
     * test for getting current dcv method
     */
    public function testGetMdcDomainDetails()
    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => 0,
            '1_domainName' => 'test.com',
            '1_dcvMethod'  => 'EMAIL',
            '1_dcvStatus'  => 'Validated',
        ])));

        $result = $util->getMDCDomainDetails(['orderNumber' => '1234567']);

        $this->assertInstanceOf(GetMDCDomainDetailsResult::class, $result);
        $this->assertEquals('test.com', $result->getDomainName());
        $this->assertEquals('EMAIL', $result->getDcvMethod());
        $this->assertEquals('Validated', $result->getDcvStatus());
    }

    /**
     * test, if request-string is correctly formatted
     */
    public function testCheckRequestString()
    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'            => 0,
            'certificateID'        => 'abc1231556',
            'expectedDeliveryTime' => 0,
            'orderNumber'          => 12345678,
            'totalCost'            => 12.45,
        ])));

        $result = $util->autoApplySSL([
            'orderNumber'     => '1234567',
            'dcvMethod'       => 'EMAIL',
        ]);

        $this->assertEquals(
            'orderNumber=1234567&dcvMethod=EMAIL&responseFormat=1&showCertificateID=Y',
            $result->getRequestQuery()
        );
    }

    /**
     * @expectedException \Checkdomain\Comodo\Model\Exception\RequestException
     */
    public function testRequestException()

    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => -1,
            'errorMessage' => 'Invalid Request',
        ])));

        $util->autoApplySSL([]);
    }

    /**
     * @expectedException \Checkdomain\Comodo\Model\Exception\ArgumentException
     */
    public function testArgumentException()

    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => -2,
            'errorItem'    => 'field',
            'errorMessage' => 'Invalid Request',
        ])));

        $util->autoApplySSL([]);
    }

    /**
     * @expectedException \Checkdomain\Comodo\Model\Exception\AccountException
     */
    public function testAccountException()

    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => -15,
            'errorMessage' => 'Invalid Request',
        ])));

        $util->autoApplySSL([]);
    }

    /**
     * @expectedException \Checkdomain\Comodo\Model\Exception\CsrException
     */
    public function testCsrException()

    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => -5,
            'errorMessage' => 'Invalid Request',
        ])));

        $util->autoApplySSL([]);
    }

    /**
     * @expectedException \Checkdomain\Comodo\Model\Exception\UnknownApiException
     */
    public function testUnknownApiException()

    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'    => -14,
            'errorMessage' => 'Invalid Request',
        ])));

        $util->autoApplySSL([]);
    }

    /**
     * @expectedException \Checkdomain\Comodo\Model\Exception\UnknownException
     */
    public function testUnknownException()
    {
        $util = $this->createUtil($this->createGuzzleClient('Internal Server Error'));


        $util->autoApplySSL([]);
    }

    /**
     * test, for getting status of certificate
     */
    public function testCollectSslStatus()
    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'         => 1,
            'orderNumber'       => 12345678,
            'certificateStatus' => 'Issued',
        ])));

        $result = $util->collectSsl(['showExtStatus' => 'Y']);

        $this->assertEquals('Issued', $result->getCertificateStatus());
    }


    /**
     * test, for getting status of certificate
     */
    public function testUpdateUserEvClickThrough()
    {
        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode' => 0,
            'status'    => 1,
        ])));

        $result = $util->updateUserEvClickThrough([]);

        $this->assertEquals(1, $result->getStatus());
    }

    /**
     * test, for getting period of certificate
     */
    public function testCollectSslPeriod()
    {
        $caCertificate = ['-----BEGIN CERTIFICATE-----'.chr(10).'123'.chr(10).'-----END CERTIFICATE-----'];
        $certificate = '-----BEGIN CERTIFICATE-----'.chr(10).'234'.chr(10). '-----END CERTIFICATE-----';

        $util = $this->createUtil($this->createGuzzleClient(http_build_query([

            'errorCode'         => 1,
            'orderNumber'       => 12345678,
            'notBefore'         => 1388576001,
            'notAfter'          => 1420112001,
            'csrStatus'         => 4,
            'certificateStatus' => 3,
            'validationStatus'  => 1,
            'certificate'       => 234,
            'caCertificate'     => 123,
            'ovCallBackStatus'  => 2,
        ])));

        $result = $util->collectSsl([]);

        $this->assertEquals($caCertificate, $result->getCaCertificate());
        $this->assertEquals($certificate, $result->getCertificate());
        $this->assertEquals('1', $result->getValidationStatus());
        $this->assertEquals('2', $result->getOvCallBackStatus());
        $this->assertEquals('3', $result->getCertificateStatus());
        $this->assertEquals('4', $result->getCsrStatus());
        $this->assertEquals('12345678', $result->getOrderNumber());
        $this->assertEquals('01.01.2014', $result->getNotBefore()->format('d.m.Y'));
        $this->assertEquals('01.01.2015', $result->getNotAfter()->format('d.m.Y'));
    }
}


1			<?php
2			namespace Checkdomain\Comodo\Tests;
3
4			use Checkdomain\Comodo\Model\Result\AutoApplyResult;
5			use Checkdomain\Comodo\Model\Result\AutoReplaceResult;
6			use Checkdomain\Comodo\Model\Result\GetDCVEMailAddressListResult;
7			use Checkdomain\Comodo\Model\Result\GetMDCDomainDetailsResult;
8
9			class UtilTest extends AbstractTest
10			{
11			/**
12			* test for applying SSL
13			*/
14			public function testAutoApplySSL()
15			{
16			$util = $this->createUtil($this->createGuzzleClient(http_build_query([
			0 ignored issues – show Bug introduced 2016-11-30 16:51 UTC by Report Bug Copy Issue Report It seems like `$this->createGuzzleClien...eryTime' => '123456')))` targeting `Checkdomain\Comodo\Tests...t::createGuzzleClient()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Checkdomain\Comodo\Tests...tractTest::createUtil()` does only seem to accept `null\|object<GuzzleHttp\Client>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
17			'errorCode' => 1,
18			'totalCost' => 12.98,
19			'orderNumber' => '123456789',
20			'certificateID' => 'abc123456',
21			'expectedDeliveryTime' => '123456'
22			])));
23
24			$result = $util->autoApplySSL([
25			'test' => 'Y',
26			'product' => 287,
27			'serverSoftware' => 2,
28			'csr' => ('-----BEGIN CERTIFICATE REQUEST-----base64-----END CERTIFICATE REQUEST-----'),
29			'isCustomerValidated' => 'Y',
30			'showCertificateID' => 'Y',
31			'days' => 365,
32			]);
33
34			$this->assertInstanceOf(AutoApplyResult::class, $result);
35			$this->assertEquals('12.98', $result->getTotalCost());
36			$this->assertEquals('123456', $result->getExpectedDeliveryTime());
37			$this->assertEquals('abc123456', $result->getCertificateID());
38			$this->assertEquals('123456789', $result->getOrderNumber());
39			$this->assertFalse($result->getPaid());

checkdomain / Comodo

GitHub Access Token became invalid

UtilTest A last analyzed 2019-09-13 14:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

UtilTest A
last analyzed 2019-09-13 14:14 UTC