Issues in Connection.php (master) - Issues in master - chay22/RecSelMeter - Measure and Improve Code Quality continuously with Scrutinizer

Issues (17)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Connection.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Chay22\RecSelMeter;

abstract class Connection
{
	/**
	 * URL to execute
	 * 
	 * @var $url
	 */
	public $url;

	/**
	 * Contains curl_init() if success
	 *
	 * @var $init
	 */
	protected $init = false;

	/**
	 *  Additional cURL options
	 *  
	 *  @var $options
	 */
	public $options = [];

	/**
	 * @var $header
	 */
	public $header = [];

	/**
	 * @var $content
	 */
	public $content;

	/**
	 * @param  string  $url  Store URL
	 */
	function __construct($url)

	{	
		if (!function_exists('curl_version')) {
			throw new \Exception('This library needs cURL to run!');
		}
		$this->init = $this->init($url);

		$this->connection();
	}

	/**
	 * Set additional curl_setopt_array() options
	 * 
	 * @param 	array 	$options 	cURL Options
	 * @see http://php.net/manual/en/function.curl-setopt.php
	 * @return array
	 */
	public function setOptions($options = [])
	{
		return $this->options = $options;
	}

	/**
	 * Running the curl session
	 * 
	 * @return void
	 */
	public function connection()
	{
		
		$ch = $this->init;
        	curl_setopt_array($ch, ($this->options() + $this->options));
        	if (!$this->content = curl_exec($ch)){
        		throw new \Exception(
        			'CURL ERROR! Code: ' . curl_errno($ch) .
        		'	Message: ' . curl_error($ch)
        		);
        	}
        	$this->header = curl_getinfo($ch);

        	curl_close($ch);
	}

	/**
	 * Get result of both header and content from curl
	 * 
	 * @return array
	 */
	public function result()
	{
		return [
			'headers', $this->connection['headers'],
class MyClass { }

$x = new MyClass();
$x->foo = true;
			'header', $this->connection['header'],
			'content', $this->connection['content'],
		       ];
	}

	/**
	 * Set cURL options
	 * 
	 * @return array
	 */
	protected function options()
	{
		return [
			CURLOPT_RETURNTRANSFER => true,
			CURLOPT_FOLLOWLOCATION => true,
            		CURLOPT_ENCODING       => '',
            		CURLOPT_HTTP_VERSION   => CURL_HTTP_VERSION_1_1,
		       ];
	}

	/**
	 * Validate URL and start cURL session;
	 *
	 * @param  string  $url  Store URL
	 */
	protected function init($url)
	{
		//Grab url id in case $url is not valid as required url
		$id = $url;
		if (strpos($url, 'product') !== false) {
    			$id = explode('product',$url);
    			$id = end($id);
    			$id = explode('/', $id)[1];
		}
		
		//Set the $id as required url
		$this->url = 'http://fjb.kaskus.co.id/product/' . $id;
		if (!curl_init($url)) {
			throw new \Exception('Can\'t start cURL session.');
		}
		return curl_init($url);
	}
}


1		<?php
2
3		namespace Chay22\RecSelMeter;
4
5		abstract class Connection
6		{
7		/**
8		* URL to execute
9		*
10		* @var $url
11		*/
12		public $url;
13
14		/**
15		* Contains curl_init() if success
16		*
17		* @var $init
18		*/
19		protected $init = false;
20
21		/**
22		* Additional cURL options
23		*
24		* @var $options
25		*/
26		public $options = [];
27
28		/**
29		* @var $header
30		*/
31		public $header = [];
32
33		/**
34		* @var $content
35		*/
36		public $content;
37
38		/**
39		* @param string $url Store URL
40		*/
41	1	function __construct($url)
		0 ignored issues – show Best Practice introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
42		{
43	1	if (!function_exists('curl_version')) {
44		throw new \Exception('This library needs cURL to run!');
45		}
46	1	$this->init = $this->init($url);
		0 ignored issues – show Documentation Bug introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->init($url)` of type `resource` is incompatible with the declared type `boolean` of property `$init`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
47	1	$this->connection();
48	1	}
49
50		/**
51		* Set additional curl_setopt_array() options
52		*
53		* @param array $options cURL Options
54		* @see http://php.net/manual/en/function.curl-setopt.php
55		* @return array
56		*/
57		public function setOptions($options = [])
58		{
59		return $this->options = $options;
60		}
61
62		/**
63		* Running the curl session
64		*
65		* @return void
66		*/
67	1	public function connection()
68		{
69
70	1	$ch = $this->init;
71	1	curl_setopt_array($ch, ($this->options() + $this->options));
72	1	if (!$this->content = curl_exec($ch)){
73		throw new \Exception(
74		'CURL ERROR! Code: ' . curl_errno($ch) .
75		' Message: ' . curl_error($ch)
76		);
77		}
78	1	$this->header = curl_getinfo($ch);
		0 ignored issues – show Documentation Bug introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `curl_getinfo($ch)` of type `*` is incompatible with the declared type `array` of property `$header`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
79	1	curl_close($ch);
80	1	}
81
82		/**
83		* Get result of both header and content from curl
84		*
85		* @return array
86		*/
87		public function result()
88		{
89		return [
90		'headers', $this->connection['headers'],
		0 ignored issues – show Bug introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `connection` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
91		'header', $this->connection['header'],
92		'content', $this->connection['content'],
93		];
94		}
95
96		/**
97		* Set cURL options
98		*
99		* @return array
100		*/
101	1	protected function options()
102		{
103		return [
104	1	CURLOPT_RETURNTRANSFER => true,
105	1	CURLOPT_FOLLOWLOCATION => true,
106	1	CURLOPT_ENCODING => '',
107	1	CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
108	1	];
109		}
110
111		/**
112		* Validate URL and start cURL session;
113		*
114		* @param string $url Store URL
115		*/
116	1	protected function init($url)
117		{
118		//Grab url id in case $url is not valid as required url
119	1	$id = $url;
120	1	if (strpos($url, 'product') !== false) {
121	1	$id = explode('product',$url);
122	1	$id = end($id);
123	1	$id = explode('/', $id)[1];
124	1	}
125
126		//Set the $id as required url
127	1	$this->url = 'http://fjb.kaskus.co.id/product/' . $id;
128	1	if (!curl_init($url)) {
129		throw new \Exception('Can\'t start cURL session.');
130		}
131	1	return curl_init($url);
132		}
133		}
134

chay22 / RecSelMeter

Issues (17)

Security Analysis no request data

src/Connection.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like