Issues in Config.php (master) - Issues in master - chay22/RecSelMeter - Measure and Improve Code Quality continuously with Scrutinizer

Issues (17)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Config.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Chay22\RecSelMeter;


class Config
{
	/**
	 * @var array $rank
	 */
	private $rank = [

			 'auto banned'		=> -100,
			 'kaskus addict'	=> 2,
			 'kaskus maniac'	=> 3,
			 'kaskus geek'		=> 7,
			 'kaskus freak'		=> 10,
			 'made in kaskus'	=> 15,
			 'kaskus plus'		=> 15,
			 'reg. leader'		=> 15,
			 'moderator'		=> 15,
			 'kaskus online bazaar'	=> 200,
			];

	/**
	 * @var array $feedback
	 */
	private $feedback = [10];


	/**
	 * @var array $feedbackPercent
	 */
	private $feedbackPercent = [10];


	/**
	 * @var string $accountAge
	 */
	private $accountAge = 5;


	/**
	 * @var array $storeActive
	 */
	private $storeActive = [

				7 => 1,
				3 => 5,
				1 => 8,
				0 => 10,
			       ];
	/**
	 * @var string $imageCount
	 */				  
	private $imageCount = 1;


	/**
	 * @var array $sold
	 */
	private $sold = [

			 0  => 0,
			 1  => 20,
			 5  => 50,
			 10 => 100,
			];
	/**
	 * @var string $cod
	 */
	private $cod = 10;


	/**
	 * Return set of configuration data (properties)
	 * 
	 * @return array
	 */
	public function data()
	{
		return get_object_vars($this);
	}

	/**
	 * Create/add/modify chosen property value
	 *
	 * @see ::create()
	 * @see ::add()
	 * @see ::set()
	 */
	public function __call($name, $args = [])
	{	
		//Throw error if property is not found
		if (!$args = $this->validateArgs($args)) {
			throw new \Exception('Parameters need to be an array!');
		}

		//Change ::new() to ::create() since it's a reserved word
		if (stripos($name, 'new') !== false) {
			$name = str_replace('new', 'create', $name);
		}
		$method = $this->getMethod($name);
		$property = explode($method, $name);
		$property = end($property);
		$config['name'] = $this->getArgs($property);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$config['value'] = $args[0];

		return $this->{$method}($config);
	}

	private function validateArgs($args)
	{
		if (!is_array($args)) {
			return false;
		}

		foreach ($args[0] as $value) {
			if (!is_int($value)) {
				return false;
			}
		}

		return array_change_key_case($args, CASE_LOWER);
	}

	private function getMethod($name)
	{
		foreach(get_class_methods($this) as $method) {
			if(stripos($name, $method) !== false) {
				return $method;
			}
		}
		
		throw new \Exception('Method not found');
	}

	private function getArgs($name)
	{
		foreach(get_object_vars($this) as $property => $value) {
			if (stripos($property, $name) !== false) {
				return $property;
			}
		}
		
		throw new \Exception('Property not found');
	}

	/**
	 * Add new key and value for chosen config (property)
	 * 
	 * @param 	array 	$config  name of config and it's key and value
	 * @return void
	 */
	private function add($config = [])
	{
		$this->{$config['name']} += $config['value'];
	}

	/**
	 * Overwrite default configuration (key and) value
	 *
	 * @uses 	::new()
	 * @param 	array 	$config  name of config and it's key and value
	 * @return 	void
	 */
	private function create($config = [])
	{
		$this->{$config['name']} = $config['value'];
	}

	/**
	 * Modify value of configuration key
	 * 
	 * @param 	array 	$config  name of config and it's key and value
	 * @return void
	 */
	private function set($config = [])
	{	
		$this->{$config['name']} = $config['value'] + $this->{$config['name']};
	}
}


1		<?php
2
3		namespace Chay22\RecSelMeter;
4
5
6		class Config
7		{
8		/**
9		* @var array $rank
10		*/
11		private $rank = [
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$rank` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12		'auto banned' => -100,
13		'kaskus addict' => 2,
14		'kaskus maniac' => 3,
15		'kaskus geek' => 7,
16		'kaskus freak' => 10,
17		'made in kaskus' => 15,
18		'kaskus plus' => 15,
19		'reg. leader' => 15,
20		'moderator' => 15,
21		'kaskus online bazaar' => 200,
22		];
23
24		/**
25		* @var array $feedback
26		*/
27		private $feedback = [10];
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$feedback` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28
29		/**
30		* @var array $feedbackPercent
31		*/
32		private $feedbackPercent = [10];
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$feedbackPercent` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33
34		/**
35		* @var string $accountAge
36		*/
37		private $accountAge = 5;
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$accountAge` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
38
39		/**
40		* @var array $storeActive
41		*/
42		private $storeActive = [
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$storeActive` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
43		7 => 1,
44		3 => 5,
45		1 => 8,
46		0 => 10,
47		];
48		/**
49		* @var string $imageCount
50		*/
51		private $imageCount = 1;
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$imageCount` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
52
53		/**
54		* @var array $sold
55		*/
56		private $sold = [
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$sold` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
57		0 => 0,
58		1 => 20,
59		5 => 50,
60		10 => 100,
61		];
62		/**
63		* @var string $cod
64		*/
65		private $cod = 10;
		0 ignored issues – show Unused Code introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$cod` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
66
67		/**
68		* Return set of configuration data (properties)
69		*
70		* @return array
71		*/
72	4	public function data()
73		{
74	4	return get_object_vars($this);
75		}
76
77		/**
78		* Create/add/modify chosen property value
79		*
80		* @see ::create()
81		* @see ::add()
82		* @see ::set()
83		*/
84	3	public function __call($name, $args = [])
85		{
86		//Throw error if property is not found
87	3	if (!$args = $this->validateArgs($args)) {
88		throw new \Exception('Parameters need to be an array!');
89		}
90
91		//Change ::new() to ::create() since it's a reserved word
92	3	if (stripos($name, 'new') !== false) {
93	1	$name = str_replace('new', 'create', $name);
94	1	}
95	3	$method = $this->getMethod($name);
96	3	$property = explode($method, $name);
97	3	$property = end($property);
98	3	$config['name'] = $this->getArgs($property);
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-05-07 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$config` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$config = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
99	3	$config['value'] = $args[0];
100
101	3	return $this->{$method}($config);
102		}
103
104	3	private function validateArgs($args)
105		{
106	3	if (!is_array($args)) {
107		return false;
108		}
109
110	3	foreach ($args[0] as $value) {
111	3	if (!is_int($value)) {
112		return false;
113		}
114	3	}
115
116	3	return array_change_key_case($args, CASE_LOWER);
117		}
118
119	3	private function getMethod($name)
120		{
121	3	foreach(get_class_methods($this) as $method) {
122	3	if(stripos($name, $method) !== false) {
123	3	return $method;
124		}
125	3	}
126
127		throw new \Exception('Method not found');
128		}
129
130	3	private function getArgs($name)
131		{
132	3	foreach(get_object_vars($this) as $property => $value) {
133	3	if (stripos($property, $name) !== false) {
134	3	return $property;
135		}
136	1	}
137
138		throw new \Exception('Property not found');
139		}
140
141		/**
142		* Add new key and value for chosen config (property)
143		*
144		* @param array $config name of config and it's key and value
145		* @return void
146		*/
147	1	private function add($config = [])
148		{
149	1	$this->{$config['name']} += $config['value'];
150	1	}
151
152		/**
153		* Overwrite default configuration (key and) value
154		*
155		* @uses ::new()
156		* @param array $config name of config and it's key and value
157		* @return void
158		*/
159	1	private function create($config = [])
160		{
161	1	$this->{$config['name']} = $config['value'];
162	1	}
163
164		/**
165		* Modify value of configuration key
166		*
167		* @param array $config name of config and it's key and value
168		* @return void
169		*/
170	1	private function set($config = [])
171		{
172	1	$this->{$config['name']} = $config['value'] + $this->{$config['name']};
173	1	}
174		}
175

chay22 / RecSelMeter

Issues (17)

Security Analysis no request data

src/Config.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like