for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace api\actions;
use yrc\rest\Action;
use yii\helpers\Json;
/**
* @class VersionAction
* Returns the version string for the correct environment
*/
class VersionAction extends Action
{
* @param array $params
public function get(array $params = [])
$params
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.
$data = [];
$data
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$versionFile = ROOT . '/VERSION';
$gitHead = ROOT . '/.git/HEAD';
if (\file_exists($versionFile)) {
$data = Json::decode(\file_get_contents(ROOT . '/VERSION'));
} elseif (\file_exists($gitHead)) {
$gitRevision = \file_get_contents($gitHead);
$path = \explode('/', $gitRevision);
$data = [
'build' => \str_replace("\n", '', 'dev-' . $path[2]),
'date' => date('D M d h:i:s T Y', \filemtime($gitHead))
];
} else {
'build' => 'unknown',
'date' => date('D M d h:i:s T Y')
}
return $data;
charlesportwoodii /
yii2-api
Loading history...
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.