Queue::setClients() - Code Metrics - Inspection of "Changing to use Disque instead of inline handlers" - charlesportwoodii/yii2-api-rest-components - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 127008...59a424 )

by Charles

created 2016-12-23 19:04 UTC

Queue::setClients() A

↳ Parent: Queue

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	8
rs	9.4285
c	1
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

namespace yrc\components;

use Yii;
use yii\base\Object;
use Disque\Connection\Credentials;
use Disque\Client;

/**
 * Disque Manager
 * @class Queue
 */
class Queue extends Object
{
    /**
     * An array of Disque connections
     * @param array $nodes
     */
    private $nodes;

    /**
     * Adds client connections
     * @param array $clients
     * @return true
     */
    public function setClients($clients = [])
    {
        foreach ($clients as $client) {
            $this->nodes[] = new Credentials($client['host'], $client['port'], $client['password']);
        }

        return true;
    }

    /**
     * Retrieves the queue
     * @return Disque\Client
     */
    public function get()
    {
        return new Client($this->nodes);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Adds a new job to a queue
     * @param array $jobProperties
     * @param string $queueName
     * return
     */
    public function addJob($jobProperties = [], $queueName = 'app')
    {
        $job = new \Disque\Queue\Job($jobProperties);
        return $this->get()->queue($queueName)->push($job);
    }
}

1			<?php
2
3			namespace yrc\components;
4
5			use Yii;
6			use yii\base\Object;
7			use Disque\Connection\Credentials;
8			use Disque\Client;
9
10			/**
11			* Disque Manager
12			* @class Queue
13			*/
14			class Queue extends Object
15			{
16			/**
17			* An array of Disque connections
18			* @param array $nodes
19			*/
20			private $nodes;
21
22			/**
23			* Adds client connections
24			* @param array $clients
25			* @return true
26			*/
27			public function setClients($clients = [])
28			{
29			foreach ($clients as $client) {
30			$this->nodes[] = new Credentials($client['host'], $client['port'], $client['password']);
31			}
32
33			return true;
34			}
35
36			/**
37			* Retrieves the queue
38			* @return Disque\Client
39			*/
40			public function get()
41			{
42			return new Client($this->nodes);
			0 ignored issues – show Documentation introduced 2016-12-23 19:08 UTC by Report Bug Copy Issue Report `$this->nodes` is of type `array<integer,object<Dis...onnection\Credentials>>`, but the function expects a `array<integer,object<Dis...onnection\Credentials>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43			}
44
45			/**
46			* Adds a new job to a queue
47			* @param array $jobProperties
48			* @param string $queueName
49			* return
50			*/
51			public function addJob($jobProperties = [], $queueName = 'app')
52			{
53			$job = new \Disque\Queue\Job($jobProperties);
54			return $this->get()->queue($queueName)->push($job);
55			}
56			}

charlesportwoodii / yii2-api-rest-components

Push — master ( 127008...59a424 )

Queue::setClients() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like