WorkerController - Code Metrics - Inspection of "Adding RPQ behavior" - charlesportwoodii/yii2-api-rest-components - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0fae22...156482 )

by Charles

created 2018-01-13 18:07 UTC

WorkerController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	2
dl	0
loc	68
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	options()	0	7	1
B	actionProcess()	0	36	4

<?php declare(strict_types=1);

namespace yrc\commands;

use Exception;
use yii\console\Controller;
use Yii;

class WorkerController extends Controller
{
    /**
     * @var string
     * The RPQ Job ID as passed by the RPQ CLI
     */
    public $jobId;

    /**
     * @var string
     * The name of the RPQ queue that this command should search for jobs in.
     */
    public $name = 'default';

    /**
     * Command line options
     * @param string $actionID
     * @return array
     */
    public function options($actionID)
    {
        return [
            'jobId',
            'name'
        ];
    }

    /**
     * Starts a worker in process mode
     * @return integer
     */
    public function actionProcess()
    {
        $hash = explode(':', $this->jobId);
        $jobId = $hash[count($hash) - 1];

        try {
            $job = Yii::$app->rpq->getQueue($this->name)->getJob($jobId);
            $class = $job->getWorkerClass();

            if (!\class_exists($class)) {
                throw new Exception("Unable to find worker class {$class}");
            }

            if (!\is_subclass_of($class, '\RPQ\Server\AbstractJob')) {

                throw new Exception('Job does not implement RPQ\Server\AbstractJob');
            }
            
            $task = new $class(Yii::$app->rpq->getClient(), $job->getId());
            return $task->perform($job->getArgs());
        } catch (Exception $e) {
            // Log the error to the appropriate handler
            Yii::error([
                'message' => 'An error occured when executing the job',
                'jobId' => $job->getId(),
                'workerClass' => $job->getWorkerClass(),
                'queueName' => $this->name,
                'message' => $e->getMessage(),
                'code' => $e->getCode(),
                'file' => $e->getFile(),
                'line' => $e->getLine()
            ], 'rpq');
            return -1;
        }

        return 0;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
}

1			<?php declare(strict_types=1);
2
3			namespace yrc\commands;
4
5			use Exception;
6			use yii\console\Controller;
7			use Yii;
8
9			class WorkerController extends Controller
10			{
11			/**
12			* @var string
13			* The RPQ Job ID as passed by the RPQ CLI
14			*/
15			public $jobId;
16
17			/**
18			* @var string
19			* The name of the RPQ queue that this command should search for jobs in.
20			*/
21			public $name = 'default';
22
23			/**
24			* Command line options
25			* @param string $actionID
26			* @return array
27			*/
28			public function options($actionID)
29			{
30			return [
31			'jobId',
32			'name'
33			];
34			}
35
36			/**
37			* Starts a worker in process mode
38			* @return integer
39			*/
40			public function actionProcess()
41			{
42			$hash = explode(':', $this->jobId);
43			$jobId = $hash[count($hash) - 1];
44
45			try {
46			$job = Yii::$app->rpq->getQueue($this->name)->getJob($jobId);
47			$class = $job->getWorkerClass();
48
49			if (!\class_exists($class)) {
50			throw new Exception("Unable to find worker class {$class}");
51			}
52
53			if (!\is_subclass_of($class, '\RPQ\Server\AbstractJob')) {
			0 ignored issues – show Bug introduced 2018-01-13 18:10 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` returns inconsistent results on some PHP versions for interfaces; you could instead use `ReflectionClass::implementsInterface`. Loading history...
54			throw new Exception('Job does not implement RPQ\Server\AbstractJob');
55			}
56
57			$task = new $class(Yii::$app->rpq->getClient(), $job->getId());
58			return $task->perform($job->getArgs());
59			} catch (Exception $e) {
60			// Log the error to the appropriate handler
61			Yii::error([
62			'message' => 'An error occured when executing the job',
63			'jobId' => $job->getId(),
64			'workerClass' => $job->getWorkerClass(),
65			'queueName' => $this->name,
66			'message' => $e->getMessage(),
67			'code' => $e->getCode(),
68			'file' => $e->getFile(),
69			'line' => $e->getLine()
70			], 'rpq');
71			return -1;
72			}
73
74			return 0;
			0 ignored issues – show Unused Code introduced 2018-01-13 18:10 UTC by Report Bug Copy Issue Report `return 0;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
75			}
76			}

charlesportwoodii / yii2-api-rest-components

Push — master ( 0fae22...156482 )

WorkerController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like