yrc\redis\ActiveRecord

Complexity

Total Complexity

15

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	afterFind()	0	12	3
A	afterSave()	0	15	3
A	beforeSave()	0	11	3
A	isExpired()	0	18	4
A	beforeDelete()	0	13	2

<?php

namespace yrc\redis;

use yii\redis\ActiveRecord as YiiRedisActiveRecord;
use Yii;
use yii\helpers\Json;

abstract class ActiveRecord extends YiiRedisActiveRecord
{
    public $isExpired = false;

    /**
     * After find reconstitute the keypairs
     */
    public function afterFind()
    {
        // If the object is expired, delete it
        if ($this->isExpired()) {
            $this->isExpired = true;
        }
        
        if ($this->hasAttribute('data')) {
            $this->data = Json::decode($this->data);

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        return parent::afterFind();

Are you sure the usage of parent::afterFind() targeting yii\db\BaseActiveRecord::afterFind() seems to always return null.

    }

    /**
     * Return true if the token is expired
     * @return boolean
     */
    public function isExpired()
    {
        if ($this->isExpired) {
            return true;
        }
        
        if (empty($this->expires_at)) {

The property expires_at does not exist on yrc\redis\ActiveRecord. Since you implemented __get, consider adding a @property annotation.

            return false;
        }
        
        // Handle token expiration by actually deleting the token
        if ($this->expires_at < time()) {
            $this->delete();

            return true;
        }

        return false;
    }

    /**
     * @inheritdoc
     */
    public function afterSave($insert, $changedAttributes)
    {
        parent::afterSave($insert, $changedAttributes);

        // If an expiration date is set in the model attributes, tell Redis to automatically handle it
        if (!empty($this->expires_at)) {

The property expires_at does not exist on yrc\redis\ActiveRecord. Since you implemented __get, consider adding a @property annotation.

            $db = static::getDb();
            $pk = [];
            foreach ($this->primaryKey() as $key) {
                $pk[$key] = $this->getAttribute($key);
            }

            $pk = static::buildKey($pk);
            $key = static::keyPrefix() . ':a:' . $pk;
            $result = $db->executeCommand('EXPIREAT', [$key, $this->expires_at]);

The assignment to $result is dead and can be removed.

        }
    }

    /**
     * @inheritdoc
     */
    public function beforeSave($insert)
    {
        if (parent::beforeSave($insert)) {
            if ($this->hasAttribute('data')) {
                $this->data = Json::encode($this->data);

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }

            return true;
        }

        return false;
    }

    /**
     * @inheritdoc
     */
    public function beforeDelete()
    {
        if (parent::beforeDelete()) {
            // Log that the code was deleted
            Yii::debug([
                'message' => 'Deleting redis object',
                'code_id' => $this->id

The property id does not exist on yrc\redis\ActiveRecord. Since you implemented __get, consider adding a @property annotation.

            ], 'yrc/redis/ActiveRecord:delete');

            return true;
        }

        return false;
    }
}