View GitHub Repository chamilo-lms

Schedule Inspection
Subscribe

Issues (2091)

Branch: master

public/plugin/TopLinks/uninstall.php (1 issue)

← previous file next file →
1 
<?php
2 

            


            
                                                        
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
/* For license terms, see /license.txt */

            


            
                                                        
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
$plugin = TopLinksPlugin::create()->uninstall();

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
Are you sure the assignment to $plugin is correct as TopLinksPlugin::create()->uninstall() targeting TopLinksPlugin::uninstall() seems to always return null.
                                                                                                                                                                                                        

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for function or method calls that always return null and whose
return value is assigned to a variable.


class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();





The method getObject() can return nothing but null, so it makes no sense
to assign that value to a variable.


The reason is most likely that a function or method is imcomplete or has been
reduced for debug purposes.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    6