chamilo / chamilo-lms

main/link/link_goto.php

<?php
/* For licensing terms, see /license.txt */

/**
 * This page is used to launch an event when a user clicks
 * on a page linked in a course.
 * - It gets name of URL
 * - It calls the event function
 * - It redirects the user to the linked page.
 *
 * Need the liens.id, user.user_id et cours.code when called
 * ?link_id=$myrow[0]&link_url=$myrow[1]
 * url is given to avoid a new select
 *
 * @author Thomas Depraetere, Hugues Peeters, Christophe Gesch� - original versions
 */
require_once __DIR__.'/../inc/global.inc.php';
$this_section = SECTION_COURSES;

$linkId = isset($_GET['link_id']) ? $_GET['link_id'] : 0;

$linkInfo = Link::getLinkInfo($linkId);
if ($linkInfo) {

The expression $linkInfo of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

    $linkUrl = html_entity_decode(Security::remove_XSS($linkInfo['url']));
    // Launch event
    Event::event_link($linkId);

The method event_link() does not exist on Event.

    header("Cache-Control: no-store, no-cache, must-revalidate"); // HTTP/1.1
    header("Cache-Control: post-check=0, pre-check=0", false);
    header("Pragma: no-cache"); // HTTP/1.0
    header("Location: $linkUrl");
    exit;
}