chamilo /
chamilo-lms
| Conditions | 21 |
| Paths | > 20000 |
| Total Lines | 92 |
| Code Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 18 | public function up(Schema $schema) |
||
| 19 | { |
||
| 20 | $this->addSql( |
||
| 21 | 'CREATE TABLE skill_level_profile (id INT AUTO_INCREMENT NOT NULL, name VARCHAR(255) NOT NULL, PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB' |
||
| 22 | ); |
||
| 23 | $this->addSql( |
||
| 24 | 'CREATE TABLE skill_level (id INT AUTO_INCREMENT NOT NULL, profile_id INT NOT NULL, name VARCHAR(255) NOT NULL, position INT, short_name VARCHAR(255), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB' |
||
| 25 | ); |
||
| 26 | $this->addSql( |
||
| 27 | 'ALTER TABLE skill_rel_user ADD acquired_level INT, ADD argumentation TEXT, ADD argumentation_author_id INT, MODIFY course_id INT, MODIFY session_id INT' |
||
| 28 | ); |
||
| 29 | $this->addSql( |
||
| 30 | 'CREATE TABLE skill_rel_user_comment (id INT AUTO_INCREMENT NOT NULL, skill_rel_user_id INT NOT NULL, feedback_giver_id INT NOT NULL, feedback_text TEXT, feedback_value INT, feedback_datetime DATETIME, PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB' |
||
| 31 | ); |
||
| 32 | |||
| 33 | $this->addSql('ALTER TABLE skill ADD profile_id INT'); |
||
| 34 | |||
| 35 | if ($schema->hasTable('skill')) { |
||
| 36 | $table = $schema->getTable('skill'); |
||
| 37 | if ($table->hasForeignKey('FK_5E3DE477CCFA12B8') == false) { |
||
| 38 | $this->addSql('ALTER TABLE skill ADD CONSTRAINT FK_5E3DE477CCFA12B8 FOREIGN KEY (profile_id) REFERENCES skill_level_profile (id);'); |
||
| 39 | } |
||
| 40 | |||
| 41 | if ($table->hasIndex('IDX_5E3DE477CCFA12B8') == false) { |
||
| 42 | $this->addSql('CREATE INDEX IDX_5E3DE477CCFA12B8 ON skill (profile_id);'); |
||
| 43 | } |
||
| 44 | } |
||
| 45 | |||
| 46 | // Skill |
||
| 47 | if ($schema->hasTable('skill')) { |
||
| 48 | $this->addSql('ALTER TABLE skill CHANGE name name VARCHAR(255) NOT NULL, CHANGE short_code short_code VARCHAR(100) NOT NULL, CHANGE description description LONGTEXT NOT NULL, CHANGE icon icon VARCHAR(255) NOT NULL, CHANGE updated_at updated_at DATETIME NOT NULL;'); |
||
| 49 | } |
||
| 50 | |||
| 51 | // skill_rel_user |
||
| 52 | if ($schema->hasTable('skill_rel_user')) { |
||
| 53 | $table = $schema->getTable('skill_rel_user'); |
||
| 54 | $this->addSql('ALTER TABLE skill_rel_user CHANGE acquired_skill_at acquired_skill_at DATETIME NOT NULL, CHANGE argumentation argumentation LONGTEXT NOT NULL, CHANGE argumentation_author_id argumentation_author_id INT NOT NULL;'); |
||
| 55 | |||
| 56 | $this->addSql('UPDATE skill_rel_user SET course_id = NULL WHERE course_id = 0'); |
||
| 57 | $this->addSql('UPDATE skill_rel_user SET skill_id = NULL WHERE skill_id = 0'); |
||
| 58 | $this->addSql('UPDATE skill_rel_user SET user_id = NULL WHERE user_id = 0'); |
||
| 59 | $this->addSql('UPDATE skill_rel_user SET session_id = NULL WHERE session_id = 0'); |
||
| 60 | $this->addSql('UPDATE skill_rel_user SET acquired_level = NULL WHERE acquired_level = 0'); |
||
| 61 | |||
| 62 | |||
| 63 | if ($table->hasForeignKey('FK_79D3D95AA76ED395') == false) { |
||
| 64 | $this->addSql('ALTER TABLE skill_rel_user ADD CONSTRAINT FK_79D3D95AA76ED395 FOREIGN KEY (user_id) REFERENCES user (id);'); |
||
| 65 | } |
||
| 66 | if ($table->hasForeignKey('FK_79D3D95A5585C142') == false) { |
||
| 67 | $this->addSql('ALTER TABLE skill_rel_user ADD CONSTRAINT FK_79D3D95A5585C142 FOREIGN KEY (skill_id) REFERENCES skill (id);'); |
||
| 68 | } |
||
| 69 | if ($table->hasForeignKey('FK_79D3D95A591CC992') == false) { |
||
| 70 | $this->addSql('ALTER TABLE skill_rel_user ADD CONSTRAINT FK_79D3D95A591CC992 FOREIGN KEY (course_id) REFERENCES course (id);'); |
||
| 71 | } |
||
| 72 | if ($table->hasForeignKey('FK_79D3D95A613FECDF') == false) { |
||
| 73 | $this->addSql('ALTER TABLE skill_rel_user ADD CONSTRAINT FK_79D3D95A613FECDF FOREIGN KEY (session_id) REFERENCES session (id);'); |
||
| 74 | } |
||
| 75 | if ($table->hasForeignKey('FK_79D3D95AF68F11CE') == false) { |
||
| 76 | $this->addSql('ALTER TABLE skill_rel_user ADD CONSTRAINT FK_79D3D95AF68F11CE FOREIGN KEY (acquired_level) REFERENCES skill_level (id);'); |
||
| 77 | } |
||
| 78 | if ($table->hasIndex('IDX_79D3D95AA76ED395') == false) { |
||
| 79 | $this->addSql('CREATE INDEX IDX_79D3D95AA76ED395 ON skill_rel_user(user_id);'); |
||
| 80 | } |
||
| 81 | if ($table->hasIndex('IDX_79D3D95A5585C142') == false) { |
||
| 82 | $this->addSql('CREATE INDEX IDX_79D3D95A5585C142 ON skill_rel_user(skill_id);'); |
||
| 83 | } |
||
| 84 | if ($table->hasIndex('IDX_79D3D95A591CC992') == false) { |
||
| 85 | $this->addSql('CREATE INDEX IDX_79D3D95A591CC992 ON skill_rel_user(course_id);'); |
||
| 86 | } |
||
| 87 | if ($table->hasIndex('IDX_79D3D95A613FECDF') == false) { |
||
| 88 | $this->addSql('CREATE INDEX IDX_79D3D95A613FECDF ON skill_rel_user(session_id);'); |
||
| 89 | } |
||
| 90 | if ($table->hasIndex('IDX_79D3D95AF68F11CE') == false) { |
||
| 91 | $this->addSql('CREATE INDEX IDX_79D3D95AF68F11CE ON skill_rel_user (acquired_level);'); |
||
| 92 | } |
||
| 93 | if ($table->hasIndex('IDX_79D3D95AF68F11CE') == false) { |
||
| 94 | $this->addSql('CREATE INDEX idx_select_s_c_u ON skill_rel_user (session_id, course_id, user_id);'); |
||
| 95 | } |
||
| 96 | if ($table->hasIndex('IDX_79D3D95AF68F11CE') == false) { |
||
| 97 | $this->addSql('CREATE INDEX idx_select_sk_u ON skill_rel_user(skill_id, user_id);'); |
||
| 98 | } |
||
| 99 | } |
||
| 100 | |||
| 101 | // skill_level |
||
| 102 | if ($schema->hasTable('skill_level')) { |
||
| 103 | $table = $schema->getTable('skill_level'); |
||
| 104 | $this->addSql('ALTER TABLE skill_level CHANGE profile_id profile_id INT DEFAULT NULL, CHANGE position position INT NOT NULL, CHANGE short_name short_name VARCHAR(255) NOT NULL;'); |
||
| 105 | if ($table->hasForeignKey('FK_BFC25F2FCCFA12B8') == false) { |
||
| 106 | $this->addSql('ALTER TABLE skill_level ADD CONSTRAINT FK_BFC25F2FCCFA12B8 FOREIGN KEY (profile_id) REFERENCES skill_level_profile (id);'); |
||
| 107 | } |
||
| 108 | if ($table->hasIndex('IDX_BFC25F2FCCFA12B8') == false) { |
||
| 109 | $this->addSql('CREATE INDEX IDX_BFC25F2FCCFA12B8 ON skill_level (profile_id);'); |
||
| 110 | } |
||
| 132 |
